| Message ID | 20191210165454.13772-2-b-liu@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | musb fixes for v5.5-rc2 | expand |
On Tue, Dec 10, 2019 at 10:54:53AM -0600, Bin Liu wrote: > From: Mans Rullgard <mans@mansr.com> > > In order for devicetree nodes to be correctly associated with attached > devices, the controller node needs to be propagated to the glue device. > > Signed-off-by: Mans Rullgard <mans@mansr.com> > Signed-off-by: Bin Liu <b-liu@ti.com> > --- > drivers/usb/musb/sunxi.c | 2 ++ > 1 file changed, 2 insertions(+) Does this need to go to stable kernel(s)? If so, what commit does this fix fix? thanks, greg k-h
On Wed, Dec 11, 2019 at 09:05:28AM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 10, 2019 at 10:54:53AM -0600, Bin Liu wrote: > > From: Mans Rullgard <mans@mansr.com> > > > > In order for devicetree nodes to be correctly associated with attached > > devices, the controller node needs to be propagated to the glue device. > > > > Signed-off-by: Mans Rullgard <mans@mansr.com> > > Signed-off-by: Bin Liu <b-liu@ti.com> > > --- > > drivers/usb/musb/sunxi.c | 2 ++ > > 1 file changed, 2 insertions(+) > > Does this need to go to stable kernel(s)? If so, what commit does this > fix fix? No, I'd say it's a new feature. Johan
On Wed, Dec 11, 2019 at 09:49:35AM +0100, Johan Hovold wrote: > On Wed, Dec 11, 2019 at 09:05:28AM +0100, Greg Kroah-Hartman wrote: > > On Tue, Dec 10, 2019 at 10:54:53AM -0600, Bin Liu wrote: > > > From: Mans Rullgard <mans@mansr.com> > > > > > > In order for devicetree nodes to be correctly associated with attached > > > devices, the controller node needs to be propagated to the glue device. > > > > > > Signed-off-by: Mans Rullgard <mans@mansr.com> > > > Signed-off-by: Bin Liu <b-liu@ti.com> > > > --- > > > drivers/usb/musb/sunxi.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Does this need to go to stable kernel(s)? If so, what commit does this > > fix fix? > > No, I'd say it's a new feature. Then why is it needed for 5.5-final and not for 5.6-rc1? thanks, greg k-h
On Wed, Dec 11, 2019 at 09:51:22AM +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 11, 2019 at 09:49:35AM +0100, Johan Hovold wrote: > > On Wed, Dec 11, 2019 at 09:05:28AM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Dec 10, 2019 at 10:54:53AM -0600, Bin Liu wrote: > > > > From: Mans Rullgard <mans@mansr.com> > > > > > > > > In order for devicetree nodes to be correctly associated with attached > > > > devices, the controller node needs to be propagated to the glue device. > > > > > > > > Signed-off-by: Mans Rullgard <mans@mansr.com> > > > > Signed-off-by: Bin Liu <b-liu@ti.com> > > > > --- > > > > drivers/usb/musb/sunxi.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > Does this need to go to stable kernel(s)? If so, what commit does this > > > fix fix? > > > > No, I'd say it's a new feature. > > Then why is it needed for 5.5-final and not for 5.6-rc1? Right, it shouldn't be needed in 5.5. Johan
diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c index 832a41f9ee7d..a72665fbf111 100644 --- a/drivers/usb/musb/sunxi.c +++ b/drivers/usb/musb/sunxi.c @@ -781,6 +781,8 @@ static int sunxi_musb_probe(struct platform_device *pdev) pinfo.name = "musb-hdrc"; pinfo.id = PLATFORM_DEVID_AUTO; pinfo.parent = &pdev->dev; + pinfo.fwnode = of_fwnode_handle(pdev->dev.of_node); + pinfo.of_node_reused = true; pinfo.res = pdev->resource; pinfo.num_res = pdev->num_resources; pinfo.data = &pdata;