diff mbox series

blk-cgroup: remove blkcg_drain_queue

Message ID 20191212140851.19107-1-guoqing.jiang@cloud.ionos.com (mailing list archive)
State New, archived
Headers show
Series blk-cgroup: remove blkcg_drain_queue | expand

Commit Message

Guoqing Jiang Dec. 12, 2019, 2:08 p.m. UTC 
From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>

Since blk_drain_queue had already been removed, so this function
is not needed anymore.

Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
---
 block/blk-cgroup.c | 20 --------------------
 1 file changed, 20 deletions(-)

Comments

Jens Axboe Dec. 12, 2019, 3:17 p.m. UTC | #1 
On 12/12/19 7:08 AM, jgq516@gmail.com wrote:
> From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
> 
> Since blk_drain_queue had already been removed, so this function
> is not needed anymore.

You should remove it from include/linux/blk-cgroup.h as well.
Guoqing Jiang Dec. 12, 2019, 3:45 p.m. UTC | #2 
On 12/12/19 4:17 PM, Jens Axboe wrote:
> On 12/12/19 7:08 AM, jgq516@gmail.com wrote:
>> From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
>>
>> Since blk_drain_queue had already been removed, so this function
>> is not needed anymore.
> You should remove it from include/linux/blk-cgroup.h as well.
>

Ok, will send a new version.

Thanks,
Guoqing
diff mbox series

Patch

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 708dea92dac8..a229b94d5390 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -1061,26 +1061,6 @@  int blkcg_init_queue(struct request_queue *q)
 	return PTR_ERR(blkg);
 }
 
-/**
- * blkcg_drain_queue - drain blkcg part of request_queue
- * @q: request_queue to drain
- *
- * Called from blk_drain_queue().  Responsible for draining blkcg part.
- */
-void blkcg_drain_queue(struct request_queue *q)
-{
-	lockdep_assert_held(&q->queue_lock);
-
-	/*
-	 * @q could be exiting and already have destroyed all blkgs as
-	 * indicated by NULL root_blkg.  If so, don't confuse policies.
-	 */
-	if (!q->root_blkg)
-		return;
-
-	blk_throtl_drain(q);
-}
-
 /**
  * blkcg_exit_queue - exit and release blkcg part of request_queue
  * @q: request_queue being released