mbox series

[kvm-unit-tests,v2,00/18] arm/arm64: Various fixes

Message ID 20191128180418.6938-1-alexandru.elisei@arm.com (mailing list archive)
Headers show
Series arm/arm64: Various fixes | expand

Message

Alexandru Elisei Nov. 28, 2019, 6:04 p.m. UTC 
This is a combination of the fixes from my EL2 series [1] and other new
fixes.

Changes in v2:
* Fixed the prefetch abort test on QEMU by changing the address used to
  cause the abort.

Summary of the patches:
* Patch 1 adds coherent translation table walks for ARMv7 and removes
  unneeded dcache maintenance.
* Patches 2-4 make translation table updates more robust.
* Patches 5-6 fix a pretty serious bug in our PSCI test, which was causing
  an infinite loop of prefetch aborts.
* Patches 7-10 add a proper test for prefetch aborts. The test now uses
  mmu_clear_user.
* Patches 11-13 are fixes for the timer test.
* Patches 14-15 fix turning the MMU off.
* Patches 16-18 are small fixes to make the code more robust, and perhaps
  more important, remove unnecessary operations that might hide real bugs
  in KVM.

Patches 1-4, 9, 18 are new. The rest are taken from the EL2 series, and
I've kept the Reviewed-by tag where appropriate. There are no major
changes, only those caused by rebasing on top of the current kvm-unit-tests
version.

Please review.

[1] https://www.spinics.net/lists/kvm/msg196797.html

Alexandru Elisei (18):
  lib: arm/arm64: Remove unnecessary dcache maintenance operations
  lib: arm64: Remove barriers before TLB operations
  lib: Add WRITE_ONCE and READ_ONCE implementations in compiler.h
  lib: arm/arm64: Use WRITE_ONCE to update the translation tables
  lib: arm/arm64: Remove unused CPU_OFF parameter
  arm/arm64: psci: Don't run C code without stack or vectors
  lib: arm/arm64: Add missing include for alloc_page.h in pgtable.h
  lib: arm: Implement flush_tlb_all
  lib: arm/arm64: Teach mmu_clear_user about block mappings
  arm/arm64: selftest: Add prefetch abort test
  arm64: timer: Write to ICENABLER to disable timer IRQ
  arm64: timer: EOIR the interrupt after masking the timer
  arm64: timer: Test behavior when timer disabled or masked
  lib: arm/arm64: Refuse to disable the MMU with non-identity stack
    pointer
  arm/arm64: Perform dcache clean + invalidate after turning MMU off
  arm: cstart64.S: Downgrade TLBI to non-shareable in asm_mmu_enable
  arm/arm64: Invalidate TLB before enabling MMU
  arm: cstart64.S: Remove icache invalidation from asm_mmu_enable

 lib/linux/compiler.h          |  81 ++++++++++++++++++++++++
 lib/arm/asm/gic-v3.h          |   1 +
 lib/arm/asm/gic.h             |   1 +
 lib/arm/asm/mmu-api.h         |   2 +-
 lib/arm/asm/mmu.h             |  11 ++--
 lib/arm/asm/pgtable-hwdef.h   |  11 ++++
 lib/arm/asm/pgtable.h         |  20 ++++--
 lib/arm/asm/processor.h       |   6 ++
 lib/arm64/asm/esr.h           |   3 +
 lib/arm64/asm/mmu.h           |   2 -
 lib/arm64/asm/pgtable-hwdef.h |   3 +
 lib/arm64/asm/pgtable.h       |  15 ++++-
 lib/arm64/asm/processor.h     |   6 ++
 lib/arm/mmu.c                 |  64 +++++++++++--------
 lib/arm/processor.c           |  10 +++
 lib/arm/psci.c                |   4 +-
 lib/arm/setup.c               |   2 +
 lib/arm64/processor.c         |  11 ++++
 arm/cstart.S                  |  40 +++++++++++-
 arm/cstart64.S                |  35 ++++++++++-
 arm/cache.c                   |   3 +-
 arm/psci.c                    |   5 +-
 arm/selftest.c                | 112 +++++++++++++++++++++++++++++++++-
 arm/timer.c                   |  38 ++++++++----
 24 files changed, 421 insertions(+), 65 deletions(-)
 create mode 100644 lib/linux/compiler.h

Comments

Andrew Jones Dec. 13, 2019, 6:51 p.m. UTC | #1 
On Thu, Nov 28, 2019 at 06:04:00PM +0000, Alexandru Elisei wrote:
> This is a combination of the fixes from my EL2 series [1] and other new
> fixes.
> 
> Changes in v2:
> * Fixed the prefetch abort test on QEMU by changing the address used to
>   cause the abort.
> 
> Summary of the patches:
> * Patch 1 adds coherent translation table walks for ARMv7 and removes
>   unneeded dcache maintenance.
> * Patches 2-4 make translation table updates more robust.
> * Patches 5-6 fix a pretty serious bug in our PSCI test, which was causing
>   an infinite loop of prefetch aborts.
> * Patches 7-10 add a proper test for prefetch aborts. The test now uses
>   mmu_clear_user.
> * Patches 11-13 are fixes for the timer test.
> * Patches 14-15 fix turning the MMU off.
> * Patches 16-18 are small fixes to make the code more robust, and perhaps
>   more important, remove unnecessary operations that might hide real bugs
>   in KVM.
> 
> Patches 1-4, 9, 18 are new. The rest are taken from the EL2 series, and
> I've kept the Reviewed-by tag where appropriate. There are no major
> changes, only those caused by rebasing on top of the current kvm-unit-tests
> version.

This series looks good to me, but it needs another rebase due to 
a299895b7abb ("Switch the order of the parameters in report() and
report_xfail()") and there are a few minor comments to address.

> 
> Please review.
> 
> [1] https://www.spinics.net/lists/kvm/msg196797.html

It's almost at the top of the TODO! I might even get to it during the
holidays. Of course it could probably use a rebase now too.

Thanks,
drew