| Message ID | 20191213121036.8886-1-yukuai3@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | EDAC: remove set but not used variable 'ecc_loc' | expand |
On Fri, Dec 13, 2019 at 08:10:36PM +0800, yu kuai wrote: > @@ -499,7 +498,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan, > pci_read_config_dword(pdev, I5100_REDMEMA, &dw2); > syndrome = dw2; > pci_read_config_dword(pdev, I5100_REDMEMB, &dw2); > - ecc_loc = i5100_redmemb_ecc_locator(dw2); > } > > if (i5100_validlog_recmemvalid(dw)) { This deletes the only call to i5100_redmemb_ecc_locator(). Should we delete the definition of the function too? Is it worth making cosmetic cleanups to a driver for 12 year old h/w? -Tony
On 2019/12/14 7:11, Luck, Tony wrote: > On Fri, Dec 13, 2019 at 08:10:36PM +0800, yu kuai wrote: >> @@ -499,7 +498,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan, >> pci_read_config_dword(pdev, I5100_REDMEMA, &dw2); >> syndrome = dw2; >> pci_read_config_dword(pdev, I5100_REDMEMB, &dw2); >> - ecc_loc = i5100_redmemb_ecc_locator(dw2); >> } >> >> if (i5100_validlog_recmemvalid(dw)) { > > This deletes the only call to i5100_redmemb_ecc_locator(). Should > we delete the definition of the function too? Thank you for your response! Yes, I think we can do that. Thanks Yu Kuai > > Is it worth making cosmetic cleanups to a driver for 12 year old h/w? > > -Tony > > . >
diff --git a/drivers/edac/i5100_edac.c b/drivers/edac/i5100_edac.c index 0ddc41e47a96..a7ccf7b13619 100644 --- a/drivers/edac/i5100_edac.c +++ b/drivers/edac/i5100_edac.c @@ -486,7 +486,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan, u32 dw; u32 dw2; unsigned syndrome = 0; - unsigned ecc_loc = 0; unsigned merr; unsigned bank; unsigned rank; @@ -499,7 +498,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan, pci_read_config_dword(pdev, I5100_REDMEMA, &dw2); syndrome = dw2; pci_read_config_dword(pdev, I5100_REDMEMB, &dw2); - ecc_loc = i5100_redmemb_ecc_locator(dw2); } if (i5100_validlog_recmemvalid(dw)) {
Fixes gcc '-Wunused-but-set-variable' warning: drivers/edac/i5100_edac.c: In function ‘i5100_read_log’: drivers/edac/i5100_edac.c:489:11: warning: variable ‘ecc_loc’ set but not used [-Wunused-but-set-variable] Signed-off-by: yu kuai <yukuai3@huawei.com> --- drivers/edac/i5100_edac.c | 2 -- 1 file changed, 2 deletions(-)