| Message ID | 20191118164512.8676-8-digetx@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | NVIDIA Tegra20 CPUFreq driver major update | expand |
18.11.2019 19:45, Dmitry Osipenko пишет: > Both NVIDIA Tegra20 and Tegra30 SoCs should be blacklisted because CPU > OPPs use supported_hw and thus platdev isn't suitable for these SoCs. > Currently cpufreq-dt driver produces a bit annoying warning splats > during boot because valid OPPs are not found, this will be fixed once > tegra20-cpufreq driver will be update to support cpufreq-dt. The warnings > will also happen on older stable kernels using newer device-trees, thus > this patch should be backported to stable kernels as well. > > Cc: <stable@vger.kernel.org> > Reported-by: Jon Hunter <jonathanh@nvidia.com> > Fixes: 4053aa65c517 ("ARM: tegra: cardhu-a04: Add CPU Operating Performance Points") > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c > index f1d170dcf4d3..aba591d57c67 100644 > --- a/drivers/cpufreq/cpufreq-dt-platdev.c > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c > @@ -121,6 +121,8 @@ static const struct of_device_id blacklist[] __initconst = { > { .compatible = "mediatek,mt8176", }, > { .compatible = "mediatek,mt8183", }, > > + { .compatible = "nvidia,tegra20", }, > + { .compatible = "nvidia,tegra30", }, > { .compatible = "nvidia,tegra124", }, > { .compatible = "nvidia,tegra210", }, > > Hello Viresh, Could you please pick up this patch for v5.5 fixes? Thanks in advance!
18.11.2019 19:51, Dmitry Osipenko пишет: > 18.11.2019 19:45, Dmitry Osipenko пишет: >> Both NVIDIA Tegra20 and Tegra30 SoCs should be blacklisted because CPU >> OPPs use supported_hw and thus platdev isn't suitable for these SoCs. >> Currently cpufreq-dt driver produces a bit annoying warning splats >> during boot because valid OPPs are not found, this will be fixed once >> tegra20-cpufreq driver will be update to support cpufreq-dt. The warnings >> will also happen on older stable kernels using newer device-trees, thus >> this patch should be backported to stable kernels as well. >> >> Cc: <stable@vger.kernel.org> >> Reported-by: Jon Hunter <jonathanh@nvidia.com> >> Fixes: 4053aa65c517 ("ARM: tegra: cardhu-a04: Add CPU Operating Performance Points") >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- >> drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c >> index f1d170dcf4d3..aba591d57c67 100644 >> --- a/drivers/cpufreq/cpufreq-dt-platdev.c >> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c >> @@ -121,6 +121,8 @@ static const struct of_device_id blacklist[] __initconst = { >> { .compatible = "mediatek,mt8176", }, >> { .compatible = "mediatek,mt8183", }, >> >> + { .compatible = "nvidia,tegra20", }, >> + { .compatible = "nvidia,tegra30", }, >> { .compatible = "nvidia,tegra124", }, >> { .compatible = "nvidia,tegra210", }, >> >> > > Hello Viresh, > > Could you please pick up this patch for v5.5 fixes? Thanks in advance! > Viresh / Rafael? Maybe I should send that patch separately?
On 18-11-19, 19:45, Dmitry Osipenko wrote: > Both NVIDIA Tegra20 and Tegra30 SoCs should be blacklisted because CPU > OPPs use supported_hw and thus platdev isn't suitable for these SoCs. > Currently cpufreq-dt driver produces a bit annoying warning splats > during boot because valid OPPs are not found, this will be fixed once > tegra20-cpufreq driver will be update to support cpufreq-dt. The warnings > will also happen on older stable kernels using newer device-trees, thus > this patch should be backported to stable kernels as well. > > Cc: <stable@vger.kernel.org> > Reported-by: Jon Hunter <jonathanh@nvidia.com> > Fixes: 4053aa65c517 ("ARM: tegra: cardhu-a04: Add CPU Operating Performance Points") > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c > index f1d170dcf4d3..aba591d57c67 100644 > --- a/drivers/cpufreq/cpufreq-dt-platdev.c > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c > @@ -121,6 +121,8 @@ static const struct of_device_id blacklist[] __initconst = { > { .compatible = "mediatek,mt8176", }, > { .compatible = "mediatek,mt8183", }, > > + { .compatible = "nvidia,tegra20", }, > + { .compatible = "nvidia,tegra30", }, > { .compatible = "nvidia,tegra124", }, > { .compatible = "nvidia,tegra210", }, Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On 16-12-19, 09:35, Viresh Kumar wrote: > On 18-11-19, 19:45, Dmitry Osipenko wrote: > > Both NVIDIA Tegra20 and Tegra30 SoCs should be blacklisted because CPU > > OPPs use supported_hw and thus platdev isn't suitable for these SoCs. > > Currently cpufreq-dt driver produces a bit annoying warning splats > > during boot because valid OPPs are not found, this will be fixed once > > tegra20-cpufreq driver will be update to support cpufreq-dt. The warnings > > will also happen on older stable kernels using newer device-trees, thus > > this patch should be backported to stable kernels as well. > > > > Cc: <stable@vger.kernel.org> > > Reported-by: Jon Hunter <jonathanh@nvidia.com> > > Fixes: 4053aa65c517 ("ARM: tegra: cardhu-a04: Add CPU Operating Performance Points") > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > --- > > drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c > > index f1d170dcf4d3..aba591d57c67 100644 > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c > > @@ -121,6 +121,8 @@ static const struct of_device_id blacklist[] __initconst = { > > { .compatible = "mediatek,mt8176", }, > > { .compatible = "mediatek,mt8183", }, > > > > + { .compatible = "nvidia,tegra20", }, > > + { .compatible = "nvidia,tegra30", }, > > { .compatible = "nvidia,tegra124", }, > > { .compatible = "nvidia,tegra210", }, > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Oops, pasted the wrong register here :( Applied. Thanks.
16.12.2019 07:08, Viresh Kumar пишет: > On 16-12-19, 09:35, Viresh Kumar wrote: >> On 18-11-19, 19:45, Dmitry Osipenko wrote: >>> Both NVIDIA Tegra20 and Tegra30 SoCs should be blacklisted because CPU >>> OPPs use supported_hw and thus platdev isn't suitable for these SoCs. >>> Currently cpufreq-dt driver produces a bit annoying warning splats >>> during boot because valid OPPs are not found, this will be fixed once >>> tegra20-cpufreq driver will be update to support cpufreq-dt. The warnings >>> will also happen on older stable kernels using newer device-trees, thus >>> this patch should be backported to stable kernels as well. >>> >>> Cc: <stable@vger.kernel.org> >>> Reported-by: Jon Hunter <jonathanh@nvidia.com> >>> Fixes: 4053aa65c517 ("ARM: tegra: cardhu-a04: Add CPU Operating Performance Points") >>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >>> --- >>> drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c >>> index f1d170dcf4d3..aba591d57c67 100644 >>> --- a/drivers/cpufreq/cpufreq-dt-platdev.c >>> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c >>> @@ -121,6 +121,8 @@ static const struct of_device_id blacklist[] __initconst = { >>> { .compatible = "mediatek,mt8176", }, >>> { .compatible = "mediatek,mt8183", }, >>> >>> + { .compatible = "nvidia,tegra20", }, >>> + { .compatible = "nvidia,tegra30", }, >>> { .compatible = "nvidia,tegra124", }, >>> { .compatible = "nvidia,tegra210", }, >> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > Oops, pasted the wrong register here :( > > Applied. Thanks. > Thanks!
diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c index f1d170dcf4d3..aba591d57c67 100644 --- a/drivers/cpufreq/cpufreq-dt-platdev.c +++ b/drivers/cpufreq/cpufreq-dt-platdev.c @@ -121,6 +121,8 @@ static const struct of_device_id blacklist[] __initconst = { { .compatible = "mediatek,mt8176", }, { .compatible = "mediatek,mt8183", }, + { .compatible = "nvidia,tegra20", }, + { .compatible = "nvidia,tegra30", }, { .compatible = "nvidia,tegra124", }, { .compatible = "nvidia,tegra210", },
Both NVIDIA Tegra20 and Tegra30 SoCs should be blacklisted because CPU OPPs use supported_hw and thus platdev isn't suitable for these SoCs. Currently cpufreq-dt driver produces a bit annoying warning splats during boot because valid OPPs are not found, this will be fixed once tegra20-cpufreq driver will be update to support cpufreq-dt. The warnings will also happen on older stable kernels using newer device-trees, thus this patch should be backported to stable kernels as well. Cc: <stable@vger.kernel.org> Reported-by: Jon Hunter <jonathanh@nvidia.com> Fixes: 4053aa65c517 ("ARM: tegra: cardhu-a04: Add CPU Operating Performance Points") Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/cpufreq/cpufreq-dt-platdev.c | 2 ++ 1 file changed, 2 insertions(+)