| Message ID | 1573053633-21437-3-git-send-email-mirela.rabulea@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add V4L2 driver for i.MX8 JPEG Encoder/Decoder | expand |
On 11/6/19 4:20 PM, Mirela Rabulea wrote: > The power domains are for imx8qxp/imx8qm JPEG encoder & decoder. > Each has 4 slots and a wrapper. > > Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com> Shawn, Daniel, can I have an Ack from you? It probably makes sense that this patch gets merged via the media subsystem. Regards, Hans > --- > drivers/firmware/imx/scu-pd.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c > index b556612..e7bf48a 100644 > --- a/drivers/firmware/imx/scu-pd.c > +++ b/drivers/firmware/imx/scu-pd.c > @@ -158,6 +158,12 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = { > /* DC SS */ > { "dc0", IMX_SC_R_DC_0, 1, false, 0 }, > { "dc0-pll", IMX_SC_R_DC_0_PLL_0, 2, true, 0 }, > + > + /* IMAGE SS */ > + { "img-jpegdec-mp", IMX_SC_R_MJPEG_DEC_MP, 1, false, 0 }, > + { "img-jpegdec-s0", IMX_SC_R_MJPEG_DEC_S0, 4, true, 0 }, > + { "img-jpegenc-mp", IMX_SC_R_MJPEG_ENC_MP, 1, false, 0 }, > + { "img-jpegenc-s0", IMX_SC_R_MJPEG_ENC_S0, 4, true, 0 }, > }; > > static const struct imx_sc_pd_soc imx8qxp_scu_pd = { >
On Fri, 2019-12-13 at 10:49 +0100, Hans Verkuil wrote: > On 11/6/19 4:20 PM, Mirela Rabulea wrote: > > The power domains are for imx8qxp/imx8qm JPEG encoder & decoder. > > Each has 4 slots and a wrapper. > > > > Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com> > > Shawn, Daniel, can I have an Ack from you? It probably makes sense > that > this patch gets merged via the media subsystem. I hope I'm the Daniel you are referring to. It looks good to me. Acked-by: Daniel Baluta <daniel.baluta@nxp.com> > > Regards, > > Hans > > > --- > > drivers/firmware/imx/scu-pd.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/firmware/imx/scu-pd.c > > b/drivers/firmware/imx/scu-pd.c > > index b556612..e7bf48a 100644 > > --- a/drivers/firmware/imx/scu-pd.c > > +++ b/drivers/firmware/imx/scu-pd.c > > @@ -158,6 +158,12 @@ static const struct imx_sc_pd_range > > imx8qxp_scu_pd_ranges[] = { > > /* DC SS */ > > { "dc0", IMX_SC_R_DC_0, 1, false, 0 }, > > { "dc0-pll", IMX_SC_R_DC_0_PLL_0, 2, true, 0 }, > > + > > + /* IMAGE SS */ > > + { "img-jpegdec-mp", IMX_SC_R_MJPEG_DEC_MP, 1, false, 0 }, > > + { "img-jpegdec-s0", IMX_SC_R_MJPEG_DEC_S0, 4, true, 0 }, > > + { "img-jpegenc-mp", IMX_SC_R_MJPEG_ENC_MP, 1, false, 0 }, > > + { "img-jpegenc-s0", IMX_SC_R_MJPEG_ENC_S0, 4, true, 0 }, > > }; > > > > static const struct imx_sc_pd_soc imx8qxp_scu_pd = { > > > >
Hi Hans, On Fri, Dec 13, 2019 at 10:49:03AM +0100, Hans Verkuil wrote: > On 11/6/19 4:20 PM, Mirela Rabulea wrote: > > The power domains are for imx8qxp/imx8qm JPEG encoder & decoder. > > Each has 4 slots and a wrapper. > > > > Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com> > > Shawn, Daniel, can I have an Ack from you? It probably makes sense that > this patch gets merged via the media subsystem. I do not see a hard compile time dependency here. In that case, I prefer to still merge it through my tree to avoid possible conflicts. Shawn
diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c index b556612..e7bf48a 100644 --- a/drivers/firmware/imx/scu-pd.c +++ b/drivers/firmware/imx/scu-pd.c @@ -158,6 +158,12 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = { /* DC SS */ { "dc0", IMX_SC_R_DC_0, 1, false, 0 }, { "dc0-pll", IMX_SC_R_DC_0_PLL_0, 2, true, 0 }, + + /* IMAGE SS */ + { "img-jpegdec-mp", IMX_SC_R_MJPEG_DEC_MP, 1, false, 0 }, + { "img-jpegdec-s0", IMX_SC_R_MJPEG_DEC_S0, 4, true, 0 }, + { "img-jpegenc-mp", IMX_SC_R_MJPEG_ENC_MP, 1, false, 0 }, + { "img-jpegenc-s0", IMX_SC_R_MJPEG_ENC_S0, 4, true, 0 }, }; static const struct imx_sc_pd_soc imx8qxp_scu_pd = {
The power domains are for imx8qxp/imx8qm JPEG encoder & decoder. Each has 4 slots and a wrapper. Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com> --- drivers/firmware/imx/scu-pd.c | 6 ++++++ 1 file changed, 6 insertions(+)