| Message ID | 20191213103304.12867-1-jbrunet@baylibre.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b1b3f0622a9d52ac19a63619911823c89a4d85a4 |
| Delegated to: | Neil Armstrong |
| Headers | show |
| Series | clk: meson: g12a: fix missing uart2 in regmap table | expand |
On 13/12/2019 11:33, Jerome Brunet wrote: > UART2 peripheral is missing from the regmap fixup table of the g12a family > clock controller. As it is, any access to this clock would Oops, which is > not great. > > Add the clock to the table to fix the problem. > > Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller") > Reported-by: Dmitry Shmidt <dimitrysh@google.com> > Tested-by: Dmitry Shmidt <dimitrysh@google.com> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > --- > drivers/clk/meson/g12a.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c > index 66cf791bfc8c..cd1de3e004e4 100644 > --- a/drivers/clk/meson/g12a.c > +++ b/drivers/clk/meson/g12a.c > @@ -4692,6 +4692,7 @@ static struct clk_regmap *const g12a_clk_regmaps[] = { > &g12a_bt656, > &g12a_usb1_to_ddr, > &g12a_mmc_pclk, > + &g12a_uart2, > &g12a_vpu_intr, > &g12a_gic, > &g12a_sd_emmc_a_clk0, > Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Jerome Brunet <jbrunet@baylibre.com> writes: > UART2 peripheral is missing from the regmap fixup table of the g12a family > clock controller. As it is, any access to this clock would Oops, which is > not great. > > Add the clock to the table to fix the problem. > > Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller") > Reported-by: Dmitry Shmidt <dimitrysh@google.com> > Tested-by: Dmitry Shmidt <dimitrysh@google.com> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Tested-by: Kevin Hilman <khilman@baylibre.com>
On Fri 13 Dec 2019 at 17:44, Kevin Hilman <khilman@baylibre.com> wrote: > Jerome Brunet <jbrunet@baylibre.com> writes: > >> UART2 peripheral is missing from the regmap fixup table of the g12a family >> clock controller. As it is, any access to this clock would Oops, which is >> not great. >> >> Add the clock to the table to fix the problem. >> >> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller") >> Reported-by: Dmitry Shmidt <dimitrysh@google.com> >> Tested-by: Dmitry Shmidt <dimitrysh@google.com> >> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > > Tested-by: Kevin Hilman <khilman@baylibre.com> Applied for fixes
Hello: This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next). On Fri, 13 Dec 2019 11:33:04 +0100 you wrote: > UART2 peripheral is missing from the regmap fixup table of the g12a family > clock controller. As it is, any access to this clock would Oops, which is > not great. > > Add the clock to the table to fix the problem. > > Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller") > Reported-by: Dmitry Shmidt <dimitrysh@google.com> > Tested-by: Dmitry Shmidt <dimitrysh@google.com> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > > [...] Here is a summary with links: - clk: meson: g12a: fix missing uart2 in regmap table https://git.kernel.org/khilman/linux-amlogic/c/b1b3f0622a9d52ac19a63619911823c89a4d85a4 You are awesome, thank you!
diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c index 66cf791bfc8c..cd1de3e004e4 100644 --- a/drivers/clk/meson/g12a.c +++ b/drivers/clk/meson/g12a.c @@ -4692,6 +4692,7 @@ static struct clk_regmap *const g12a_clk_regmaps[] = { &g12a_bt656, &g12a_usb1_to_ddr, &g12a_mmc_pclk, + &g12a_uart2, &g12a_vpu_intr, &g12a_gic, &g12a_sd_emmc_a_clk0,
UART2 peripheral is missing from the regmap fixup table of the g12a family clock controller. As it is, any access to this clock would Oops, which is not great. Add the clock to the table to fix the problem. Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller") Reported-by: Dmitry Shmidt <dimitrysh@google.com> Tested-by: Dmitry Shmidt <dimitrysh@google.com> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- drivers/clk/meson/g12a.c | 1 + 1 file changed, 1 insertion(+)