| Message ID | 20191212113540.2.Ibad7d3b0bea02957e89047942c61cc6c0aa61715@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: sc7180: Make dtbs_check mostly happy | expand |
Quoting Douglas Anderson (2019-12-12 11:35:38) > Running `make dtbs_check` yells: > > arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: interrupt-controller@17a00000: gic-its@17a40000: False schema > > From "arm,gic-v3.yaml" we can grok that this is explained by the > comment "msi-controller is preferred". Switch to the preferred name > so that dtbs_check stops yelling. > > Fixes: 90db71e48070 ("arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc") > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- This problem is also in sdm845 and probably others. Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Hi, On Thu, Dec 12, 2019 at 1:56 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Douglas Anderson (2019-12-12 11:35:38) > > Running `make dtbs_check` yells: > > > > arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: interrupt-controller@17a00000: gic-its@17a40000: False schema > > > > From "arm,gic-v3.yaml" we can grok that this is explained by the > > comment "msi-controller is preferred". Switch to the preferred name > > so that dtbs_check stops yelling. > > > > Fixes: 90db71e48070 ("arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc") > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > This problem is also in sdm845 and probably others. Patch to fix sdm845 is at: https://lore.kernel.org/r/20191216222021.1.I684f124a05a1c3f0b113c8d06d5f9da5d69b801e@changeid That was the only instance I could find from a grep of arm64/qcom. -Doug
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 01bbb58ae516..1b2bb0b9c9e8 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1189,7 +1189,7 @@ intc: interrupt-controller@17a00000 { <0 0x17a60000 0 0x100000>; /* GICR * 8 */ interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; - gic-its@17a40000 { + msi-controller@17a40000 { compatible = "arm,gic-v3-its"; msi-controller; #msi-cells = <1>;
Running `make dtbs_check` yells: arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: interrupt-controller@17a00000: gic-its@17a40000: False schema From "arm,gic-v3.yaml" we can grok that this is explained by the comment "msi-controller is preferred". Switch to the preferred name so that dtbs_check stops yelling. Fixes: 90db71e48070 ("arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc") Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)