| Message ID | 1576641008-14880-1-git-send-email-zhangpan26@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] gpu: drm: dead code elimination | expand |
On Wed, Dec 18, 2019 at 3:14 AM Pan Zhang <zhangpan26@huawei.com> wrote: > > this set adds support for removal of gpu drm dead code. > > patch3 is similar with patch 1: > `num` is a data of u8 type and ATOM_MAX_HW_I2C_READ == 255, > > so there is a impossible condition '(num > 255) => (0-255 > 255)'. > > Signed-off-by: Pan Zhang <zhangpan26@huawei.com> Applied. thanks! Alex > --- > drivers/gpu/drm/radeon/atombios_i2c.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/atombios_i2c.c b/drivers/gpu/drm/radeon/atombios_i2c.c > index a570ce4..ab4d210 100644 > --- a/drivers/gpu/drm/radeon/atombios_i2c.c > +++ b/drivers/gpu/drm/radeon/atombios_i2c.c > @@ -68,11 +68,6 @@ static int radeon_process_i2c_ch(struct radeon_i2c_chan *chan, > memcpy(&out, &buf[1], num); > args.lpI2CDataOut = cpu_to_le16(out); > } else { > - if (num > ATOM_MAX_HW_I2C_READ) { > - DRM_ERROR("hw i2c: tried to read too many bytes (%d vs 255)\n", num); > - r = -EINVAL; > - goto done; > - } > args.ucRegIndex = 0; > args.lpI2CDataOut = 0; > } > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/radeon/atombios_i2c.c b/drivers/gpu/drm/radeon/atombios_i2c.c index a570ce4..ab4d210 100644 --- a/drivers/gpu/drm/radeon/atombios_i2c.c +++ b/drivers/gpu/drm/radeon/atombios_i2c.c @@ -68,11 +68,6 @@ static int radeon_process_i2c_ch(struct radeon_i2c_chan *chan, memcpy(&out, &buf[1], num); args.lpI2CDataOut = cpu_to_le16(out); } else { - if (num > ATOM_MAX_HW_I2C_READ) { - DRM_ERROR("hw i2c: tried to read too many bytes (%d vs 255)\n", num); - r = -EINVAL; - goto done; - } args.ucRegIndex = 0; args.lpI2CDataOut = 0; }
this set adds support for removal of gpu drm dead code. patch3 is similar with patch 1: `num` is a data of u8 type and ATOM_MAX_HW_I2C_READ == 255, so there is a impossible condition '(num > 255) => (0-255 > 255)'. Signed-off-by: Pan Zhang <zhangpan26@huawei.com> --- drivers/gpu/drm/radeon/atombios_i2c.c | 5 ----- 1 file changed, 5 deletions(-)