| Message ID | 20191218030451.40994-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cifs: Adjust indentation in smb2_open_file | expand |
merged into cifs-2.6.git for-next On Tue, Dec 17, 2019 at 9:04 PM Nathan Chancellor <natechancellor@gmail.com> wrote: > > Clang warns: > > ../fs/cifs/smb2file.c:70:3: warning: misleading indentation; statement > is not part of the previous 'if' [-Wmisleading-indentation] > if (oparms->tcon->use_resilient) { > ^ > ../fs/cifs/smb2file.c:66:2: note: previous statement is here > if (rc) > ^ > 1 warning generated. > > This warning occurs because there is a space after the tab on this line. > Remove it so that the indentation is consistent with the Linux kernel > coding style and clang no longer warns. > > Fixes: 592fafe644bf ("Add resilienthandles mount parm") > Link: https://github.com/ClangBuiltLinux/linux/issues/826 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > fs/cifs/smb2file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/smb2file.c b/fs/cifs/smb2file.c > index 8b0b512c5792..afe1f03aabe3 100644 > --- a/fs/cifs/smb2file.c > +++ b/fs/cifs/smb2file.c > @@ -67,7 +67,7 @@ smb2_open_file(const unsigned int xid, struct cifs_open_parms *oparms, > goto out; > > > - if (oparms->tcon->use_resilient) { > + if (oparms->tcon->use_resilient) { > /* default timeout is 0, servers pick default (120 seconds) */ > nr_ioctl_req.Timeout = > cpu_to_le32(oparms->tcon->handle_timeout); > -- > 2.24.1 >
diff --git a/fs/cifs/smb2file.c b/fs/cifs/smb2file.c index 8b0b512c5792..afe1f03aabe3 100644 --- a/fs/cifs/smb2file.c +++ b/fs/cifs/smb2file.c @@ -67,7 +67,7 @@ smb2_open_file(const unsigned int xid, struct cifs_open_parms *oparms, goto out; - if (oparms->tcon->use_resilient) { + if (oparms->tcon->use_resilient) { /* default timeout is 0, servers pick default (120 seconds) */ nr_ioctl_req.Timeout = cpu_to_le32(oparms->tcon->handle_timeout);
Clang warns: ../fs/cifs/smb2file.c:70:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] if (oparms->tcon->use_resilient) { ^ ../fs/cifs/smb2file.c:66:2: note: previous statement is here if (rc) ^ 1 warning generated. This warning occurs because there is a space after the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns. Fixes: 592fafe644bf ("Add resilienthandles mount parm") Link: https://github.com/ClangBuiltLinux/linux/issues/826 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- fs/cifs/smb2file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)