| Message ID | 20191211192742.95699-6-brendanhiggins@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | uml: add unspecified HAS_IOMEM dependencies | expand |
On Wed, Dec 11, 2019 at 11:27:40AM -0800, Brendan Higgins wrote: > Currently CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y implicitly depends on > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > the following build error: > > ld: drivers/crypto/amlogic/amlogic-gxl-core.o: in function `meson_crypto_probe': > drivers/crypto/amlogic/amlogic-gxl-core.c:240: undefined reference to `devm_platform_ioremap_resource' > > Fix the build error by adding the unspecified dependency. > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > --- > drivers/crypto/amlogic/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/crypto/amlogic/Kconfig b/drivers/crypto/amlogic/Kconfig > index b90850d18965f..cf95476026708 100644 > --- a/drivers/crypto/amlogic/Kconfig > +++ b/drivers/crypto/amlogic/Kconfig > @@ -1,5 +1,6 @@ > config CRYPTO_DEV_AMLOGIC_GXL > tristate "Support for amlogic cryptographic offloader" > + depends on HAS_IOMEM > default y if ARCH_MESON > select CRYPTO_SKCIPHER > select CRYPTO_ENGINE Acked-by: Corentin Labbe <clabbe@baylibre.com> Thanks
On Wed, Dec 11, 2019 at 11:27:40AM -0800, Brendan Higgins wrote: > Currently CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y implicitly depends on > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > the following build error: > > ld: drivers/crypto/amlogic/amlogic-gxl-core.o: in function `meson_crypto_probe': > drivers/crypto/amlogic/amlogic-gxl-core.c:240: undefined reference to `devm_platform_ioremap_resource' > > Fix the build error by adding the unspecified dependency. > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > --- > drivers/crypto/amlogic/Kconfig | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks.
diff --git a/drivers/crypto/amlogic/Kconfig b/drivers/crypto/amlogic/Kconfig index b90850d18965f..cf95476026708 100644 --- a/drivers/crypto/amlogic/Kconfig +++ b/drivers/crypto/amlogic/Kconfig @@ -1,5 +1,6 @@ config CRYPTO_DEV_AMLOGIC_GXL tristate "Support for amlogic cryptographic offloader" + depends on HAS_IOMEM default y if ARCH_MESON select CRYPTO_SKCIPHER select CRYPTO_ENGINE
Currently CONFIG_CRYPTO_DEV_AMLOGIC_GXL=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error: ld: drivers/crypto/amlogic/amlogic-gxl-core.o: in function `meson_crypto_probe': drivers/crypto/amlogic/amlogic-gxl-core.c:240: undefined reference to `devm_platform_ioremap_resource' Fix the build error by adding the unspecified dependency. Reported-by: Brendan Higgins <brendanhiggins@google.com> Signed-off-by: Brendan Higgins <brendanhiggins@google.com> --- drivers/crypto/amlogic/Kconfig | 1 + 1 file changed, 1 insertion(+)