| Message ID | 20191220065314.237624-5-lkundrak@v3.sk (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/5] dt-bindings: marvell,mmp2: Add clock ids for the HSIC clocks | expand |
On Fri, 2019-12-20 at 07:53 +0100, Lubomir Rintel wrote: > There are two on MMP3, along with the PHYs. The PHYs are made compatible > with the NOP transceiver, since there's no driver for the time being and > they're likely configured by the firmware. > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > --- > arch/arm/boot/dts/mmp3.dtsi | 44 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi > index d9762de0ed34b..36c50706e60e0 100644 > --- a/arch/arm/boot/dts/mmp3.dtsi > +++ b/arch/arm/boot/dts/mmp3.dtsi > @@ -201,6 +201,50 @@ usb_otg0: usb-otg@d4208000 { > status = "disabled"; > }; > > + hsic_phy0: hsic-phy@f0001800 { > + compatible = "marvell,mmp3-hsic-phy", > + "usb-nop-xceiv", I managed to mess this up right before sending it out. ^^^ Sorry for that. There should be a semicolon there. I'll fix this up on next patch spin. > + reg = <0xf0001800 0x40>; > + #phy-cells = <0>; > + status = "disabled"; > + }; > + > + hsic0: hsic@f0001000 { > + compatible = "marvell,pxau2o-ehci"; > + reg = <0xf0001000 0x200>; > + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&soc_clocks MMP2_CLK_USBHSIC0>; > + clock-names = "USBCLK"; > + phys = <&hsic_phy0>; > + phy-names = "usb"; > + phy_type = "hsic"; > + #address-cells = <0x01>; > + #size-cells = <0x00>; > + status = "disabled"; > + }; > + > + hsic_phy1: hsic-phy@f0002800 { > + compatible = "marvell,mmp3-hsic-phy", > + "usb-nop-xceiv", > + reg = <0xf0002800 0x40>; > + #phy-cells = <0>; > + status = "disabled"; > + }; > + > + hsic1: hsic@f0002000 { > + compatible = "marvell,pxau2o-ehci"; > + reg = <0xf0002000 0x200>; > + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&soc_clocks MMP2_CLK_USBHSIC1>; > + clock-names = "USBCLK"; > + phys = <&hsic_phy1>; > + phy-names = "usb"; > + phy_type = "hsic"; > + #address-cells = <0x01>; > + #size-cells = <0x00>; > + status = "disabled"; > + }; > + > mmc1: mmc@d4280000 { > compatible = "mrvl,pxav3-mmc"; > reg = <0xd4280000 0x120>;
Hi Lubomir,
I love your patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on clk/clk-next phy/next arm-soc/for-next v5.5-rc3 next-20191220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Lubomir-Rintel/dt-bindings-marvell-mmp2-Add-clock-ids-for-the-HSIC-clocks/20191223-141100
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> Error: arch/arm/boot/dts/mmp3.dtsi:207.5-6 syntax error
FATAL ERROR: Unable to parse input tree
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
On Fri, Dec 20, 2019 at 08:05:50AM +0100, Lubomir Rintel wrote: > On Fri, 2019-12-20 at 07:53 +0100, Lubomir Rintel wrote: > > There are two on MMP3, along with the PHYs. The PHYs are made compatible > > with the NOP transceiver, since there's no driver for the time being and > > they're likely configured by the firmware. > > > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > > --- > > arch/arm/boot/dts/mmp3.dtsi | 44 +++++++++++++++++++++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > > > diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi > > index d9762de0ed34b..36c50706e60e0 100644 > > --- a/arch/arm/boot/dts/mmp3.dtsi > > +++ b/arch/arm/boot/dts/mmp3.dtsi > > @@ -201,6 +201,50 @@ usb_otg0: usb-otg@d4208000 { > > status = "disabled"; > > }; > > > > + hsic_phy0: hsic-phy@f0001800 { > > + compatible = "marvell,mmp3-hsic-phy", > > + "usb-nop-xceiv", > > I managed to mess this up right before sending it out. ^^^ > Sorry for that. There should be a semicolon there. I'll fix this up on > next patch spin. Missed the comments when applying, but I fixed it up locally with the below patch. Please send new versions incremental on top of it. I applied the series to the mmp/hsic (and mmp/hsic-fixed) branch in our tree if you want to use that as a base. -Olof --- From e2ce979bf176af4b8eb7aea866919d618c08f752 Mon Sep 17 00:00:00 2001 From: Olof Johansson <olof@lixom.net> Date: Mon, 6 Jan 2020 11:14:10 -0800 Subject: [PATCH] ARM: dts: mmp3: Fix typos Fixes build failures due to syntax errors. Fixes: 3240d5b872f2 ("ARM: dts: mmp3: Add HSIC controllers") Signed-off-by: Olof Johansson <olof@lixom.net> --- arch/arm/boot/dts/mmp3.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi index 36c50706e60e..1eba7fb6629b 100644 --- a/arch/arm/boot/dts/mmp3.dtsi +++ b/arch/arm/boot/dts/mmp3.dtsi @@ -203,7 +203,7 @@ hsic_phy0: hsic-phy@f0001800 { compatible = "marvell,mmp3-hsic-phy", - "usb-nop-xceiv", + "usb-nop-xceiv"; reg = <0xf0001800 0x40>; #phy-cells = <0>; status = "disabled"; @@ -225,7 +225,7 @@ hsic_phy1: hsic-phy@f0002800 { compatible = "marvell,mmp3-hsic-phy", - "usb-nop-xceiv", + "usb-nop-xceiv"; reg = <0xf0002800 0x40>; #phy-cells = <0>; status = "disabled";
diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi index d9762de0ed34b..36c50706e60e0 100644 --- a/arch/arm/boot/dts/mmp3.dtsi +++ b/arch/arm/boot/dts/mmp3.dtsi @@ -201,6 +201,50 @@ usb_otg0: usb-otg@d4208000 { status = "disabled"; }; + hsic_phy0: hsic-phy@f0001800 { + compatible = "marvell,mmp3-hsic-phy", + "usb-nop-xceiv", + reg = <0xf0001800 0x40>; + #phy-cells = <0>; + status = "disabled"; + }; + + hsic0: hsic@f0001000 { + compatible = "marvell,pxau2o-ehci"; + reg = <0xf0001000 0x200>; + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&soc_clocks MMP2_CLK_USBHSIC0>; + clock-names = "USBCLK"; + phys = <&hsic_phy0>; + phy-names = "usb"; + phy_type = "hsic"; + #address-cells = <0x01>; + #size-cells = <0x00>; + status = "disabled"; + }; + + hsic_phy1: hsic-phy@f0002800 { + compatible = "marvell,mmp3-hsic-phy", + "usb-nop-xceiv", + reg = <0xf0002800 0x40>; + #phy-cells = <0>; + status = "disabled"; + }; + + hsic1: hsic@f0002000 { + compatible = "marvell,pxau2o-ehci"; + reg = <0xf0002000 0x200>; + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&soc_clocks MMP2_CLK_USBHSIC1>; + clock-names = "USBCLK"; + phys = <&hsic_phy1>; + phy-names = "usb"; + phy_type = "hsic"; + #address-cells = <0x01>; + #size-cells = <0x00>; + status = "disabled"; + }; + mmc1: mmc@d4280000 { compatible = "mrvl,pxav3-mmc"; reg = <0xd4280000 0x120>;
There are two on MMP3, along with the PHYs. The PHYs are made compatible with the NOP transceiver, since there's no driver for the time being and they're likely configured by the firmware. Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> --- arch/arm/boot/dts/mmp3.dtsi | 44 +++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)