| Message ID | 20191217113024.2109457-1-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 3932aa1ce38148cd54b6ec2fd1ce070e2160b628 |
| Headers | show |
| Series | crypto: sun4i-ss: make unexported sun4i_ss_pm_ops static | expand |
On Tue, Dec 17, 2019 at 11:30:24AM +0000, Ben Dooks (Codethink) wrote: > The sun4i_ss_pm_ops is not referenced outside the driver > except via a pointer, so make it static to avoid the following > warning: > > drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c:276:25: warning: symbol 'sun4i_ss_pm_ops' was not declared. Should it be static? > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> > --- > Cc: Corentin Labbe <clabbe.montjoie@gmail.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Allison Randal <allison@lohutok.net> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: YueHaibing <yuehaibing@huawei.com> > Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> > Cc: linux-crypto@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c index 814cd12149a9..52c8b7f680a7 100644 --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c @@ -273,7 +273,7 @@ static int sun4i_ss_pm_resume(struct device *dev) return err; } -const struct dev_pm_ops sun4i_ss_pm_ops = { +static const struct dev_pm_ops sun4i_ss_pm_ops = { SET_RUNTIME_PM_OPS(sun4i_ss_pm_suspend, sun4i_ss_pm_resume, NULL) };
The sun4i_ss_pm_ops is not referenced outside the driver except via a pointer, so make it static to avoid the following warning: drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c:276:25: warning: symbol 'sun4i_ss_pm_ops' was not declared. Should it be static? Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> --- Cc: Corentin Labbe <clabbe.montjoie@gmail.com> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: Maxime Ripard <mripard@kernel.org> Cc: Chen-Yu Tsai <wens@csie.org> Cc: Allison Randal <allison@lohutok.net> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: YueHaibing <yuehaibing@huawei.com> Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> Cc: linux-crypto@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- drivers/crypto/allwinner/sun4i-ss/sun4i-ss-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)