diff mbox series

[2/2] phy: Enable compile testing for some of drivers

Message ID 20191230172449.17648-2-krzk@kernel.org (mailing list archive)
State New, archived
Headers show
Series [1/2] phy: mediatek: Fix Kconfig indentation | expand

Commit Message

Krzysztof Kozlowski Dec. 30, 2019, 5:24 p.m. UTC 
Some of the phy drivers can be compile tested to increase build
coverage.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/phy/allwinner/Kconfig | 3 ++-
 drivers/phy/marvell/Kconfig   | 8 +++++---
 drivers/phy/mediatek/Kconfig  | 9 ++++++---
 drivers/phy/samsung/Kconfig   | 8 ++++----
 drivers/phy/ti/Kconfig        | 4 ++--
 5 files changed, 19 insertions(+), 13 deletions(-)

Comments

Florian Fainelli Dec. 30, 2019, 8:10 p.m. UTC | #1 
Hi Krzysztof,

On 12/30/19 9:24 AM, Krzysztof Kozlowski wrote:
> Some of the phy drivers can be compile tested to increase build
> coverage.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

This looks fine, you could also consider adding a bunch of other
Broadcom PHY drivers which are not currently under COMPILE_TEST, yet
build fine:

diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
index d3d983c128ea..d56db6d375e1 100644
--- a/drivers/phy/broadcom/Kconfig
+++ b/drivers/phy/broadcom/Kconfig
@@ -50,7 +50,7 @@ config PHY_BCM_NS_USB3

 config PHY_NS2_PCIE
        tristate "Broadcom Northstar2 PCIe PHY driver"
-       depends on OF && MDIO_BUS_MUX_BCM_IPROC
+       depends on (OF && MDIO_BUS_MUX_BCM_IPROC) || COMPILE_TEST
        select GENERIC_PHY
        default ARCH_BCM_IPROC
        help
@@ -83,7 +83,7 @@ config PHY_BRCM_SATA

 config PHY_BRCM_USB
        tristate "Broadcom STB USB PHY driver"
-       depends on ARCH_BRCMSTB
+       depends on ARCH_BRCMSTB || COMPILE_TEST
        depends on OF
        select GENERIC_PHY
        select SOC_BRCMSTB

> ---
>  drivers/phy/allwinner/Kconfig | 3 ++-
>  drivers/phy/marvell/Kconfig   | 8 +++++---
>  drivers/phy/mediatek/Kconfig  | 9 ++++++---
>  drivers/phy/samsung/Kconfig   | 8 ++++----
>  drivers/phy/ti/Kconfig        | 4 ++--
>  5 files changed, 19 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/phy/allwinner/Kconfig b/drivers/phy/allwinner/Kconfig
> index 3dab79e9d52b..e760d89d3976 100644
> --- a/drivers/phy/allwinner/Kconfig
> +++ b/drivers/phy/allwinner/Kconfig
> @@ -48,7 +48,8 @@ config PHY_SUN9I_USB
>  
>  config PHY_SUN50I_USB3
>  	tristate "Allwinner H6 SoC USB3 PHY driver"
> -	depends on ARCH_SUNXI && HAS_IOMEM && OF
> +	depends on ARCH_SUNXI || COMPILE_TEST
> +	depends on HAS_IOMEM && OF
>  	depends on RESET_CONTROLLER
>  	select GENERIC_PHY
>  	help
> diff --git a/drivers/phy/marvell/Kconfig b/drivers/phy/marvell/Kconfig
> index 005e02dd4a91..8f6273c837ec 100644
> --- a/drivers/phy/marvell/Kconfig
> +++ b/drivers/phy/marvell/Kconfig
> @@ -10,14 +10,16 @@ config ARMADA375_USBCLUSTER_PHY
>  
>  config PHY_BERLIN_SATA
>  	tristate "Marvell Berlin SATA PHY driver"
> -	depends on ARCH_BERLIN && HAS_IOMEM && OF
> +	depends on ARCH_BERLIN || COMPILE_TEST
> +	depends on OF && HAS_IOMEM
>  	select GENERIC_PHY
>  	help
>  	  Enable this to support the SATA PHY on Marvell Berlin SoCs.
>  
>  config PHY_BERLIN_USB
>  	tristate "Marvell Berlin USB PHY Driver"
> -	depends on ARCH_BERLIN && RESET_CONTROLLER && HAS_IOMEM && OF
> +	depends on ARCH_BERLIN || COMPILE_TEST
> +	depends on OF && HAS_IOMEM && RESET_CONTROLLER
>  	select GENERIC_PHY
>  	help
>  	  Enable this to support the USB PHY on Marvell Berlin SoCs.
> @@ -95,7 +97,7 @@ config PHY_PXA_28NM_USB2
>  
>  config PHY_PXA_USB
>  	tristate "Marvell PXA USB PHY Driver"
> -	depends on ARCH_PXA || ARCH_MMP
> +	depends on ARCH_PXA || ARCH_MMP || COMPILE_TEST
>  	select GENERIC_PHY
>  	help
>  	  Enable this to support Marvell PXA USB PHY driver for Marvell
> diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> index 7d19134c6b7c..dee757c957f2 100644
> --- a/drivers/phy/mediatek/Kconfig
> +++ b/drivers/phy/mediatek/Kconfig
> @@ -4,7 +4,8 @@
>  #
>  config PHY_MTK_TPHY
>  	tristate "MediaTek T-PHY Driver"
> -	depends on ARCH_MEDIATEK && OF
> +	depends on ARCH_MEDIATEK || COMPILE_TEST
> +	depends on OF
>  	select GENERIC_PHY
>  	help
>  	  Say 'Y' here to add support for MediaTek T-PHY driver,
> @@ -16,7 +17,8 @@ config PHY_MTK_TPHY
>  
>  config PHY_MTK_UFS
>  	tristate "MediaTek UFS M-PHY driver"
> -	depends on ARCH_MEDIATEK && OF
> +	depends on ARCH_MEDIATEK || COMPILE_TEST
> +	depends on OF
>  	select GENERIC_PHY
>  	help
>  	  Support for UFS M-PHY on MediaTek chipsets.
> @@ -26,7 +28,8 @@ config PHY_MTK_UFS
>  
>  config PHY_MTK_XSPHY
>  	tristate "MediaTek XS-PHY Driver"
> -	depends on ARCH_MEDIATEK && OF
> +	depends on ARCH_MEDIATEK || COMPILE_TEST
> +	depends on OF
>  	select GENERIC_PHY
>  	help
>  	  Enable this to support the SuperSpeedPlus XS-PHY transceiver for
> diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig
> index 290a6c70f570..349fcb23e5f3 100644
> --- a/drivers/phy/samsung/Kconfig
> +++ b/drivers/phy/samsung/Kconfig
> @@ -32,7 +32,7 @@ config PHY_EXYNOS_PCIE
>  config PHY_SAMSUNG_USB2
>  	tristate "Samsung USB 2.0 PHY driver"
>  	depends on HAS_IOMEM
> -	depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2
> +	depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2 || COMPILE_TEST
>  	select GENERIC_PHY
>  	select MFD_SYSCON
>  	default ARCH_EXYNOS
> @@ -60,7 +60,7 @@ config PHY_EXYNOS5250_USB2
>  config PHY_S5PV210_USB2
>  	bool "Support for S5PV210"
>  	depends on PHY_SAMSUNG_USB2
> -	depends on ARCH_S5PV210
> +	depends on ARCH_S5PV210 || COMPILE_TEST
>  	help
>  	  Enable USB PHY support for S5PV210. This option requires that Samsung
>  	  USB 2.0 PHY driver is enabled and means that support for this
> @@ -69,7 +69,7 @@ config PHY_S5PV210_USB2
>  
>  config PHY_EXYNOS5_USBDRD
>  	tristate "Exynos5 SoC series USB DRD PHY driver"
> -	depends on ARCH_EXYNOS && OF
> +	depends on (ARCH_EXYNOS && OF) || COMPILE_TEST
>  	depends on HAS_IOMEM
>  	depends on USB_DWC3_EXYNOS
>  	select GENERIC_PHY
> @@ -82,7 +82,7 @@ config PHY_EXYNOS5_USBDRD
>  
>  config PHY_EXYNOS5250_SATA
>  	tristate "Exynos5250 Sata SerDes/PHY driver"
> -	depends on SOC_EXYNOS5250
> +	depends on SOC_EXYNOS5250 || COMPILE_TEST
>  	depends on HAS_IOMEM
>  	depends on OF
>  	select GENERIC_PHY
> diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig
> index 174888609779..e231c0e369c5 100644
> --- a/drivers/phy/ti/Kconfig
> +++ b/drivers/phy/ti/Kconfig
> @@ -4,7 +4,7 @@
>  #
>  config PHY_DA8XX_USB
>  	tristate "TI DA8xx USB PHY Driver"
> -	depends on ARCH_DAVINCI_DA8XX
> +	depends on ARCH_DAVINCI_DA8XX || COMPILE_TEST
>  	select GENERIC_PHY
>  	select MFD_SYSCON
>  	help
> @@ -14,7 +14,7 @@ config PHY_DA8XX_USB
>  
>  config PHY_DM816X_USB
>  	tristate "TI dm816x USB PHY driver"
> -	depends on ARCH_OMAP2PLUS
> +	depends on ARCH_OMAP2PLUS || COMPILE_TEST
>  	depends on USB_SUPPORT
>  	select GENERIC_PHY
>  	select USB_PHY
>
Krzysztof Kozlowski Dec. 31, 2019, 8:20 a.m. UTC | #2 
On Mon, Dec 30, 2019 at 12:10:51PM -0800, Florian Fainelli wrote:
> Hi Krzysztof,
> 
> On 12/30/19 9:24 AM, Krzysztof Kozlowski wrote:
> > Some of the phy drivers can be compile tested to increase build
> > coverage.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> This looks fine, you could also consider adding a bunch of other
> Broadcom PHY drivers which are not currently under COMPILE_TEST, yet
> build fine:

I'll send a v2 with them as well. They seem to compile fine.

Best regards,
Krzysztof

> 
> diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
> index d3d983c128ea..d56db6d375e1 100644
> --- a/drivers/phy/broadcom/Kconfig
> +++ b/drivers/phy/broadcom/Kconfig
> @@ -50,7 +50,7 @@ config PHY_BCM_NS_USB3
> 
>  config PHY_NS2_PCIE
>         tristate "Broadcom Northstar2 PCIe PHY driver"
> -       depends on OF && MDIO_BUS_MUX_BCM_IPROC
> +       depends on (OF && MDIO_BUS_MUX_BCM_IPROC) || COMPILE_TEST
>         select GENERIC_PHY
>         default ARCH_BCM_IPROC
>         help
> @@ -83,7 +83,7 @@ config PHY_BRCM_SATA
> 
>  config PHY_BRCM_USB
>         tristate "Broadcom STB USB PHY driver"
> -       depends on ARCH_BRCMSTB
> +       depends on ARCH_BRCMSTB || COMPILE_TEST
>         depends on OF
>         select GENERIC_PHY
>         select SOC_BRCMSTB
>
diff mbox series

Patch

diff --git a/drivers/phy/allwinner/Kconfig b/drivers/phy/allwinner/Kconfig
index 3dab79e9d52b..e760d89d3976 100644
--- a/drivers/phy/allwinner/Kconfig
+++ b/drivers/phy/allwinner/Kconfig
@@ -48,7 +48,8 @@  config PHY_SUN9I_USB
 
 config PHY_SUN50I_USB3
 	tristate "Allwinner H6 SoC USB3 PHY driver"
-	depends on ARCH_SUNXI && HAS_IOMEM && OF
+	depends on ARCH_SUNXI || COMPILE_TEST
+	depends on HAS_IOMEM && OF
 	depends on RESET_CONTROLLER
 	select GENERIC_PHY
 	help
diff --git a/drivers/phy/marvell/Kconfig b/drivers/phy/marvell/Kconfig
index 005e02dd4a91..8f6273c837ec 100644
--- a/drivers/phy/marvell/Kconfig
+++ b/drivers/phy/marvell/Kconfig
@@ -10,14 +10,16 @@  config ARMADA375_USBCLUSTER_PHY
 
 config PHY_BERLIN_SATA
 	tristate "Marvell Berlin SATA PHY driver"
-	depends on ARCH_BERLIN && HAS_IOMEM && OF
+	depends on ARCH_BERLIN || COMPILE_TEST
+	depends on OF && HAS_IOMEM
 	select GENERIC_PHY
 	help
 	  Enable this to support the SATA PHY on Marvell Berlin SoCs.
 
 config PHY_BERLIN_USB
 	tristate "Marvell Berlin USB PHY Driver"
-	depends on ARCH_BERLIN && RESET_CONTROLLER && HAS_IOMEM && OF
+	depends on ARCH_BERLIN || COMPILE_TEST
+	depends on OF && HAS_IOMEM && RESET_CONTROLLER
 	select GENERIC_PHY
 	help
 	  Enable this to support the USB PHY on Marvell Berlin SoCs.
@@ -95,7 +97,7 @@  config PHY_PXA_28NM_USB2
 
 config PHY_PXA_USB
 	tristate "Marvell PXA USB PHY Driver"
-	depends on ARCH_PXA || ARCH_MMP
+	depends on ARCH_PXA || ARCH_MMP || COMPILE_TEST
 	select GENERIC_PHY
 	help
 	  Enable this to support Marvell PXA USB PHY driver for Marvell
diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
index 7d19134c6b7c..dee757c957f2 100644
--- a/drivers/phy/mediatek/Kconfig
+++ b/drivers/phy/mediatek/Kconfig
@@ -4,7 +4,8 @@ 
 #
 config PHY_MTK_TPHY
 	tristate "MediaTek T-PHY Driver"
-	depends on ARCH_MEDIATEK && OF
+	depends on ARCH_MEDIATEK || COMPILE_TEST
+	depends on OF
 	select GENERIC_PHY
 	help
 	  Say 'Y' here to add support for MediaTek T-PHY driver,
@@ -16,7 +17,8 @@  config PHY_MTK_TPHY
 
 config PHY_MTK_UFS
 	tristate "MediaTek UFS M-PHY driver"
-	depends on ARCH_MEDIATEK && OF
+	depends on ARCH_MEDIATEK || COMPILE_TEST
+	depends on OF
 	select GENERIC_PHY
 	help
 	  Support for UFS M-PHY on MediaTek chipsets.
@@ -26,7 +28,8 @@  config PHY_MTK_UFS
 
 config PHY_MTK_XSPHY
 	tristate "MediaTek XS-PHY Driver"
-	depends on ARCH_MEDIATEK && OF
+	depends on ARCH_MEDIATEK || COMPILE_TEST
+	depends on OF
 	select GENERIC_PHY
 	help
 	  Enable this to support the SuperSpeedPlus XS-PHY transceiver for
diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig
index 290a6c70f570..349fcb23e5f3 100644
--- a/drivers/phy/samsung/Kconfig
+++ b/drivers/phy/samsung/Kconfig
@@ -32,7 +32,7 @@  config PHY_EXYNOS_PCIE
 config PHY_SAMSUNG_USB2
 	tristate "Samsung USB 2.0 PHY driver"
 	depends on HAS_IOMEM
-	depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2
+	depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2 || COMPILE_TEST
 	select GENERIC_PHY
 	select MFD_SYSCON
 	default ARCH_EXYNOS
@@ -60,7 +60,7 @@  config PHY_EXYNOS5250_USB2
 config PHY_S5PV210_USB2
 	bool "Support for S5PV210"
 	depends on PHY_SAMSUNG_USB2
-	depends on ARCH_S5PV210
+	depends on ARCH_S5PV210 || COMPILE_TEST
 	help
 	  Enable USB PHY support for S5PV210. This option requires that Samsung
 	  USB 2.0 PHY driver is enabled and means that support for this
@@ -69,7 +69,7 @@  config PHY_S5PV210_USB2
 
 config PHY_EXYNOS5_USBDRD
 	tristate "Exynos5 SoC series USB DRD PHY driver"
-	depends on ARCH_EXYNOS && OF
+	depends on (ARCH_EXYNOS && OF) || COMPILE_TEST
 	depends on HAS_IOMEM
 	depends on USB_DWC3_EXYNOS
 	select GENERIC_PHY
@@ -82,7 +82,7 @@  config PHY_EXYNOS5_USBDRD
 
 config PHY_EXYNOS5250_SATA
 	tristate "Exynos5250 Sata SerDes/PHY driver"
-	depends on SOC_EXYNOS5250
+	depends on SOC_EXYNOS5250 || COMPILE_TEST
 	depends on HAS_IOMEM
 	depends on OF
 	select GENERIC_PHY
diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig
index 174888609779..e231c0e369c5 100644
--- a/drivers/phy/ti/Kconfig
+++ b/drivers/phy/ti/Kconfig
@@ -4,7 +4,7 @@ 
 #
 config PHY_DA8XX_USB
 	tristate "TI DA8xx USB PHY Driver"
-	depends on ARCH_DAVINCI_DA8XX
+	depends on ARCH_DAVINCI_DA8XX || COMPILE_TEST
 	select GENERIC_PHY
 	select MFD_SYSCON
 	help
@@ -14,7 +14,7 @@  config PHY_DA8XX_USB
 
 config PHY_DM816X_USB
 	tristate "TI dm816x USB PHY driver"
-	depends on ARCH_OMAP2PLUS
+	depends on ARCH_OMAP2PLUS || COMPILE_TEST
 	depends on USB_SUPPORT
 	select GENERIC_PHY
 	select USB_PHY