| Message ID | 20191218111742.29731-11-sudeep.holla@arm.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
| Series | None | expand |
On Wed, Dec 18, 2019 at 11:17:41AM +0000, Sudeep Holla wrote: > The scmi bus now has support to match the driver with devices not only > based on their protocol id but also based on their device name if one is > available. This was added to cater the need to support multiple devices > and drivers for the same protocol. > > Let us add the name "hwmon" to scmi_device_id table in the driver so > that in matches only with device with the same name and protocol id > SCMI_PROTOCOL_SENSOR. This is just for sake of completion and must > not be used to add IIO support in parallel. Instead, if IIO support is > added ever in future, we need to drop this hwmon driver entirely and > use the iio->hwmon bridge to access the sensors as hwmon devices if > needed. > Acked-by: Guenter Roeck <linux@roeck-us.net> [ assuming the series will be pushed into the kernel together ] > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: linux-hwmon@vger.kernel.org > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/hwmon/scmi-hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c > index 8a7732c0bef3..286d3cfda7de 100644 > --- a/drivers/hwmon/scmi-hwmon.c > +++ b/drivers/hwmon/scmi-hwmon.c > @@ -259,7 +259,7 @@ static int scmi_hwmon_probe(struct scmi_device *sdev) > } > > static const struct scmi_device_id scmi_id_table[] = { > - { SCMI_PROTOCOL_SENSOR }, > + { SCMI_PROTOCOL_SENSOR, "hwmon" }, > { }, > }; > MODULE_DEVICE_TABLE(scmi, scmi_id_table);
On Sat, Jan 04, 2020 at 08:19:46AM -0800, Guenter Roeck wrote: > On Wed, Dec 18, 2019 at 11:17:41AM +0000, Sudeep Holla wrote: > > The scmi bus now has support to match the driver with devices not only > > based on their protocol id but also based on their device name if one is > > available. This was added to cater the need to support multiple devices > > and drivers for the same protocol. > > > > Let us add the name "hwmon" to scmi_device_id table in the driver so > > that in matches only with device with the same name and protocol id > > SCMI_PROTOCOL_SENSOR. This is just for sake of completion and must > > not be used to add IIO support in parallel. Instead, if IIO support is > > added ever in future, we need to drop this hwmon driver entirely and > > use the iio->hwmon bridge to access the sensors as hwmon devices if > > needed. > > > > Acked-by: Guenter Roeck <linux@roeck-us.net> > Thanks > [ assuming the series will be pushed into the kernel together ] > Indeed. -- Regards, Sudeep
diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c index 8a7732c0bef3..286d3cfda7de 100644 --- a/drivers/hwmon/scmi-hwmon.c +++ b/drivers/hwmon/scmi-hwmon.c @@ -259,7 +259,7 @@ static int scmi_hwmon_probe(struct scmi_device *sdev) } static const struct scmi_device_id scmi_id_table[] = { - { SCMI_PROTOCOL_SENSOR }, + { SCMI_PROTOCOL_SENSOR, "hwmon" }, { }, }; MODULE_DEVICE_TABLE(scmi, scmi_id_table);
The scmi bus now has support to match the driver with devices not only based on their protocol id but also based on their device name if one is available. This was added to cater the need to support multiple devices and drivers for the same protocol. Let us add the name "hwmon" to scmi_device_id table in the driver so that in matches only with device with the same name and protocol id SCMI_PROTOCOL_SENSOR. This is just for sake of completion and must not be used to add IIO support in parallel. Instead, if IIO support is added ever in future, we need to drop this hwmon driver entirely and use the iio->hwmon bridge to access the sensors as hwmon devices if needed. Cc: Guenter Roeck <linux@roeck-us.net> Cc: linux-hwmon@vger.kernel.org Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/hwmon/scmi-hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)