| Message ID | 20200107135014.36472-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] drm/i915: Add missing include file <linux/math64.h> | expand |
Quoting YueHaibing (2020-01-07 13:50:14) > Fix build error: > ./drivers/gpu/drm/i915/selftests/i915_random.h: In function i915_prandom_u32_max_state: > ./drivers/gpu/drm/i915/selftests/i915_random.h:48:23: error: > implicit declaration of function mul_u32_u32; did you mean mul_u64_u32_div? [-Werror=implicit-function-declaration] > return upper_32_bits(mul_u32_u32(prandom_u32_state(state), ep_ro)); > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 7ce5b6850b47 ("drm/i915/selftests: Use mul_u32_u32() for 32b x 32b -> 64b result") While technically true, that doesn't explain why it only just started appearing on -next. -Chris
Quoting YueHaibing (2020-01-07 13:50:14) > Fix build error: > ./drivers/gpu/drm/i915/selftests/i915_random.h: In function i915_prandom_u32_max_state: > ./drivers/gpu/drm/i915/selftests/i915_random.h:48:23: error: > implicit declaration of function mul_u32_u32; did you mean mul_u64_u32_div? [-Werror=implicit-function-declaration] > return upper_32_bits(mul_u32_u32(prandom_u32_state(state), ep_ro)); > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 7ce5b6850b47 ("drm/i915/selftests: Use mul_u32_u32() for 32b x 32b -> 64b result") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
diff --git a/drivers/gpu/drm/i915/selftests/i915_random.h b/drivers/gpu/drm/i915/selftests/i915_random.h index 35cc69a..f650cfb 100644 --- a/drivers/gpu/drm/i915/selftests/i915_random.h +++ b/drivers/gpu/drm/i915/selftests/i915_random.h @@ -26,6 +26,7 @@ #define __I915_SELFTESTS_RANDOM_H__ #include <linux/random.h> +#include <linux/math64.h> #include "../i915_selftest.h"
Fix build error: ./drivers/gpu/drm/i915/selftests/i915_random.h: In function i915_prandom_u32_max_state: ./drivers/gpu/drm/i915/selftests/i915_random.h:48:23: error: implicit declaration of function mul_u32_u32; did you mean mul_u64_u32_div? [-Werror=implicit-function-declaration] return upper_32_bits(mul_u32_u32(prandom_u32_state(state), ep_ro)); Reported-by: Hulk Robot <hulkci@huawei.com> Fixes: 7ce5b6850b47 ("drm/i915/selftests: Use mul_u32_u32() for 32b x 32b -> 64b result") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/gpu/drm/i915/selftests/i915_random.h | 1 + 1 file changed, 1 insertion(+)