mbox series

[GIT,PULL] cpuidle/psci updates for v5.6

Message ID 20200102160820.3572-1-ulf.hansson@linaro.org (mailing list archive)
State Accepted
Commit 40a9012a3b24334796403491b317a83935719809
Headers show
Series [GIT,PULL] cpuidle/psci updates for v5.6 | expand

Pull-request

git://git.linaro.org/people/ulf.hansson/linux-pm.git tags/cpuidle_psci-v5.5-rc4

Message

Ulf Hansson Jan. 2, 2020, 4:08 p.m. UTC
Hi SoC maintainers,

Here's a PR with updates for v5.6 for cpuidle/psci for ARM/ARM64.

The changes are somewhat sprinkled over a couple of different directories and
there is also dts update for MSM8916. The main changes are in drivers/cpuidle/,
which have been acked-by Rafael [1] and Sudeep.

If you have any further questions, please just tell.

Please pull this in!

Kind regards
Ulf Hansson

[1]
https://lore.kernel.org/linux-arm-msm/CAJZ5v0gSY_Zg+sbBEfTaeBCiOf_L6JP4_-4tdpeFU0iCGJu3Nw@mail.gmail.com/


The following changes since commit fd6988496e79a6a4bdb514a4655d2920209eb85d:

  Linux 5.5-rc4 (2019-12-29 15:29:16 -0800)

are available in the Git repository at:

  git://git.linaro.org/people/ulf.hansson/linux-pm.git tags/cpuidle_psci-v5.5-rc4

for you to fetch changes up to e37131556801dd76880914f0930fe0cbd1fd3223:

  arm64: dts: Convert to the hierarchical CPU topology layout for MSM8916 (2020-01-02 16:53:10 +0100)

----------------------------------------------------------------
Initial support for hierarchical CPU arrangement, managed by PSCI and its
corresponding cpuidle driver. This support is based upon using the generic
PM domain, which already supports devices belonging to CPUs.

Finally, these is a DTS patch that enables the hierarchical topology to be
used for the Qcom 410c Dragonboard, which supports the PSCI OS-initiated
mode.

----------------------------------------------------------------
Lina Iyer (1):
      cpuidle: dt: Support hierarchical CPU idle states

Sudeep Holla (1):
      cpuidle: psci: Align psci_power_state count with idle state count

Ulf Hansson (13):
      dt: psci: Update DT bindings to support hierarchical PSCI states
      firmware: psci: Export functions to manage the OSI mode
      of: base: Add of_get_cpu_state_node() to get idle states for a CPU node
      cpuidle: psci: Simplify OF parsing of CPU idle state nodes
      cpuidle: psci: Support hierarchical CPU idle states
      cpuidle: psci: Add a helper to attach a CPU to its PM domain
      cpuidle: psci: Attach CPU devices to their PM domains
      cpuidle: psci: Prepare to use OS initiated suspend mode via PM domains
      cpuidle: psci: Manage runtime PM in the idle path
      cpuidle: psci: Support CPU hotplug for the hierarchical model
      PM / Domains: Introduce a genpd OF helper that removes a subdomain
      cpuidle: psci: Add support for PM domains by using genpd
      arm64: dts: Convert to the hierarchical CPU topology layout for MSM8916

 Documentation/devicetree/bindings/arm/cpus.yaml |  15 ++
 Documentation/devicetree/bindings/arm/psci.yaml | 104 ++++++++
 arch/arm64/boot/dts/qcom/msm8916.dtsi           |  57 ++++-
 drivers/base/power/domain.c                     |  38 +++
 drivers/cpuidle/Makefile                        |   4 +-
 drivers/cpuidle/cpuidle-psci-domain.c           | 308 ++++++++++++++++++++++++
 drivers/cpuidle/cpuidle-psci.c                  | 161 +++++++++++--
 drivers/cpuidle/cpuidle-psci.h                  |  17 ++
 drivers/cpuidle/dt_idle_states.c                |   5 +-
 drivers/firmware/psci/psci.c                    |  18 +-
 drivers/of/base.c                               |  36 +++
 include/linux/cpuhotplug.h                      |   1 +
 include/linux/of.h                              |   8 +
 include/linux/pm_domain.h                       |   8 +
 include/linux/psci.h                            |   2 +
 15 files changed, 747 insertions(+), 35 deletions(-)
 create mode 100644 drivers/cpuidle/cpuidle-psci-domain.c
 create mode 100644 drivers/cpuidle/cpuidle-psci.h

Comments

Olof Johansson Jan. 6, 2020, 5:26 p.m. UTC | #1
Hi,

On Thu, Jan 02, 2020 at 05:08:20PM +0100, Ulf Hansson wrote:
> Hi SoC maintainers,
> 
> Here's a PR with updates for v5.6 for cpuidle/psci for ARM/ARM64.
> 
> The changes are somewhat sprinkled over a couple of different directories and
> there is also dts update for MSM8916. The main changes are in drivers/cpuidle/,
> which have been acked-by Rafael [1] and Sudeep.
> 
> If you have any further questions, please just tell.

What was the reason to bring in a dts change in this branch? Bindings should be
stable such that old DT contents still works even if drivers are updated to
support newer attributes, etc.



-Olof
Ulf Hansson Jan. 7, 2020, 7:28 p.m. UTC | #2
On Mon, 6 Jan 2020 at 18:31, Olof Johansson <olof@lixom.net> wrote:
>
> Hi,
>
> On Thu, Jan 02, 2020 at 05:08:20PM +0100, Ulf Hansson wrote:
> > Hi SoC maintainers,
> >
> > Here's a PR with updates for v5.6 for cpuidle/psci for ARM/ARM64.
> >
> > The changes are somewhat sprinkled over a couple of different directories and
> > there is also dts update for MSM8916. The main changes are in drivers/cpuidle/,
> > which have been acked-by Rafael [1] and Sudeep.
> >
> > If you have any further questions, please just tell.
>
> What was the reason to bring in a dts change in this branch?

Convenience. But I am not usually sending these PR, so feel free to
tell me to change.

> Bindings should be
> stable such that old DT contents still works even if drivers are updated to
> support newer attributes, etc.

They already are. No worries!

If you want to pick everything else but the DTS patch, that's fine by me.

Do you want me to send a new PR?

Kind regards
Uffe
Bjorn Andersson Jan. 7, 2020, 7:38 p.m. UTC | #3
On Tue 07 Jan 11:28 PST 2020, Ulf Hansson wrote:

> On Mon, 6 Jan 2020 at 18:31, Olof Johansson <olof@lixom.net> wrote:
> >
> > Hi,
> >
> > On Thu, Jan 02, 2020 at 05:08:20PM +0100, Ulf Hansson wrote:
> > > Hi SoC maintainers,
> > >
> > > Here's a PR with updates for v5.6 for cpuidle/psci for ARM/ARM64.
> > >
> > > The changes are somewhat sprinkled over a couple of different directories and
> > > there is also dts update for MSM8916. The main changes are in drivers/cpuidle/,
> > > which have been acked-by Rafael [1] and Sudeep.
> > >
> > > If you have any further questions, please just tell.
> >
> > What was the reason to bring in a dts change in this branch?
> 
> Convenience. But I am not usually sending these PR, so feel free to
> tell me to change.
> 

The dts files are typically moving a lot, so to reduce the risk of
conflicts it's generally better if we take them through the qcom tree.

> > Bindings should be
> > stable such that old DT contents still works even if drivers are updated to
> > support newer attributes, etc.
> 
> They already are. No worries!
> 
> If you want to pick everything else but the DTS patch, that's fine by me.
> 

Generally, yes.

> Do you want me to send a new PR?
> 

But I'm happy with the dts patch and afaict there's nothing that this
will conflict with. So you have my retroactive ack on the patch and
lets stick with the current PR.

Regards,
Bjorn
Olof Johansson Jan. 8, 2020, 6:29 p.m. UTC | #4
On Tue, Jan 07, 2020 at 11:38:44AM -0800, Bjorn Andersson wrote:
> On Tue 07 Jan 11:28 PST 2020, Ulf Hansson wrote:
> 
> > On Mon, 6 Jan 2020 at 18:31, Olof Johansson <olof@lixom.net> wrote:
> > >
> > > Hi,
> > >
> > > On Thu, Jan 02, 2020 at 05:08:20PM +0100, Ulf Hansson wrote:
> > > > Hi SoC maintainers,
> > > >
> > > > Here's a PR with updates for v5.6 for cpuidle/psci for ARM/ARM64.
> > > >
> > > > The changes are somewhat sprinkled over a couple of different directories and
> > > > there is also dts update for MSM8916. The main changes are in drivers/cpuidle/,
> > > > which have been acked-by Rafael [1] and Sudeep.
> > > >
> > > > If you have any further questions, please just tell.
> > >
> > > What was the reason to bring in a dts change in this branch?
> > 
> > Convenience. But I am not usually sending these PR, so feel free to
> > tell me to change.
> > 
> 
> The dts files are typically moving a lot, so to reduce the risk of
> conflicts it's generally better if we take them through the qcom tree.
> 
> > > Bindings should be
> > > stable such that old DT contents still works even if drivers are updated to
> > > support newer attributes, etc.
> > 
> > They already are. No worries!
> > 
> > If you want to pick everything else but the DTS patch, that's fine by me.
> > 
> 
> Generally, yes.
> 
> > Do you want me to send a new PR?
> > 
> 
> But I'm happy with the dts patch and afaict there's nothing that this
> will conflict with. So you have my retroactive ack on the patch and
> lets stick with the current PR.

As long as there's no anticipated changes in DTS that's OK (which is
why it's good to at least seek the ack from Bjorn in this case).

There's one more issue with this pull request -- it's based on
5.5-rc4. We normally don't move to later -rcs for the base once things
land (i.e. we're still at -rc2), since it just causes churn.

I'll merge this now anyway, but in the future if you're unsure what to
use as a base for your topic branches, look at our master branch to see
where it's at.


-Olof