mbox series

[v2,0/2] net: stmmac: remove useless code of phy_mask

Message ID 20200108072550.28613-1-zhengdejin5@gmail.com (mailing list archive)
Headers show
Series net: stmmac: remove useless code of phy_mask | expand

Message

Dejin Zheng Jan. 8, 2020, 7:25 a.m. UTC 
These patches just for cleanup codes in stmmac driver.

Changes since v1:
	1, add a new commit for remove the useless member phy_mask.
	2, adjust some commit comments for the original commit.

Dejin Zheng (2):
  net: stmmac: pci: remove the duplicate code of set phy_mask
  net: stmmac: remove the useless member phy_mask

 drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 1 -
 drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c  | 5 -----
 include/linux/stmmac.h                            | 1 -
 3 files changed, 7 deletions(-)

Comments

Jose Abreu Jan. 8, 2020, 7:57 a.m. UTC | #1 
From: Dejin Zheng <zhengdejin5@gmail.com>
Date: Jan/08/2020, 07:25:48 (UTC+00:00)

> Changes since v1:
> 	1, add a new commit for remove the useless member phy_mask.

No, this is not useless. It's an API for developers that need only 
certain PHYs to be detected. Please do not remove this.

---
Thanks,
Jose Miguel Abreu
Dejin Zheng Jan. 8, 2020, 11:26 a.m. UTC | #2 
On Wed, Jan 08, 2020 at 07:57:14AM +0000, Jose Abreu wrote:
> From: Dejin Zheng <zhengdejin5@gmail.com>
> Date: Jan/08/2020, 07:25:48 (UTC+00:00)
> 
> > Changes since v1:
> > 	1, add a new commit for remove the useless member phy_mask.
> 
> No, this is not useless. It's an API for developers that need only 
> certain PHYs to be detected. Please do not remove this.
>
Hi Jose:

Okay, If you think it is a feature that needs to be retained, I will
abandon it. since I am a newbie, after that, Do I need to update the
other commit in this patchset for patch v3? Thanks!

BR,
dejin

> ---
> Thanks,
> Jose Miguel Abreu
Jose Abreu Jan. 8, 2020, 1:25 p.m. UTC | #3 
From: Dejin Zheng <zhengdejin5@gmail.com>
Date: Jan/08/2020, 11:26:52 (UTC+00:00)

> On Wed, Jan 08, 2020 at 07:57:14AM +0000, Jose Abreu wrote:
> > From: Dejin Zheng <zhengdejin5@gmail.com>
> > Date: Jan/08/2020, 07:25:48 (UTC+00:00)
> > 
> > > Changes since v1:
> > > 	1, add a new commit for remove the useless member phy_mask.
> > 
> > No, this is not useless. It's an API for developers that need only 
> > certain PHYs to be detected. Please do not remove this.
> >
> Hi Jose:
> 
> Okay, If you think it is a feature that needs to be retained, I will
> abandon it. since I am a newbie, after that, Do I need to update the
> other commit in this patchset for patch v3? Thanks!

Your first commit (1/2) looks okay so you can submit that stand-alone in 
my opinion.

---
Thanks,
Jose Miguel Abreu
Dejin Zheng Jan. 8, 2020, 1:43 p.m. UTC | #4 
On Wed, Jan 08, 2020 at 01:25:21PM +0000, Jose Abreu wrote:
> From: Dejin Zheng <zhengdejin5@gmail.com>
> Date: Jan/08/2020, 11:26:52 (UTC+00:00)
> 
> > On Wed, Jan 08, 2020 at 07:57:14AM +0000, Jose Abreu wrote:
> > > From: Dejin Zheng <zhengdejin5@gmail.com>
> > > Date: Jan/08/2020, 07:25:48 (UTC+00:00)
> > > 
> > > > Changes since v1:
> > > > 	1, add a new commit for remove the useless member phy_mask.
> > > 
> > > No, this is not useless. It's an API for developers that need only 
> > > certain PHYs to be detected. Please do not remove this.
> > >
> > Hi Jose:
> > 
> > Okay, If you think it is a feature that needs to be retained, I will
> > abandon it. since I am a newbie, after that, Do I need to update the
> > other commit in this patchset for patch v3? Thanks!
> 
> Your first commit (1/2) looks okay so you can submit that stand-alone in 
> my opinion.
>
Jose, thanks for your suggestions, You are so nice! I will do it.
> ---
> Thanks,
> Jose Miguel Abreu