| Message ID | e7becc50bee355e3872b84d91cc68ae8d7776bb9.1578764712.git.christophe.leroy@c-s.fr (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Paul Burton |
| Headers | show |
| Series | lib: vdso: mark __cvdso_clock_getres() as static | expand |
Christophe Leroy <christophe.leroy@c-s.fr> writes: > When __cvdso_clock_getres() became __cvdso_clock_getres_common() > and a new __cvdso_clock_getres() was added, static qualifier was > forgotten. > > Fixes: 502a590a170b ("lib/vdso: Move fallback invocation to the callers") > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> I've already queued: https://lore.kernel.org/r/20191128111719.8282-1-vincenzo.frascino@arm.com but thanks for caring! Thanks, tglx
Le 11/01/2020 à 20:59, Thomas Gleixner a écrit : > Christophe Leroy <christophe.leroy@c-s.fr> writes: >> When __cvdso_clock_getres() became __cvdso_clock_getres_common() >> and a new __cvdso_clock_getres() was added, static qualifier was >> forgotten. >> >> Fixes: 502a590a170b ("lib/vdso: Move fallback invocation to the callers") >> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> > > I've already queued: > > https://lore.kernel.org/r/20191128111719.8282-1-vincenzo.frascino@arm.com > > but thanks for caring! > Is there a git tree with the latest VDSO status ? https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git?h=timers%2Fvdso is 6 monthes old. Christophe
Christophe Leroy <christophe.leroy@c-s.fr> writes: > Is there a git tree with the latest VDSO status ? > > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git?h=timers%2Fvdso > is 6 monthes old. Will push a new one later today. I'll let you know. Thanks, tglx
diff --git a/lib/vdso/gettimeofday.c b/lib/vdso/gettimeofday.c index 9ecfd3b547ba..42bd8ab955fa 100644 --- a/lib/vdso/gettimeofday.c +++ b/lib/vdso/gettimeofday.c @@ -221,6 +221,7 @@ int __cvdso_clock_getres_common(clockid_t clock, struct __kernel_timespec *res) return 0; } +static __maybe_unused int __cvdso_clock_getres(clockid_t clock, struct __kernel_timespec *res) { int ret = __cvdso_clock_getres_common(clock, res);
When __cvdso_clock_getres() became __cvdso_clock_getres_common() and a new __cvdso_clock_getres() was added, static qualifier was forgotten. Fixes: 502a590a170b ("lib/vdso: Move fallback invocation to the callers") Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> --- lib/vdso/gettimeofday.c | 1 + 1 file changed, 1 insertion(+)