| Message ID | 20200117025717.58636-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] cifs: remove set but not used variable 'server' | expand |
merged into cifs-2.6.git for-next On Thu, Jan 16, 2020 at 10:01 PM YueHaibing <yuehaibing@huawei.com> wrote: > > fs/cifs/smb2pdu.c: In function 'SMB2_query_directory': > fs/cifs/smb2pdu.c:4444:26: warning: > variable 'server' set but not used [-Wunused-but-set-variable] > struct TCP_Server_Info *server; > > It is not used, so remove it. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > fs/cifs/smb2pdu.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c > index a23ca3d..64d5a36 100644 > --- a/fs/cifs/smb2pdu.c > +++ b/fs/cifs/smb2pdu.c > @@ -4441,13 +4441,10 @@ SMB2_query_directory(const unsigned int xid, struct cifs_tcon *tcon, > int resp_buftype = CIFS_NO_BUFFER; > struct kvec rsp_iov; > int rc = 0; > - struct TCP_Server_Info *server; > struct cifs_ses *ses = tcon->ses; > int flags = 0; > > - if (ses && (ses->server)) > - server = ses->server; > - else > + if (!ses || !(ses->server)) > return -EIO; > > if (smb3_encryption_required(tcon)) > -- > 2.7.4 > >
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index a23ca3d..64d5a36 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -4441,13 +4441,10 @@ SMB2_query_directory(const unsigned int xid, struct cifs_tcon *tcon, int resp_buftype = CIFS_NO_BUFFER; struct kvec rsp_iov; int rc = 0; - struct TCP_Server_Info *server; struct cifs_ses *ses = tcon->ses; int flags = 0; - if (ses && (ses->server)) - server = ses->server; - else + if (!ses || !(ses->server)) return -EIO; if (smb3_encryption_required(tcon))
fs/cifs/smb2pdu.c: In function 'SMB2_query_directory': fs/cifs/smb2pdu.c:4444:26: warning: variable 'server' set but not used [-Wunused-but-set-variable] struct TCP_Server_Info *server; It is not used, so remove it. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- fs/cifs/smb2pdu.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)