| Message ID | 1579220504-110067-6-git-send-email-hanjie.lin@amlogic.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: meson: Add support for USB on Amlogic A1 | expand |
Hi Hanjie, On Fri, Jan 17, 2020 at 1:22 AM Hanjie Lin <hanjie.lin@amlogic.com> wrote: > > Enable USB2 PHY for Meson A1 SoC. > > Signed-off-by: Yue Wang <yue.wang@amlogic.com> > Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com> > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) personally I would squash this with patch 6/6 because it's only useful together with patch 6/6 on the other hand: it's not worth sending a v7 just for this > @@ -100,6 +101,18 @@ > #power-domain-cells = <1>; > status = "okay"; > }; > + > + usb2_phy1: phy@40000 { > + status = "okay"; we typically use one of the following patterns: - status = "disabled" in SoC.dts - status = "okay" in board.dts whenever the peripheral should be used (example: I2C, USB, ...) OR - no status property if the peripheral is mandatory on all boards (for example: clock controller, ...) so for consistency with other Amlogic .dts I would either drop the status property or set it to disabled (and enable it in meson-a1-ad401.dts) same applies to patch 6/6 Martin
On 2020/1/19 6:05, Martin Blumenstingl wrote: > Hi Hanjie, > > On Fri, Jan 17, 2020 at 1:22 AM Hanjie Lin <hanjie.lin@amlogic.com> wrote: >> >> Enable USB2 PHY for Meson A1 SoC. >> >> Signed-off-by: Yue Wang <yue.wang@amlogic.com> >> Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com> >> --- >> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) > personally I would squash this with patch 6/6 because it's only useful > together with patch 6/6 > on the other hand: it's not worth sending a v7 just for this > >> @@ -100,6 +101,18 @@ >> #power-domain-cells = <1>; >> status = "okay"; >> }; >> + >> + usb2_phy1: phy@40000 { >> + status = "okay"; > we typically use one of the following patterns: > - status = "disabled" in SoC.dts > - status = "okay" in board.dts whenever the peripheral should be used > (example: I2C, USB, ...) > OR > - no status property if the peripheral is mandatory on all boards (for > example: clock controller, ...) > > so for consistency with other Amlogic .dts I would either drop the > status property or set it to disabled (and enable it in > meson-a1-ad401.dts) > same applies to patch 6/6 > > > Martin > > . > Hi Martin, Of course, it will be more reasonable. I have a bindings issue need to fix too, so I will do these together in v7. Thanks, Hanjie
diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi index 6fdc0dd..fb0ba85 100644 --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi @@ -6,6 +6,7 @@ #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/power/meson-a1-power.h> +#include <dt-bindings/reset/amlogic,meson-a1-reset.h> / { compatible = "amlogic,a1"; @@ -100,6 +101,18 @@ #power-domain-cells = <1>; status = "okay"; }; + + usb2_phy1: phy@40000 { + status = "okay"; + compatible = "amlogic,a1-usb2-phy"; + clocks = <&clkc_periphs CLKID_XTAL_USB_PHY>; + clock-names = "xtal"; + reg = <0x0 0x40000 0x0 0x2000>; + resets = <&reset RESET_USBPHY>; + reset-names = "phy"; + #phy-cells = <0>; + power-domains = <&pwrc PWRC_USB_ID>; + }; }; gic: interrupt-controller@ff901000 {