| Message ID | cover.1578560282.git.benchuanggli@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support UHS-II for GL9755 | expand |
Hi Uffe and Adrian, On Thu, Jan 9, 2020 at 5:13 PM Ben Chuang <benchuanggli@gmail.com> wrote: > > Hi Uffe and Adrian, > > These patches support UHS-II and fix GL9755 UHS-II compatibility. > > The parts of UHS-II are based on [1][2] and porting to Linux 5.5-rc5. > I have seen that Uffe comment that splitting the UHS-II parts into smaller > patches. Other than splitting into small patches, could you give me some > suggestions for refactoring/splitting files? > > Best regards, > Ben Gentle Ping, Any comments? Best regards, Ben > > References: > 1. [RFC,1/2] mmc: core: support UHS-II in core stack. > (https://patchwork.kernel.org/patch/5544441/) > 2. [RFC,2/2] mmc: sdhci: support UHS-II in SDHCI host. > (https://patchwork.kernel.org/patch/5544451/) > > v2: > - base on Linux v5.5-rc5 > > Ben Chuang (6): > mmc: Add UHS-II support in public headers > mmc: core: Add UHS-II support in core layer > mmc: host: Add UHS-II support in host layer > mmc: uhs2: Introduce a uhs2_post_attach_sd function > mmc: sdhci-uhs2: Introduce a uhs2_pre_detect_init function > mmc: sdhci-pci-gli: Fix power/reset/ZC/timeout for GL9755 UHS-II mode > > drivers/mmc/core/Makefile | 3 +- > drivers/mmc/core/block.c | 7 +- > drivers/mmc/core/bus.c | 5 +- > drivers/mmc/core/core.c | 65 +- > drivers/mmc/core/core.h | 3 +- > drivers/mmc/core/regulator.c | 14 + > drivers/mmc/core/sd.c | 27 +- > drivers/mmc/core/sd_ops.c | 12 + > drivers/mmc/core/uhs2.c | 995 +++++++++++++++++++++ > drivers/mmc/core/uhs2.h | 23 + > drivers/mmc/host/Makefile | 1 + > drivers/mmc/host/{sdhci.c => sdhci-core.c} | 285 +++++- > drivers/mmc/host/sdhci-milbeaut.c | 4 +- > drivers/mmc/host/sdhci-of-arasan.c | 4 +- > drivers/mmc/host/sdhci-of-at91.c | 4 +- > drivers/mmc/host/sdhci-omap.c | 2 +- > drivers/mmc/host/sdhci-pci-core.c | 4 +- > drivers/mmc/host/sdhci-pci-gli.c | 361 +++++++- > drivers/mmc/host/sdhci-pxav3.c | 4 +- > drivers/mmc/host/sdhci-uhs2.c | 754 ++++++++++++++++ > drivers/mmc/host/sdhci-uhs2.h | 34 + > drivers/mmc/host/sdhci-xenon.c | 4 +- > drivers/mmc/host/sdhci.h | 286 +++++- > drivers/mmc/host/sdhci_am654.c | 4 +- > include/linux/mmc/card.h | 1 + > include/linux/mmc/core.h | 6 + > include/linux/mmc/host.h | 31 + > include/linux/mmc/uhs2.h | 270 ++++++ > 28 files changed, 3137 insertions(+), 76 deletions(-) > create mode 100644 drivers/mmc/core/uhs2.c > create mode 100644 drivers/mmc/core/uhs2.h > rename drivers/mmc/host/{sdhci.c => sdhci-core.c} (94%) > create mode 100644 drivers/mmc/host/sdhci-uhs2.c > create mode 100644 drivers/mmc/host/sdhci-uhs2.h > create mode 100644 include/linux/mmc/uhs2.h > > > base-commit: c79f46a282390e0f5b306007bf7b11a46d529538 > -- > 2.24.1 >
On Tue, 21 Jan 2020 at 10:37, Ben Chuang <benchuanggli@gmail.com> wrote: > > Hi Uffe and Adrian, > > On Thu, Jan 9, 2020 at 5:13 PM Ben Chuang <benchuanggli@gmail.com> wrote: > > > > Hi Uffe and Adrian, > > > > These patches support UHS-II and fix GL9755 UHS-II compatibility. > > > > The parts of UHS-II are based on [1][2] and porting to Linux 5.5-rc5. > > I have seen that Uffe comment that splitting the UHS-II parts into smaller > > patches. Other than splitting into small patches, could you give me some > > suggestions for refactoring/splitting files? > > > > Best regards, > > Ben > > Gentle Ping, Any comments? I coming to this, but I need some additional time. In any case, thanks for posting this and for pinging! [...] Kind regards Uffe
On Tue, Jan 21, 2020 at 8:02 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Tue, 21 Jan 2020 at 10:37, Ben Chuang <benchuanggli@gmail.com> wrote: > > > > Hi Uffe and Adrian, > > > > On Thu, Jan 9, 2020 at 5:13 PM Ben Chuang <benchuanggli@gmail.com> wrote: > > > > > > Hi Uffe and Adrian, > > > > > > These patches support UHS-II and fix GL9755 UHS-II compatibility. > > > > > > The parts of UHS-II are based on [1][2] and porting to Linux 5.5-rc5. > > > I have seen that Uffe comment that splitting the UHS-II parts into smaller > > > patches. Other than splitting into small patches, could you give me some > > > suggestions for refactoring/splitting files? > > > > > > Best regards, > > > Ben > > > > Gentle Ping, Any comments? > > I coming to this, but I need some additional time. In any case, thanks > for posting this and for pinging! > Thank you for taking the time and pinging back quickly. :-) I will wait patiently for the next reply. > [...] > > Kind regards > Uffe Best regards, Ben
Hi Uffe and Adrian, These patches support UHS-II and fix GL9755 UHS-II compatibility. The parts of UHS-II are based on [1][2] and porting to Linux 5.5-rc5. I have seen that Uffe comment that splitting the UHS-II parts into smaller patches. Other than splitting into small patches, could you give me some suggestions for refactoring/splitting files? Best regards, Ben References: 1. [RFC,1/2] mmc: core: support UHS-II in core stack. (https://patchwork.kernel.org/patch/5544441/) 2. [RFC,2/2] mmc: sdhci: support UHS-II in SDHCI host. (https://patchwork.kernel.org/patch/5544451/) v2: - base on Linux v5.5-rc5 Ben Chuang (6): mmc: Add UHS-II support in public headers mmc: core: Add UHS-II support in core layer mmc: host: Add UHS-II support in host layer mmc: uhs2: Introduce a uhs2_post_attach_sd function mmc: sdhci-uhs2: Introduce a uhs2_pre_detect_init function mmc: sdhci-pci-gli: Fix power/reset/ZC/timeout for GL9755 UHS-II mode drivers/mmc/core/Makefile | 3 +- drivers/mmc/core/block.c | 7 +- drivers/mmc/core/bus.c | 5 +- drivers/mmc/core/core.c | 65 +- drivers/mmc/core/core.h | 3 +- drivers/mmc/core/regulator.c | 14 + drivers/mmc/core/sd.c | 27 +- drivers/mmc/core/sd_ops.c | 12 + drivers/mmc/core/uhs2.c | 995 +++++++++++++++++++++ drivers/mmc/core/uhs2.h | 23 + drivers/mmc/host/Makefile | 1 + drivers/mmc/host/{sdhci.c => sdhci-core.c} | 285 +++++- drivers/mmc/host/sdhci-milbeaut.c | 4 +- drivers/mmc/host/sdhci-of-arasan.c | 4 +- drivers/mmc/host/sdhci-of-at91.c | 4 +- drivers/mmc/host/sdhci-omap.c | 2 +- drivers/mmc/host/sdhci-pci-core.c | 4 +- drivers/mmc/host/sdhci-pci-gli.c | 361 +++++++- drivers/mmc/host/sdhci-pxav3.c | 4 +- drivers/mmc/host/sdhci-uhs2.c | 754 ++++++++++++++++ drivers/mmc/host/sdhci-uhs2.h | 34 + drivers/mmc/host/sdhci-xenon.c | 4 +- drivers/mmc/host/sdhci.h | 286 +++++- drivers/mmc/host/sdhci_am654.c | 4 +- include/linux/mmc/card.h | 1 + include/linux/mmc/core.h | 6 + include/linux/mmc/host.h | 31 + include/linux/mmc/uhs2.h | 270 ++++++ 28 files changed, 3137 insertions(+), 76 deletions(-) create mode 100644 drivers/mmc/core/uhs2.c create mode 100644 drivers/mmc/core/uhs2.h rename drivers/mmc/host/{sdhci.c => sdhci-core.c} (94%) create mode 100644 drivers/mmc/host/sdhci-uhs2.c create mode 100644 drivers/mmc/host/sdhci-uhs2.h create mode 100644 include/linux/mmc/uhs2.h base-commit: c79f46a282390e0f5b306007bf7b11a46d529538