| Message ID | 20200122082621.4974-2-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: ti: UDMAP and McASP support | expand |
On 22/01/20 1:56 PM, Peter Ujfalusi wrote: > NAVSS is a subsystem containing different IPs, it is not really a bus. > Change the compatible from "simple-bus" to "simple-mfd" to reflect that. > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > index efb24579922c..e40f7acbec42 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > @@ -385,8 +385,8 @@ intr_main_gpio: interrupt-controller0 { > ti,sci-rm-range-girq = <0x1>; > }; > > - cbass_main_navss: interconnect0 { > - compatible = "simple-bus"; > + cbass_main_navss: navss@30800000 { This introduces below dtc warning when built with W=1 arch/arm64/boot/dts/ti/k3-am65-main.dtsi:388.35-530.4: Warning (unit_address_vs_reg): /interconnect@100000/navss@30800000: node has a unit name, but no reg property this is representing cbass inside main_navss, just like cbass_main. You can drop this patch and the similar mcu version. Thanks and regards, Lokesh > + compatible = "simple-mfd"; > #address-cells = <2>; > #size-cells = <2>; > ranges; >
On 22/01/2020 13.03, Lokesh Vutla wrote: > > > On 22/01/20 1:56 PM, Peter Ujfalusi wrote: >> NAVSS is a subsystem containing different IPs, it is not really a bus. >> Change the compatible from "simple-bus" to "simple-mfd" to reflect that. >> >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >> index efb24579922c..e40f7acbec42 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >> @@ -385,8 +385,8 @@ intr_main_gpio: interrupt-controller0 { >> ti,sci-rm-range-girq = <0x1>; >> }; >> >> - cbass_main_navss: interconnect0 { >> - compatible = "simple-bus"; >> + cbass_main_navss: navss@30800000 { > > This introduces below dtc warning when built with W=1 > > arch/arm64/boot/dts/ti/k3-am65-main.dtsi:388.35-530.4: Warning > (unit_address_vs_reg): /interconnect@100000/navss@30800000: node has a unit > name, but no reg property Interesting, the example in Documentation/devicetree/bindings/dma/ti/k3-udma.yaml is basically the same and dt_binding_check is happy about it: DTC Documentation/devicetree/bindings/dma/ti/k3-udma.example.dt.yaml CHECK Documentation/devicetree/bindings/dma/ti/k3-udma.example.dt.yaml but it screamed when I had the simple-bus in there (copied from the existing dtsi file). The node name for simple-bus _must_ be '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' I would not use any of these to NAVSS node... > this is representing cbass inside main_navss, just like cbass_main. You can drop > this patch and the similar mcu version. According to Documentation/devicetree/bindings/mfd/mfd.txt: - compatible : "simple-mfd" - this signifies that the operating system should consider all subnodes of the MFD device as separate devices akin to how "simple-bus" indicates when to see subnodes as children for a simple memory-mapped bus. NAVSS is falling into simple-mfd as the devices under it are independent devices. > > Thanks and regards, > Lokesh > >> + compatible = "simple-mfd"; >> #address-cells = <2>; >> #size-cells = <2>; >> ranges; >> - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 22/01/20 5:09 PM, Peter Ujfalusi wrote: > > > On 22/01/2020 13.03, Lokesh Vutla wrote: >> >> >> On 22/01/20 1:56 PM, Peter Ujfalusi wrote: >>> NAVSS is a subsystem containing different IPs, it is not really a bus. >>> Change the compatible from "simple-bus" to "simple-mfd" to reflect that. >>> >>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> >>> --- >>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >>> index efb24579922c..e40f7acbec42 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >>> @@ -385,8 +385,8 @@ intr_main_gpio: interrupt-controller0 { >>> ti,sci-rm-range-girq = <0x1>; >>> }; >>> >>> - cbass_main_navss: interconnect0 { >>> - compatible = "simple-bus"; >>> + cbass_main_navss: navss@30800000 { >> >> This introduces below dtc warning when built with W=1 >> >> arch/arm64/boot/dts/ti/k3-am65-main.dtsi:388.35-530.4: Warning >> (unit_address_vs_reg): /interconnect@100000/navss@30800000: node has a unit >> name, but no reg property > > Interesting, the example in > Documentation/devicetree/bindings/dma/ti/k3-udma.yaml > > is basically the same and dt_binding_check is happy about it: > DTC Documentation/devicetree/bindings/dma/ti/k3-udma.example.dt.yaml > CHECK Documentation/devicetree/bindings/dma/ti/k3-udma.example.dt.yaml > > but it screamed when I had the simple-bus in there (copied from the > existing dtsi file). > > The node name for simple-bus _must_ be > '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > > I would not use any of these to NAVSS node... > >> this is representing cbass inside main_navss, just like cbass_main. You can drop >> this patch and the similar mcu version. > > According to Documentation/devicetree/bindings/mfd/mfd.txt: > - compatible : "simple-mfd" - this signifies that the operating system > should consider all subnodes of the MFD device as separate devices > akin to how "simple-bus" indicates when to see subnodes as children > for a simple memory-mapped bus. > > NAVSS is falling into simple-mfd as the devices under it are independent > devices. okay, may be rename cbass_main_navss to main_navss. Thanks and regards, Lokesh > >> >> Thanks and regards, >> Lokesh >> >>> + compatible = "simple-mfd"; >>> #address-cells = <2>; >>> #size-cells = <2>; >>> ranges; >>> > > - Péter > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >
On 23/01/2020 10.32, Lokesh Vutla wrote: > > > On 22/01/20 5:09 PM, Peter Ujfalusi wrote: >> >> >> On 22/01/2020 13.03, Lokesh Vutla wrote: >>> >>> >>> On 22/01/20 1:56 PM, Peter Ujfalusi wrote: >>>> NAVSS is a subsystem containing different IPs, it is not really a bus. >>>> Change the compatible from "simple-bus" to "simple-mfd" to reflect that. >>>> >>>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> >>>> --- >>>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >>>> index efb24579922c..e40f7acbec42 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >>>> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >>>> @@ -385,8 +385,8 @@ intr_main_gpio: interrupt-controller0 { >>>> ti,sci-rm-range-girq = <0x1>; >>>> }; >>>> >>>> - cbass_main_navss: interconnect0 { >>>> - compatible = "simple-bus"; >>>> + cbass_main_navss: navss@30800000 { >>> >>> This introduces below dtc warning when built with W=1 >>> >>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi:388.35-530.4: Warning >>> (unit_address_vs_reg): /interconnect@100000/navss@30800000: node has a unit >>> name, but no reg property >> >> Interesting, the example in >> Documentation/devicetree/bindings/dma/ti/k3-udma.yaml >> >> is basically the same and dt_binding_check is happy about it: >> DTC Documentation/devicetree/bindings/dma/ti/k3-udma.example.dt.yaml >> CHECK Documentation/devicetree/bindings/dma/ti/k3-udma.example.dt.yaml >> >> but it screamed when I had the simple-bus in there (copied from the >> existing dtsi file). >> >> The node name for simple-bus _must_ be >> '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' >> >> I would not use any of these to NAVSS node... >> >>> this is representing cbass inside main_navss, just like cbass_main. You can drop >>> this patch and the similar mcu version. >> >> According to Documentation/devicetree/bindings/mfd/mfd.txt: >> - compatible : "simple-mfd" - this signifies that the operating system >> should consider all subnodes of the MFD device as separate devices >> akin to how "simple-bus" indicates when to see subnodes as children >> for a simple memory-mapped bus. >> >> NAVSS is falling into simple-mfd as the devices under it are independent >> devices. > > okay, may be rename cbass_main_navss to main_navss. Actually we don't even need label for any of the NAVSS nodes. > > Thanks and regards, > Lokesh > >> >>> >>> Thanks and regards, >>> Lokesh >>> >>>> + compatible = "simple-mfd"; >>>> #address-cells = <2>; >>>> #size-cells = <2>; >>>> ranges; >>>> >> >> - Péter >> >> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. >> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >> - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi index efb24579922c..e40f7acbec42 100644 --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi @@ -385,8 +385,8 @@ intr_main_gpio: interrupt-controller0 { ti,sci-rm-range-girq = <0x1>; }; - cbass_main_navss: interconnect0 { - compatible = "simple-bus"; + cbass_main_navss: navss@30800000 { + compatible = "simple-mfd"; #address-cells = <2>; #size-cells = <2>; ranges;
NAVSS is a subsystem containing different IPs, it is not really a bus. Change the compatible from "simple-bus" to "simple-mfd" to reflect that. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)