[PATCH_V3,0/6] thermal: stm32: driver improvements

Message

Pascal Paillet Jan. 10, 2020, 10:15 a.m. UTC

The goal of this patchset is to improve and simplify the stm32 thermal
driver:
* let the framework handle the trip points: it very is hard to split this patch
into smaller ones and keep each individual patch functional.
* fix interrupt management to avoid receiving hundreds of
interrupts when the temperature is close to the low threshold.
* improve temperature reading resolution
* the dirver is backawrd compatible.

Pascal Paillet (6):
changes in v2:
* Split "handle multiple trip points" patch to make ones:
*   rework sensor mode management
*   disable interrupts at probe
* "remove hardware irq handler" is squashed in "handle multiple trip points"

  thermal: stm32: fix icifr register name
  thermal: stm32: rework sensor mode management
  thermal: stm32: disable interrupts at probe
  thermal: stm32: handle multiple trip points
  thermal: stm32: improve temperature computing
  thermal: stm32: fix low threshold interrupt flood

 drivers/thermal/st/stm_thermal.c | 388 ++++++++++---------------------
 1 file changed, 120 insertions(+), 268 deletions(-)

Comments

Pascal Paillet Jan. 27, 2020, 1:17 p.m. UTC | #1

The goal of this patchset is to improve and simplify the stm32 thermal
> driver:
> * let the framework handle the trip points: it very is hard to split this patch
> into smaller ones and keep each individual patch functional.
> * fix interrupt management to avoid receiving hundreds of
> interrupts when the temperature is close to the low threshold.
> * improve temperature reading resolution
> * the dirver is backawrd compatible.
>
> Pascal Paillet (6):
> changes in v2:
> * Split "handle multiple trip points" patch to make ones:
> *   rework sensor mode management
> *   disable interrupts at probe
> * "remove hardware irq handler" is squashed in "handle multiple trip points"
kind reminder for review
>    thermal: stm32: fix icifr register name
>    thermal: stm32: rework sensor mode management
>    thermal: stm32: disable interrupts at probe
>    thermal: stm32: handle multiple trip points
>    thermal: stm32: improve temperature computing
>    thermal: stm32: fix low threshold interrupt flood
>
>   drivers/thermal/st/stm_thermal.c | 388 ++++++++++---------------------
>   1 file changed, 120 insertions(+), 268 deletions(-)
>

Daniel Lezcano Jan. 27, 2020, 2:39 p.m. UTC | #2

On 27/01/2020 14:17, Pascal PAILLET-LME wrote:
> The goal of this patchset is to improve and simplify the stm32 thermal
>> driver:
>> * let the framework handle the trip points: it very is hard to split this patch
>> into smaller ones and keep each individual patch functional.
>> * fix interrupt management to avoid receiving hundreds of
>> interrupts when the temperature is close to the low threshold.
>> * improve temperature reading resolution
>> * the dirver is backawrd compatible.
>>
>> Pascal Paillet (6):
>> changes in v2:
>> * Split "handle multiple trip points" patch to make ones:
>> *   rework sensor mode management
>> *   disable interrupts at probe
>> * "remove hardware irq handler" is squashed in "handle multiple trip points"
> kind reminder for review
>>    thermal: stm32: fix icifr register name
>>    thermal: stm32: rework sensor mode management
>>    thermal: stm32: disable interrupts at probe
>>    thermal: stm32: handle multiple trip points
>>    thermal: stm32: improve temperature computing
>>    thermal: stm32: fix low threshold interrupt flood
>>
>>   drivers/thermal/st/stm_thermal.c | 388 ++++++++++---------------------
>>   1 file changed, 120 insertions(+), 268 deletions(-)

The series looks good to me. I've applied it for kernelci, if it is good
it will go to the next branch and be part of the next pull request.

In the future, do not join the PATCH keyword with the version. That
puzzles patchwork.

Thanks

  -- Daniel