| Message ID | 20200125183135.28317-1-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | .travis.yml: Add description to each job | expand |
On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: > The NAME variable can be used to describe nicely a job (see [*]). > As we currently have 32 jobs, use it. This helps for quickly > finding a particular job. > > before: https://travis-ci.org/qemu/qemu/builds/639887646 > after: https://travis-ci.org/philmd/qemu/builds/641795043 Very good idea, correlating a job in the GUI to an entry in the yml file was really a pain, so far. > [*] https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > .travis.yml | 101 ++++++++++++++++++++++++++++++++++------------------ > 1 file changed, 67 insertions(+), 34 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 6c1038a0f1..d68e35a2c5 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -94,24 +94,28 @@ after_script: > > matrix: > include: > - - env: > + - name: "[x86] GCC static (user)" Could you please drop the [x86] and other architectures from the names? Travis already lists the build architecture in the job status page, so this information is redundant. [...] > # Alternate coroutines implementations are only really of interest to KVM users > # However we can't test against KVM on Travis so we can only run unit tests > - - env: > + - name: "[x86] check-unit coroutine=ucontext" > + env: > - CONFIG="--with-coroutine=ucontext --disable-tcg" > - TEST_CMD="make check-unit -j3 V=1" > > > - - env: > + - name: "[x86] check-unit coroutine=sigaltstack" > + env: > - CONFIG="--with-coroutine=sigaltstack --disable-tcg" > - TEST_CMD="make check-unit -j3 V=1" > Off-topic to your patch, but aren't coroutines something that is only used in the softmmu targets? If so, we could add --disable-user to the above two builds to speed things up a little bit. > > # Check we can build docs and tools (out of tree) > - - env: > + - name: "[x86] tools and docs" > + env: > - BUILD_DIR="out-of-tree/build/dir" SRC_DIR="../../.." Also off-topic, but I think we can now remove the above line and fix the comment - since all builds are now out-of-tree anyway, see commit bc4486fb233573e. > @@ -250,7 +271,8 @@ matrix: > > > # Python builds > - - env: > + - name: "[x86] GCC Python 3.5 (x86_64-softmmu)" > + env: Off-topic again: Python 3.5 is the default on xenial, and since we stopped using Python 2.7, I think we could remove this job now. We could add some jobs with Bionic + Python 3.7 and 3.8 instead. > - CONFIG="--target-list=x86_64-softmmu" > - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" > language: python > @@ -258,7 +280,8 @@ matrix: > - "3.5" > > > - - env: > + - name: "[x86] GCC Python 3.6 (x86_64-softmmu)" > + env: > - CONFIG="--target-list=x86_64-softmmu" > - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" > language: python Thomas
Thomas Huth <thuth@redhat.com> writes: > On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: >> The NAME variable can be used to describe nicely a job (see [*]). >> As we currently have 32 jobs, use it. This helps for quickly >> finding a particular job. >> >> before: https://travis-ci.org/qemu/qemu/builds/639887646 >> after: https://travis-ci.org/philmd/qemu/builds/641795043 > > Very good idea, correlating a job in the GUI to an entry in the yml file > was really a pain, so far. > >> [*] https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> .travis.yml | 101 ++++++++++++++++++++++++++++++++++------------------ >> 1 file changed, 67 insertions(+), 34 deletions(-) >> >> diff --git a/.travis.yml b/.travis.yml >> index 6c1038a0f1..d68e35a2c5 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -94,24 +94,28 @@ after_script: >> >> matrix: >> include: >> - - env: >> + - name: "[x86] GCC static (user)" > > Could you please drop the [x86] and other architectures from the names? > Travis already lists the build architecture in the job status page, so > this information is redundant. Hmm for me the Travis page mis-renders the architecture (on firefox) so I do find the arch in the text fairly handy. > > [...] >> # Alternate coroutines implementations are only really of interest to KVM users >> # However we can't test against KVM on Travis so we can only run unit tests >> - - env: >> + - name: "[x86] check-unit coroutine=ucontext" >> + env: >> - CONFIG="--with-coroutine=ucontext --disable-tcg" >> - TEST_CMD="make check-unit -j3 V=1" >> >> >> - - env: >> + - name: "[x86] check-unit coroutine=sigaltstack" >> + env: >> - CONFIG="--with-coroutine=sigaltstack --disable-tcg" >> - TEST_CMD="make check-unit -j3 V=1" >> > > Off-topic to your patch, but aren't coroutines something that is only > used in the softmmu targets? If so, we could add --disable-user to the > above two builds to speed things up a little bit. I think --disable-tcg implies --disable-user as you can't run without it. > >> >> # Check we can build docs and tools (out of tree) >> - - env: >> + - name: "[x86] tools and docs" >> + env: >> - BUILD_DIR="out-of-tree/build/dir" SRC_DIR="../../.." > > Also off-topic, but I think we can now remove the above line and fix the > comment - since all builds are now out-of-tree anyway, see commit > bc4486fb233573e. > > >> @@ -250,7 +271,8 @@ matrix: >> >> >> # Python builds >> - - env: >> + - name: "[x86] GCC Python 3.5 (x86_64-softmmu)" >> + env: > > Off-topic again: > Python 3.5 is the default on xenial, and since we stopped using Python > 2.7, I think we could remove this job now. > > We could add some jobs with Bionic + Python 3.7 and 3.8 instead. > >> - CONFIG="--target-list=x86_64-softmmu" >> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" >> language: python >> @@ -258,7 +280,8 @@ matrix: >> - "3.5" >> >> >> - - env: >> + - name: "[x86] GCC Python 3.6 (x86_64-softmmu)" >> + env: >> - CONFIG="--target-list=x86_64-softmmu" >> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" >> language: python > > Thomas
On Tue, Jan 28, 2020 at 1:55 PM Alex Bennée <alex.bennee@linaro.org> wrote: > Thomas Huth <thuth@redhat.com> writes: > > On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: > >> The NAME variable can be used to describe nicely a job (see [*]). > >> As we currently have 32 jobs, use it. This helps for quickly > >> finding a particular job. > >> > >> before: https://travis-ci.org/qemu/qemu/builds/639887646 > >> after: https://travis-ci.org/philmd/qemu/builds/641795043 > > > > Very good idea, correlating a job in the GUI to an entry in the yml file > > was really a pain, so far. > > > >> [*] https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices > >> > >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > >> --- > >> .travis.yml | 101 ++++++++++++++++++++++++++++++++++------------------ > >> 1 file changed, 67 insertions(+), 34 deletions(-) > >> > >> diff --git a/.travis.yml b/.travis.yml > >> index 6c1038a0f1..d68e35a2c5 100644 > >> --- a/.travis.yml > >> +++ b/.travis.yml > >> @@ -94,24 +94,28 @@ after_script: > >> > >> matrix: > >> include: > >> - - env: > >> + - name: "[x86] GCC static (user)" > > > > Could you please drop the [x86] and other architectures from the names? > > Travis already lists the build architecture in the job status page, so > > this information is redundant. > > Hmm for me the Travis page mis-renders the architecture (on firefox) so > I do find the arch in the text fairly handy. This might be a font problem, I can't see the architecture on neither Firefox nor Chrome: https://pasteboard.co/IS3O358.png
On 1/26/20 5:54 AM, Thomas Huth wrote: > On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: >> The NAME variable can be used to describe nicely a job (see [*]). >> As we currently have 32 jobs, use it. This helps for quickly >> finding a particular job. >> >> before: https://travis-ci.org/qemu/qemu/builds/639887646 >> after: https://travis-ci.org/philmd/qemu/builds/641795043 > Very good idea, correlating a job in the GUI to an entry in the yml file > was really a pain, so far. > >> [*] https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> .travis.yml | 101 ++++++++++++++++++++++++++++++++++------------------ >> 1 file changed, 67 insertions(+), 34 deletions(-) >> >> diff --git a/.travis.yml b/.travis.yml >> index 6c1038a0f1..d68e35a2c5 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -94,24 +94,28 @@ after_script: >> >> matrix: >> include: >> - - env: >> + - name: "[x86] GCC static (user)" > Could you please drop the [x86] and other architectures from the names? > Travis already lists the build architecture in the job status page, so > this information is redundant. > > [...] I agree on dropping the architecture from the names, so: Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> >> # Alternate coroutines implementations are only really of interest to KVM users >> # However we can't test against KVM on Travis so we can only run unit tests Yet another off-topic comment: If we switch those coroutine test jobs to Bionic then we can use KVM. - Wainer >> - - env: >> + - name: "[x86] check-unit coroutine=ucontext" >> + env: >> - CONFIG="--with-coroutine=ucontext --disable-tcg" >> - TEST_CMD="make check-unit -j3 V=1" >> >> >> - - env: >> + - name: "[x86] check-unit coroutine=sigaltstack" >> + env: >> - CONFIG="--with-coroutine=sigaltstack --disable-tcg" >> - TEST_CMD="make check-unit -j3 V=1" >> > Off-topic to your patch, but aren't coroutines something that is only > used in the softmmu targets? If so, we could add --disable-user to the > above two builds to speed things up a little bit. > >> >> # Check we can build docs and tools (out of tree) >> - - env: >> + - name: "[x86] tools and docs" >> + env: >> - BUILD_DIR="out-of-tree/build/dir" SRC_DIR="../../.." > Also off-topic, but I think we can now remove the above line and fix the > comment - since all builds are now out-of-tree anyway, see commit > bc4486fb233573e. > > >> @@ -250,7 +271,8 @@ matrix: >> >> >> # Python builds >> - - env: >> + - name: "[x86] GCC Python 3.5 (x86_64-softmmu)" >> + env: > Off-topic again: > Python 3.5 is the default on xenial, and since we stopped using Python > 2.7, I think we could remove this job now. > > We could add some jobs with Bionic + Python 3.7 and 3.8 instead. > >> - CONFIG="--target-list=x86_64-softmmu" >> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" >> language: python >> @@ -258,7 +280,8 @@ matrix: >> - "3.5" >> >> >> - - env: >> + - name: "[x86] GCC Python 3.6 (x86_64-softmmu)" >> + env: >> - CONFIG="--target-list=x86_64-softmmu" >> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" >> language: python > Thomas > >
On 1/28/20 11:18 AM, Philippe Mathieu-Daudé wrote: > On Tue, Jan 28, 2020 at 1:55 PM Alex Bennée <alex.bennee@linaro.org> wrote: >> Thomas Huth <thuth@redhat.com> writes: >>> On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: >>>> The NAME variable can be used to describe nicely a job (see [*]). >>>> As we currently have 32 jobs, use it. This helps for quickly >>>> finding a particular job. >>>> >>>> before: https://travis-ci.org/qemu/qemu/builds/639887646 >>>> after: https://travis-ci.org/philmd/qemu/builds/641795043 >>> Very good idea, correlating a job in the GUI to an entry in the yml file >>> was really a pain, so far. >>> >>>> [*] https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices >>>> >>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>>> --- >>>> .travis.yml | 101 ++++++++++++++++++++++++++++++++++------------------ >>>> 1 file changed, 67 insertions(+), 34 deletions(-) >>>> >>>> diff --git a/.travis.yml b/.travis.yml >>>> index 6c1038a0f1..d68e35a2c5 100644 >>>> --- a/.travis.yml >>>> +++ b/.travis.yml >>>> @@ -94,24 +94,28 @@ after_script: >>>> >>>> matrix: >>>> include: >>>> - - env: >>>> + - name: "[x86] GCC static (user)" >>> Could you please drop the [x86] and other architectures from the names? >>> Travis already lists the build architecture in the job status page, so >>> this information is redundant. >> Hmm for me the Travis page mis-renders the architecture (on firefox) so >> I do find the arch in the text fairly handy. > This might be a font problem, I can't see the architecture on neither > Firefox nor Chrome: > > https://pasteboard.co/IS3O358.png It is the partially hidden column between the job number and the penguin (or apple if MacOS). Funny, I can see the arch on Philippe's dashboard (https://travis-ci.org/philmd/qemu) but it disappears on my own (https://travis-ci.org/wainersm/qemu). Anyway, most of the jobs run on x86_64. So perhaps mark only the non-x86 ones? - Wainer > >
On 28/01/2020 14.33, Wainer dos Santos Moschetta wrote: > > On 1/28/20 11:18 AM, Philippe Mathieu-Daudé wrote: >> On Tue, Jan 28, 2020 at 1:55 PM Alex Bennée <alex.bennee@linaro.org> >> wrote: >>> Thomas Huth <thuth@redhat.com> writes: >>>> On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: >>>>> The NAME variable can be used to describe nicely a job (see [*]). >>>>> As we currently have 32 jobs, use it. This helps for quickly >>>>> finding a particular job. >>>>> >>>>> before: https://travis-ci.org/qemu/qemu/builds/639887646 >>>>> after: https://travis-ci.org/philmd/qemu/builds/641795043 >>>> Very good idea, correlating a job in the GUI to an entry in the yml >>>> file >>>> was really a pain, so far. >>>> >>>>> [*] >>>>> https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices >>>>> >>>>> >>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>>>> --- >>>>> .travis.yml | 101 >>>>> ++++++++++++++++++++++++++++++++++------------------ >>>>> 1 file changed, 67 insertions(+), 34 deletions(-) >>>>> >>>>> diff --git a/.travis.yml b/.travis.yml >>>>> index 6c1038a0f1..d68e35a2c5 100644 >>>>> --- a/.travis.yml >>>>> +++ b/.travis.yml >>>>> @@ -94,24 +94,28 @@ after_script: >>>>> >>>>> matrix: >>>>> include: >>>>> - - env: >>>>> + - name: "[x86] GCC static (user)" >>>> Could you please drop the [x86] and other architectures from the names? >>>> Travis already lists the build architecture in the job status page, so >>>> this information is redundant. >>> Hmm for me the Travis page mis-renders the architecture (on firefox) so >>> I do find the arch in the text fairly handy. >> This might be a font problem, I can't see the architecture on neither >> Firefox nor Chrome: >> >> https://pasteboard.co/IS3O358.png > > > It is the partially hidden column between the job number and the penguin > (or apple if MacOS). > > Funny, I can see the arch on Philippe's dashboard > (https://travis-ci.org/philmd/qemu) but it disappears on my own > (https://travis-ci.org/wainersm/qemu). I've never had problems here, for me the column shows up correctly everywhere. It looks like this: http://people.redhat.com/~thuth/travis.png > Anyway, most of the jobs run on x86_64. So perhaps mark only the non-x86 > ones? Sounds like a good compromise to me! Thomas
On 1/29/20 8:20 AM, Thomas Huth wrote: > On 28/01/2020 14.33, Wainer dos Santos Moschetta wrote: >> >> On 1/28/20 11:18 AM, Philippe Mathieu-Daudé wrote: >>> On Tue, Jan 28, 2020 at 1:55 PM Alex Bennée <alex.bennee@linaro.org> >>> wrote: >>>> Thomas Huth <thuth@redhat.com> writes: >>>>> On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: >>>>>> The NAME variable can be used to describe nicely a job (see [*]). >>>>>> As we currently have 32 jobs, use it. This helps for quickly >>>>>> finding a particular job. >>>>>> >>>>>> before: https://travis-ci.org/qemu/qemu/builds/639887646 >>>>>> after: https://travis-ci.org/philmd/qemu/builds/641795043 >>>>> Very good idea, correlating a job in the GUI to an entry in the yml >>>>> file >>>>> was really a pain, so far. >>>>> >>>>>> [*] >>>>>> https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices >>>>>> >>>>>> >>>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>>>>> --- >>>>>> .travis.yml | 101 >>>>>> ++++++++++++++++++++++++++++++++++------------------ >>>>>> 1 file changed, 67 insertions(+), 34 deletions(-) >>>>>> >>>>>> diff --git a/.travis.yml b/.travis.yml >>>>>> index 6c1038a0f1..d68e35a2c5 100644 >>>>>> --- a/.travis.yml >>>>>> +++ b/.travis.yml >>>>>> @@ -94,24 +94,28 @@ after_script: >>>>>> >>>>>> matrix: >>>>>> include: >>>>>> - - env: >>>>>> + - name: "[x86] GCC static (user)" >>>>> Could you please drop the [x86] and other architectures from the names? >>>>> Travis already lists the build architecture in the job status page, so >>>>> this information is redundant. >>>> Hmm for me the Travis page mis-renders the architecture (on firefox) so >>>> I do find the arch in the text fairly handy. >>> This might be a font problem, I can't see the architecture on neither >>> Firefox nor Chrome: >>> >>> https://pasteboard.co/IS3O358.png >> >> >> It is the partially hidden column between the job number and the penguin >> (or apple if MacOS). >> >> Funny, I can see the arch on Philippe's dashboard >> (https://travis-ci.org/philmd/qemu) but it disappears on my own >> (https://travis-ci.org/wainersm/qemu). > > I've never had problems here, for me the column shows up correctly > everywhere. It looks like this: > > http://people.redhat.com/~thuth/travis.png OK now I understand better your comment :) > >> Anyway, most of the jobs run on x86_64. So perhaps mark only the non-x86 >> ones? > > Sounds like a good compromise to me! I'd rather use one style, rather ARCH explicit on all, or not used at all.
On 28/01/2020 14.20, Wainer dos Santos Moschetta wrote: > > On 1/26/20 5:54 AM, Thomas Huth wrote: >> On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: >>> The NAME variable can be used to describe nicely a job (see [*]). >>> As we currently have 32 jobs, use it. This helps for quickly >>> finding a particular job. >>> >>> before: https://travis-ci.org/qemu/qemu/builds/639887646 >>> after: https://travis-ci.org/philmd/qemu/builds/641795043 >> Very good idea, correlating a job in the GUI to an entry in the yml file >> was really a pain, so far. >> >>> [*] >>> https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices >>> >>> >>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>> --- >>> .travis.yml | 101 ++++++++++++++++++++++++++++++++++------------------ >>> 1 file changed, 67 insertions(+), 34 deletions(-) >>> >>> diff --git a/.travis.yml b/.travis.yml >>> index 6c1038a0f1..d68e35a2c5 100644 >>> --- a/.travis.yml >>> +++ b/.travis.yml >>> @@ -94,24 +94,28 @@ after_script: >>> matrix: >>> include: >>> - - env: >>> + - name: "[x86] GCC static (user)" >> Could you please drop the [x86] and other architectures from the names? >> Travis already lists the build architecture in the job status page, so >> this information is redundant. >> >> [...] > > > I agree on dropping the architecture from the names, so: > > Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > > >>> # Alternate coroutines implementations are only really of >>> interest to KVM users >>> # However we can't test against KVM on Travis so we can only >>> run unit tests > > > Yet another off-topic comment: If we switch those coroutine test jobs to > Bionic then we can use KVM. Good idea, that's certainly worth a try once your KVM-enablement patch got included (or maybe you could also respin that patch with KVM enabled here, too?) Thomas
On 29/01/2020 08.27, Philippe Mathieu-Daudé wrote: > On 1/29/20 8:20 AM, Thomas Huth wrote: >> On 28/01/2020 14.33, Wainer dos Santos Moschetta wrote: >>> >>> On 1/28/20 11:18 AM, Philippe Mathieu-Daudé wrote: >>>> On Tue, Jan 28, 2020 at 1:55 PM Alex Bennée <alex.bennee@linaro.org> >>>> wrote: >>>>> Thomas Huth <thuth@redhat.com> writes: >>>>>> On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: >>>>>>> The NAME variable can be used to describe nicely a job (see [*]). >>>>>>> As we currently have 32 jobs, use it. This helps for quickly >>>>>>> finding a particular job. >>>>>>> >>>>>>> before: https://travis-ci.org/qemu/qemu/builds/639887646 >>>>>>> after: https://travis-ci.org/philmd/qemu/builds/641795043 >>>>>> Very good idea, correlating a job in the GUI to an entry in the yml >>>>>> file >>>>>> was really a pain, so far. >>>>>> >>>>>>> [*] >>>>>>> https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices >>>>>>> >>>>>>> >>>>>>> >>>>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>>>>>> --- >>>>>>> .travis.yml | 101 >>>>>>> ++++++++++++++++++++++++++++++++++------------------ >>>>>>> 1 file changed, 67 insertions(+), 34 deletions(-) >>>>>>> >>>>>>> diff --git a/.travis.yml b/.travis.yml >>>>>>> index 6c1038a0f1..d68e35a2c5 100644 >>>>>>> --- a/.travis.yml >>>>>>> +++ b/.travis.yml >>>>>>> @@ -94,24 +94,28 @@ after_script: >>>>>>> >>>>>>> matrix: >>>>>>> include: >>>>>>> - - env: >>>>>>> + - name: "[x86] GCC static (user)" >>>>>> Could you please drop the [x86] and other architectures from the >>>>>> names? >>>>>> Travis already lists the build architecture in the job status >>>>>> page, so >>>>>> this information is redundant. >>>>> Hmm for me the Travis page mis-renders the architecture (on >>>>> firefox) so >>>>> I do find the arch in the text fairly handy. >>>> This might be a font problem, I can't see the architecture on neither >>>> Firefox nor Chrome: >>>> >>>> https://pasteboard.co/IS3O358.png >>> >>> >>> It is the partially hidden column between the job number and the penguin >>> (or apple if MacOS). >>> >>> Funny, I can see the arch on Philippe's dashboard >>> (https://travis-ci.org/philmd/qemu) but it disappears on my own >>> (https://travis-ci.org/wainersm/qemu). >> >> I've never had problems here, for me the column shows up correctly >> everywhere. It looks like this: >> >> http://people.redhat.com/~thuth/travis.png > > OK now I understand better your comment :) > >> >>> Anyway, most of the jobs run on x86_64. So perhaps mark only the non-x86 >>> ones? >> >> Sounds like a good compromise to me! > > I'd rather use one style, rather ARCH explicit on all, or not used at all. Then I'd vote to drop it (if I've got a vote here at all ;-)), hoping that Travis fixes their HTML for that column, soon... Thomas
On 28/01/2020 13.55, Alex Bennée wrote: > > Thomas Huth <thuth@redhat.com> writes: > >> On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: >>> The NAME variable can be used to describe nicely a job (see [*]). >>> As we currently have 32 jobs, use it. This helps for quickly >>> finding a particular job. >>> >>> before: https://travis-ci.org/qemu/qemu/builds/639887646 >>> after: https://travis-ci.org/philmd/qemu/builds/641795043 >> >> Very good idea, correlating a job in the GUI to an entry in the yml file >> was really a pain, so far. >> >>> [*] https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices >>> >>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>> --- >>> .travis.yml | 101 ++++++++++++++++++++++++++++++++++------------------ >>> 1 file changed, 67 insertions(+), 34 deletions(-) >>> >>> diff --git a/.travis.yml b/.travis.yml >>> index 6c1038a0f1..d68e35a2c5 100644 >>> --- a/.travis.yml >>> +++ b/.travis.yml >>> @@ -94,24 +94,28 @@ after_script: >>> >>> matrix: >>> include: >>> - - env: >>> + - name: "[x86] GCC static (user)" >> >> Could you please drop the [x86] and other architectures from the names? >> Travis already lists the build architecture in the job status page, so >> this information is redundant. > > Hmm for me the Travis page mis-renders the architecture (on firefox) so > I do find the arch in the text fairly handy. That's really weird, I'm also using Firefox and it looks fine here! >>> # Alternate coroutines implementations are only really of interest to KVM users >>> # However we can't test against KVM on Travis so we can only run unit tests >>> - - env: >>> + - name: "[x86] check-unit coroutine=ucontext" >>> + env: >>> - CONFIG="--with-coroutine=ucontext --disable-tcg" >>> - TEST_CMD="make check-unit -j3 V=1" >>> >>> >>> - - env: >>> + - name: "[x86] check-unit coroutine=sigaltstack" >>> + env: >>> - CONFIG="--with-coroutine=sigaltstack --disable-tcg" >>> - TEST_CMD="make check-unit -j3 V=1" >>> >> >> Off-topic to your patch, but aren't coroutines something that is only >> used in the softmmu targets? If so, we could add --disable-user to the >> above two builds to speed things up a little bit. > > I think --disable-tcg implies --disable-user as you can't run without > it. D'oh, of course you're right, --disable-tcg limits the targets to *86-softmmu! Thomas
On 1/29/20 8:34 AM, Thomas Huth wrote: > On 29/01/2020 08.27, Philippe Mathieu-Daudé wrote: >> On 1/29/20 8:20 AM, Thomas Huth wrote: >>> On 28/01/2020 14.33, Wainer dos Santos Moschetta wrote: >>>> >>>> On 1/28/20 11:18 AM, Philippe Mathieu-Daudé wrote: >>>>> On Tue, Jan 28, 2020 at 1:55 PM Alex Bennée <alex.bennee@linaro.org> >>>>> wrote: >>>>>> Thomas Huth <thuth@redhat.com> writes: >>>>>>> On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: >>>>>>>> The NAME variable can be used to describe nicely a job (see [*]). >>>>>>>> As we currently have 32 jobs, use it. This helps for quickly >>>>>>>> finding a particular job. >>>>>>>> >>>>>>>> before: https://travis-ci.org/qemu/qemu/builds/639887646 >>>>>>>> after: https://travis-ci.org/philmd/qemu/builds/641795043 >>>>>>> Very good idea, correlating a job in the GUI to an entry in the yml >>>>>>> file >>>>>>> was really a pain, so far. >>>>>>> >>>>>>>> [*] >>>>>>>> https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>>>>>>> --- >>>>>>>> .travis.yml | 101 >>>>>>>> ++++++++++++++++++++++++++++++++++------------------ >>>>>>>> 1 file changed, 67 insertions(+), 34 deletions(-) >>>>>>>> >>>>>>>> diff --git a/.travis.yml b/.travis.yml >>>>>>>> index 6c1038a0f1..d68e35a2c5 100644 >>>>>>>> --- a/.travis.yml >>>>>>>> +++ b/.travis.yml >>>>>>>> @@ -94,24 +94,28 @@ after_script: >>>>>>>> >>>>>>>> matrix: >>>>>>>> include: >>>>>>>> - - env: >>>>>>>> + - name: "[x86] GCC static (user)" >>>>>>> Could you please drop the [x86] and other architectures from the >>>>>>> names? >>>>>>> Travis already lists the build architecture in the job status >>>>>>> page, so >>>>>>> this information is redundant. >>>>>> Hmm for me the Travis page mis-renders the architecture (on >>>>>> firefox) so >>>>>> I do find the arch in the text fairly handy. >>>>> This might be a font problem, I can't see the architecture on neither >>>>> Firefox nor Chrome: >>>>> >>>>> https://pasteboard.co/IS3O358.png >>>> >>>> >>>> It is the partially hidden column between the job number and the penguin >>>> (or apple if MacOS). >>>> >>>> Funny, I can see the arch on Philippe's dashboard >>>> (https://travis-ci.org/philmd/qemu) but it disappears on my own >>>> (https://travis-ci.org/wainersm/qemu). >>> >>> I've never had problems here, for me the column shows up correctly >>> everywhere. It looks like this: >>> >>> http://people.redhat.com/~thuth/travis.png >> >> OK now I understand better your comment :) >> >>> >>>> Anyway, most of the jobs run on x86_64. So perhaps mark only the non-x86 >>>> ones? >>> >>> Sounds like a good compromise to me! >> >> I'd rather use one style, rather ARCH explicit on all, or not used at all. > > Then I'd vote to drop it (if I've got a vote here at all ;-)), hoping > that Travis fixes their HTML for that column, soon... Fine. I opened issue https://github.com/travis-ci/travis-ci/issues/10503 which got closed, then I got lost in their forum. I'll simply hope instead.
diff --git a/.travis.yml b/.travis.yml index 6c1038a0f1..d68e35a2c5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -94,24 +94,28 @@ after_script: matrix: include: - - env: + - name: "[x86] GCC static (user)" + env: - CONFIG="--disable-system --static" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" # we split the system builds as it takes a while to build them all - - env: + - name: "[x86] GCC (main-softmmu)" + env: - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" - - env: - - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}" + - name: "[x86] GCC (other-softmmu)" + env: + - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" # Just build tools and run minimal unit and softfloat checks - - env: + - name: "[x86] GCC check-softfloat (user)" + env: - BASE_CONFIG="--enable-tools" - CONFIG="--disable-user --disable-system" - TEST_CMD="make check-unit check-softfloat -j3" @@ -119,41 +123,48 @@ matrix: # --enable-debug implies --enable-debug-tcg, also runs quite a bit slower - - env: + - name: "[x86] GCC debug (main-softmmu)" + env: - CONFIG="--enable-debug --target-list=${MAIN_SOFTMMU_TARGETS}" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug" # TCG debug can be run just on its own and is mostly agnostic to user/softmmu distinctions - - env: + - name: "[x86] GCC debug (user)" + env: - CONFIG="--enable-debug-tcg --disable-system" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg" - - env: + - name: "[x86] GCC some libs disabled (main-softmmu)" + env: - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}" # Module builds are mostly of interest to major distros - - env: + - name: "[x86] GCC modules (main-softmmu)" + env: - CONFIG="--enable-modules --target-list=${MAIN_SOFTMMU_TARGETS}" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" # Alternate coroutines implementations are only really of interest to KVM users # However we can't test against KVM on Travis so we can only run unit tests - - env: + - name: "[x86] check-unit coroutine=ucontext" + env: - CONFIG="--with-coroutine=ucontext --disable-tcg" - TEST_CMD="make check-unit -j3 V=1" - - env: + - name: "[x86] check-unit coroutine=sigaltstack" + env: - CONFIG="--with-coroutine=sigaltstack --disable-tcg" - TEST_CMD="make check-unit -j3 V=1" # Check we can build docs and tools (out of tree) - - env: + - name: "[x86] tools and docs" + env: - BUILD_DIR="out-of-tree/build/dir" SRC_DIR="../../.." - BASE_CONFIG="--enable-tools --enable-docs" - CONFIG="--target-list=x86_64-softmmu,aarch64-linux-user" @@ -167,13 +178,15 @@ matrix: # Test with Clang for compile portability (Travis uses clang-5.0) - - env: + - name: "[x86] Clang (user)" + env: - CONFIG="--disable-system" - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default" compiler: clang - - env: + - name: "[x86] Clang (main-softmmu)" + env: - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} " - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize" compiler: clang @@ -182,52 +195,60 @@ matrix: - ${SRC_DIR}/configure ${CONFIG} --extra-cflags="-fsanitize=undefined -Werror" || { cat config.log && exit 1; } - - env: + - name: "[x86] Clang (other-softmmu)" + env: - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}" - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default" compiler: clang # gprof/gcov are GCC features - - env: + - name: "[x86] GCC gprof/gcov" + env: - CONFIG="--enable-gprof --enable-gcov --disable-pie --target-list=${MAIN_SOFTMMU_TARGETS}" after_success: - ${SRC_DIR}/scripts/travis/coverage-summary.sh # We manually include builds which we disable "make check" for - - env: + - name: "[x86] GCC without-default-devices (softmmu)" + env: - CONFIG="--without-default-devices --disable-user" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" - TEST_CMD="" # Check the TCG interpreter (TCI) - - env: + - name: "[x86] GCC TCI" + env: - CONFIG="--enable-debug-tcg --enable-tcg-interpreter --disable-kvm --disable-containers --target-list=alpha-softmmu,arm-softmmu,hppa-softmmu,m68k-softmmu,microblaze-softmmu,moxie-softmmu,ppc-softmmu,s390x-softmmu,x86_64-softmmu" - TEST_CMD="make check-qtest check-tcg V=1" # We don't need to exercise every backend with every front-end - - env: + - name: "[x86] GCC trace log,simple,syslog (user)" + env: - CONFIG="--enable-trace-backends=log,simple,syslog --disable-system" - TEST_CMD="" - - env: + - name: "[x86] GCC trace ftrace (x86_64-softmmu)" + env: - CONFIG="--enable-trace-backends=ftrace --target-list=x86_64-softmmu" - TEST_CMD="" - - env: + - name: "[x86] GCC trace ust (x86_64-softmmu)" + env: - CONFIG="--enable-trace-backends=ust --target-list=x86_64-softmmu" - TEST_CMD="" # MacOSX builds - cirrus.yml also tests some MacOS builds including latest Xcode - - env: + - name: "[x86] OSX Xcode 10.3" + env: - CONFIG="--target-list=i386-softmmu,ppc-softmmu,ppc64-softmmu,m68k-softmmu,x86_64-softmmu" os: osx osx_image: xcode10.3 @@ -250,7 +271,8 @@ matrix: # Python builds - - env: + - name: "[x86] GCC Python 3.5 (x86_64-softmmu)" + env: - CONFIG="--target-list=x86_64-softmmu" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" language: python @@ -258,7 +280,8 @@ matrix: - "3.5" - - env: + - name: "[x86] GCC Python 3.6 (x86_64-softmmu)" + env: - CONFIG="--target-list=x86_64-softmmu" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" language: python @@ -267,7 +290,8 @@ matrix: # Acceptance (Functional) tests - - env: + - name: "[x86] GCC check-acceptance" + env: - CONFIG="--python=/usr/bin/python3 --target-list=x86_64-softmmu,mips-softmmu,mips64el-softmmu,aarch64-softmmu,arm-softmmu,s390x-softmmu,alpha-softmmu,ppc-softmmu,ppc64-softmmu,m68k-softmmu,sparc-softmmu" - TEST_CMD="make check-acceptance" after_script: @@ -283,7 +307,8 @@ matrix: # Using newer GCC with sanitizers - - addons: + - name: "[x86] GCC9 with sanitizers (softmmu)" + addons: apt: update: true sources: @@ -331,7 +356,8 @@ matrix: # Run check-tcg against linux-user - - env: + - name: "[x86] GCC check-tcg (user)" + env: - CONFIG="--disable-system --enable-debug-tcg" - TEST_CMD="make -j3 check-tcg V=1" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg" @@ -339,26 +365,30 @@ matrix: # Run check-tcg against linux-user (with plugins) # we skip sparc64-linux-user until it has been fixed somewhat - - env: + - name: "[x86] GCC plugins check-tcg (user)" + env: - CONFIG="--disable-system --enable-plugins --enable-debug-tcg --target-list-exclude=sparc64-linux-user" - TEST_CMD="make -j3 check-tcg V=1" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg" # Run check-tcg against softmmu targets - - env: + - name: "[x86] GCC check-tcg (some-softmmu)" + env: - CONFIG="--enable-debug-tcg --target-list=xtensa-softmmu,arm-softmmu,aarch64-softmmu,alpha-softmmu" - TEST_CMD="make -j3 check-tcg V=1" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg" # Run check-tcg against softmmu targets (with plugins) - - env: + - name: "[x86] GCC plugins check-tcg (some-softmmu)" + env: - CONFIG="--enable-plugins --enable-debug-tcg --target-list=xtensa-softmmu,arm-softmmu,aarch64-softmmu,alpha-softmmu" - TEST_CMD="make -j3 check-tcg V=1" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg" - - arch: arm64 + - name: "[aarch64] GCC check-tcg" + arch: arm64 dist: xenial addons: apt_packages: @@ -387,7 +417,8 @@ matrix: - TEST_CMD="make check check-tcg V=1" - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS}" - - arch: ppc64le + - name: "[ppc64] GCC check-tcg" + arch: ppc64le dist: xenial addons: apt_packages: @@ -416,7 +447,8 @@ matrix: - TEST_CMD="make check check-tcg V=1" - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user" - - arch: s390x + - name: "[s390x] GCC check-tcg" + arch: s390x dist: bionic addons: apt_packages: @@ -448,7 +480,8 @@ matrix: # Release builds # The make-release script expect a QEMU version, so our tag must start with a 'v'. # This is the case when release candidate tags are created. - - if: tag IS present AND tag =~ /^v\d+\.\d+(\.\d+)?(-\S*)?$/ + - name: "Release tarball" + if: tag IS present AND tag =~ /^v\d+\.\d+(\.\d+)?(-\S*)?$/ env: # We want to build from the release tarball - BUILD_DIR="release/build/dir" SRC_DIR="../../.."
The NAME variable can be used to describe nicely a job (see [*]). As we currently have 32 jobs, use it. This helps for quickly finding a particular job. before: https://travis-ci.org/qemu/qemu/builds/639887646 after: https://travis-ci.org/philmd/qemu/builds/641795043 [*] https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- .travis.yml | 101 ++++++++++++++++++++++++++++++++++------------------ 1 file changed, 67 insertions(+), 34 deletions(-)