Message ID | 1580456335-7317-2-git-send-email-gubbaven@codeaurora.org (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Marcel Holtmann |
Headers | show |
Series | [v2,1/2] Bluetooth: hci_qca: Enable clocks required for BT SOC | expand |
+ DT folks On Fri, Jan 31, 2020 at 01:08:55PM +0530, Venkata Lakshmi Narayana Gubba wrote: > Add compatible string for the Qualcomm WCN3991 Bluetooth controller > > Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org> > --- > Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > index 68b67d9..e72045d 100644 > --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > @@ -11,6 +11,7 @@ Required properties: > - compatible: should contain one of the following: > * "qcom,qca6174-bt" > * "qcom,wcn3990-bt" > + * "qcom,wcn3991-bt" > * "qcom,wcn3998-bt" > > Optional properties for compatible string qcom,qca6174-bt: > @@ -30,6 +31,7 @@ Optional properties for compatible string qcom,wcn399x-bt: > > - max-speed: see Documentation/devicetree/bindings/serial/slave-device.txt > - firmware-name: specify the name of nvm firmware to load > + - clocks: clock provided to the controller > > Examples: > > @@ -56,5 +58,6 @@ serial@898000 { > vddch0-supply = <&vreg_l25a_3p3>; > max-speed = <3200000>; > firmware-name = "crnv21.bin"; > + clocks = <&rpmhcc>; That specifies a clock controller, not a clock. For a device with the SC7180 SoC we use this: clocks = <&rpmhcc RPMH_RF_CLK2>; > }; > };
Hi Matthias, On 2020-02-01 04:06, Matthias Kaehlcke wrote: > + DT folks > > On Fri, Jan 31, 2020 at 01:08:55PM +0530, Venkata Lakshmi Narayana > Gubba wrote: >> Add compatible string for the Qualcomm WCN3991 Bluetooth controller >> >> Signed-off-by: Venkata Lakshmi Narayana Gubba >> <gubbaven@codeaurora.org> >> --- >> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >> index 68b67d9..e72045d 100644 >> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt >> @@ -11,6 +11,7 @@ Required properties: >> - compatible: should contain one of the following: >> * "qcom,qca6174-bt" >> * "qcom,wcn3990-bt" >> + * "qcom,wcn3991-bt" >> * "qcom,wcn3998-bt" >> >> Optional properties for compatible string qcom,qca6174-bt: >> @@ -30,6 +31,7 @@ Optional properties for compatible string >> qcom,wcn399x-bt: >> >> - max-speed: see >> Documentation/devicetree/bindings/serial/slave-device.txt >> - firmware-name: specify the name of nvm firmware to load >> + - clocks: clock provided to the controller >> >> Examples: >> >> @@ -56,5 +58,6 @@ serial@898000 { >> vddch0-supply = <&vreg_l25a_3p3>; >> max-speed = <3200000>; >> firmware-name = "crnv21.bin"; >> + clocks = <&rpmhcc>; > > That specifies a clock controller, not a clock. > > For a device with the SC7180 SoC we use this: > > clocks = <&rpmhcc RPMH_RF_CLK2>; [Venkata] : Sure, we will update in next patch set. > >> }; >> }; Regards, Venkata.
diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt index 68b67d9..e72045d 100644 --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt @@ -11,6 +11,7 @@ Required properties: - compatible: should contain one of the following: * "qcom,qca6174-bt" * "qcom,wcn3990-bt" + * "qcom,wcn3991-bt" * "qcom,wcn3998-bt" Optional properties for compatible string qcom,qca6174-bt: @@ -30,6 +31,7 @@ Optional properties for compatible string qcom,wcn399x-bt: - max-speed: see Documentation/devicetree/bindings/serial/slave-device.txt - firmware-name: specify the name of nvm firmware to load + - clocks: clock provided to the controller Examples: @@ -56,5 +58,6 @@ serial@898000 { vddch0-supply = <&vreg_l25a_3p3>; max-speed = <3200000>; firmware-name = "crnv21.bin"; + clocks = <&rpmhcc>; }; };
Add compatible string for the Qualcomm WCN3991 Bluetooth controller Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org> --- Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 3 +++ 1 file changed, 3 insertions(+)