| Message ID | 1580305919-30946-5-git-send-email-sanm@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add QUSB2 PHY support for SC7180 | expand |
On Wed, Jan 29, 2020 at 07:21:55PM +0530, Sandeep Maheswaram wrote: > Add support for overriding QUSB2 V2 phy tuning parameters > in device tree bindings. > > Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > index 43082c8..dfef356 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > @@ -80,6 +80,28 @@ properties: > maximum: 63 > default: 0 > > + qcom,bias-ctrl-value: > + description: > + It is a 6 bit value that specifies bias-ctrl-value. It is a PHY > + tuning parameter that may vary for different boards of same SOC. > + This property is applicable to only QUSB2 v2 PHY. As commented on 'dt-bindings: phy: qcom,qusb2: Convert QUSB2 phy bindings to yaml' a possible improvement could be to restrict these properties to the QUSB2 v2 PHY through the schema. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 0 > + maximum: 63 > + default: 0 > + > + qcom,charge-ctrl-value: > + description: > + It is a 2 bit value that specifies charge-ctrl-value. It is a PHY > + tuning parameter that may vary for different boards of same SOC. > + This property is applicable to only QUSB2 v2 PHY. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 0 > + maximum: 3 > + default: 0 > + > qcom,hstx-trim-value: > description: > It is a 4 bit value that specifies tuning for HSTX > @@ -118,6 +140,17 @@ properties: > maximum: 1 > default: 0 > > + qcom,hsdisc-trim-value: > + description: > + It is a 2 bit value tuning parameter that control disconnect > + threshold and may vary for different boards of same SOC. > + This property is applicable to only QUSB2 v2 PHY. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - minimum: 0 > + maximum: 3 > + default: 0 > + > required: > - compatible > - reg Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Quoting Matthias Kaehlcke (2020-01-29 12:38:19) > On Wed, Jan 29, 2020 at 07:21:55PM +0530, Sandeep Maheswaram wrote: > > Add support for overriding QUSB2 V2 phy tuning parameters > > in device tree bindings. > > > > Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 33 ++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > > index 43082c8..dfef356 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > > @@ -80,6 +80,28 @@ properties: > > maximum: 63 > > default: 0 > > > > + qcom,bias-ctrl-value: > > + description: > > + It is a 6 bit value that specifies bias-ctrl-value. It is a PHY > > + tuning parameter that may vary for different boards of same SOC. > > + This property is applicable to only QUSB2 v2 PHY. > > As commented on 'dt-bindings: phy: qcom,qusb2: Convert QUSB2 phy bindings > to yaml' a possible improvement could be to restrict these properties to > the QUSB2 v2 PHY through the schema. Can this be done? It's nice to keep constraints type, otherwise the yaml binding is not as useful.
diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml index 43082c8..dfef356 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml @@ -80,6 +80,28 @@ properties: maximum: 63 default: 0 + qcom,bias-ctrl-value: + description: + It is a 6 bit value that specifies bias-ctrl-value. It is a PHY + tuning parameter that may vary for different boards of same SOC. + This property is applicable to only QUSB2 v2 PHY. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - minimum: 0 + maximum: 63 + default: 0 + + qcom,charge-ctrl-value: + description: + It is a 2 bit value that specifies charge-ctrl-value. It is a PHY + tuning parameter that may vary for different boards of same SOC. + This property is applicable to only QUSB2 v2 PHY. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - minimum: 0 + maximum: 3 + default: 0 + qcom,hstx-trim-value: description: It is a 4 bit value that specifies tuning for HSTX @@ -118,6 +140,17 @@ properties: maximum: 1 default: 0 + qcom,hsdisc-trim-value: + description: + It is a 2 bit value tuning parameter that control disconnect + threshold and may vary for different boards of same SOC. + This property is applicable to only QUSB2 v2 PHY. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - minimum: 0 + maximum: 3 + default: 0 + required: - compatible - reg