| Message ID | 20200204154803.25403-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Fix the docs for intel_set_cdclk_post_plane_update() | expand |
On Tue, 2020-02-04 at 17:48 +0200, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > s/before/after/ again after accidentally changing it the > other way in commit 5604e9ceaed5 ("drm/i915: Simplify > intel_set_cdclk_{pre,post}_plane_update() calling convention") > > Cc: José Roberto de Souza <jose.souza@intel.com> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c > b/drivers/gpu/drm/i915/display/intel_cdclk.c > index 7154a2288310..3ad5f36447e9 100644 > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > @@ -1895,7 +1895,7 @@ intel_set_cdclk_pre_plane_update(struct > intel_atomic_state *state) > * intel_set_cdclk_post_plane_update - Push the CDCLK state to the > hardware > * @state: intel atomic state > * > - * Program the hardware before updating the HW plane state based on > the > + * Program the hardware after updating the HW plane state based on > the > * new CDCLK state, if necessary. But the HW plane state will be updated later in dev_priv- >display.commit_modeset_enables(). > */ > void
On Tue, Feb 04, 2020 at 06:18:09PM +0000, Souza, Jose wrote: > On Tue, 2020-02-04 at 17:48 +0200, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > s/before/after/ again after accidentally changing it the > > other way in commit 5604e9ceaed5 ("drm/i915: Simplify > > intel_set_cdclk_{pre,post}_plane_update() calling convention") > > > > Cc: José Roberto de Souza <jose.souza@intel.com> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c > > b/drivers/gpu/drm/i915/display/intel_cdclk.c > > index 7154a2288310..3ad5f36447e9 100644 > > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > > @@ -1895,7 +1895,7 @@ intel_set_cdclk_pre_plane_update(struct > > intel_atomic_state *state) > > * intel_set_cdclk_post_plane_update - Push the CDCLK state to the > > hardware > > * @state: intel atomic state > > * > > - * Program the hardware before updating the HW plane state based on > > the > > + * Program the hardware after updating the HW plane state based on > > the > > * new CDCLK state, if necessary. > > But the HW plane state will be updated later in dev_priv- > >display.commit_modeset_enables(). That comes before intel_set_cdclk_post_plane_update(). > > > */ > > void
On Tue, 2020-02-04 at 22:26 +0200, Ville Syrjälä wrote: > On Tue, Feb 04, 2020 at 06:18:09PM +0000, Souza, Jose wrote: > > On Tue, 2020-02-04 at 17:48 +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > > > s/before/after/ again after accidentally changing it the > > > other way in commit 5604e9ceaed5 ("drm/i915: Simplify > > > intel_set_cdclk_{pre,post}_plane_update() calling convention") > > > > > > Cc: José Roberto de Souza <jose.souza@intel.com> > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > --- > > > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c > > > b/drivers/gpu/drm/i915/display/intel_cdclk.c > > > index 7154a2288310..3ad5f36447e9 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > > > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > > > @@ -1895,7 +1895,7 @@ intel_set_cdclk_pre_plane_update(struct > > > intel_atomic_state *state) > > > * intel_set_cdclk_post_plane_update - Push the CDCLK state to > > > the > > > hardware > > > * @state: intel atomic state > > > * > > > - * Program the hardware before updating the HW plane state based > > > on > > > the > > > + * Program the hardware after updating the HW plane state based > > > on > > > the > > > * new CDCLK state, if necessary. > > > > But the HW plane state will be updated later in dev_priv- > > > display.commit_modeset_enables(). > > That comes before intel_set_cdclk_post_plane_update(). Git diff fooled me. "@@ -1895,7 +1895,7 @@ intel_set_cdclk_pre_plane_update(struct intel_atomic_state *state)" Reviewed-by: José Roberto de Souza <jose.souza@intel.com> > > > > */ > > > void
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index 7154a2288310..3ad5f36447e9 100644 --- a/drivers/gpu/drm/i915/display/intel_cdclk.c +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c @@ -1895,7 +1895,7 @@ intel_set_cdclk_pre_plane_update(struct intel_atomic_state *state) * intel_set_cdclk_post_plane_update - Push the CDCLK state to the hardware * @state: intel atomic state * - * Program the hardware before updating the HW plane state based on the + * Program the hardware after updating the HW plane state based on the * new CDCLK state, if necessary. */ void