[v1,0/7] platform/x86: intel_pmc_core: Add debugfs entries

Message

Kammela, Gayatri Jan. 24, 2020, 6:50 p.m. UTC

Hi,

Tiger Lake platform supports 8 sub-states/low power modes of S0ix. Add
debugfs entries to pmc_core driver to access low power mode registers
and residencies.

Patch 1: Add debugfs entry to access sub-state residencies
Patch 2: Add debugfs entry for low power mode status registers
Patch 3: Refactor the driver by removing redundant code
Patch 4: Remove slp_s0 attributes from tgl_reg_map
Patch 5: Add an additional parameter to pmc_core_lpm_display_map()
Patch 6: Dump low power status registers on an S0ix.y failure
Patch 7: Add debugfs support to access live status registers

Gayatri Kammela (7):
  platform/x86: intel_pmc_core: Add debugfs entry to access sub-state
    residencies
  platform/x86: intel_pmc_core: Add debugfs entry for low power mode
    status registers
  platform/x86: intel_pmc_core: Refactor the driver by removing
    redundant code
  platform/x86: intel_pmc_core: Remove slp_s0 attributes from
    tgl_reg_map
  platform/x86: intel_pmc_core: Add an additional parameter to
    pmc_core_lpm_display()
  platform/x86: intel_pmc_core: Dump low power status registers on an
    S0ix.y failure
  platform/x86: intel_pmc_core: Add debugfs support to access live
    status registers

 drivers/platform/x86/intel_pmc_core.c | 301 +++++++++++++++++++++++---
 drivers/platform/x86/intel_pmc_core.h |  28 +++
 2 files changed, 302 insertions(+), 27 deletions(-)

Cc: Srinivas Pandruvada <[e-mail]>
Cc: Andy Shevchenko <[e-mail]>
Cc: David Box <[e-mail]>

Comments

Andy Shevchenko Jan. 27, 2020, 10:49 a.m. UTC | #1

On Fri, Jan 24, 2020 at 10:59 PM Gayatri Kammela
<[e-mail]> wrote:
>
> Hi,
>
> Tiger Lake platform supports 8 sub-states/low power modes of S0ix. Add
> debugfs entries to pmc_core driver to access low power mode registers
> and residencies.
>
> Patch 1: Add debugfs entry to access sub-state residencies
> Patch 2: Add debugfs entry for low power mode status registers
> Patch 3: Refactor the driver by removing redundant code
> Patch 4: Remove slp_s0 attributes from tgl_reg_map
> Patch 5: Add an additional parameter to pmc_core_lpm_display_map()
> Patch 6: Dump low power status registers on an S0ix.y failure
> Patch 7: Add debugfs support to access live status registers

It doesn't apply to our for-next branch.

>
> Gayatri Kammela (7):
>   platform/x86: intel_pmc_core: Add debugfs entry to access sub-state
>     residencies
>   platform/x86: intel_pmc_core: Add debugfs entry for low power mode
>     status registers
>   platform/x86: intel_pmc_core: Refactor the driver by removing
>     redundant code
>   platform/x86: intel_pmc_core: Remove slp_s0 attributes from
>     tgl_reg_map
>   platform/x86: intel_pmc_core: Add an additional parameter to
>     pmc_core_lpm_display()
>   platform/x86: intel_pmc_core: Dump low power status registers on an
>     S0ix.y failure
>   platform/x86: intel_pmc_core: Add debugfs support to access live
>     status registers
>
>  drivers/platform/x86/intel_pmc_core.c | 301 +++++++++++++++++++++++---
>  drivers/platform/x86/intel_pmc_core.h |  28 +++
>  2 files changed, 302 insertions(+), 27 deletions(-)
>
> Cc: Srinivas Pandruvada <[e-mail]>
> Cc: Andy Shevchenko <[e-mail]>
> Cc: David Box <[e-mail]>
> --
> 2.17.1
>

Kammela, Gayatri Jan. 27, 2020, 6:02 p.m. UTC | #2

> -----Original Message-----
> From: Andy Shevchenko <[e-mail]>
> Sent: Monday, January 27, 2020 2:49 AM
> To: Kammela, Gayatri <[e-mail]>
> Cc: Platform Driver <[e-mail]>; Linux Kernel
> Mailing List <[e-mail]>; Somayaji, Vishwanath
> <[e-mail]>; Darren Hart <[e-mail]>;
> Westerberg, Mika <[e-mail]>; Peter Zijlstra (Intel)
> <[e-mail]>; Prestopine, Charles D
> <[e-mail]>; Pandruvada, Srinivas
> <[e-mail]>; Andy Shevchenko
> <[e-mail]>; Box, David E
> <[e-mail]>
> Subject: Re: [PATCH v1 0/7] platform/x86: intel_pmc_core: Add debugfs
> entries
> 
> On Fri, Jan 24, 2020 at 10:59 PM Gayatri Kammela
> <[e-mail]> wrote:
> >
> > Hi,
> >
> > Tiger Lake platform supports 8 sub-states/low power modes of S0ix. Add
> > debugfs entries to pmc_core driver to access low power mode registers
> > and residencies.
> >
> > Patch 1: Add debugfs entry to access sub-state residencies Patch 2:
> > Add debugfs entry for low power mode status registers Patch 3:
> > Refactor the driver by removing redundant code Patch 4: Remove slp_s0
> > attributes from tgl_reg_map Patch 5: Add an additional parameter to
> > pmc_core_lpm_display_map() Patch 6: Dump low power status registers on
> > an S0ix.y failure Patch 7: Add debugfs support to access live status
> > registers
> 
> It doesn't apply to our for-next branch.
Sorry to hear that. I've rebased the series on mainline 5.5-rc7. Should I rebase it on for-next branch?
> 
> >
> > Gayatri Kammela (7):
> >   platform/x86: intel_pmc_core: Add debugfs entry to access sub-state
> >     residencies
> >   platform/x86: intel_pmc_core: Add debugfs entry for low power mode
> >     status registers
> >   platform/x86: intel_pmc_core: Refactor the driver by removing
> >     redundant code
> >   platform/x86: intel_pmc_core: Remove slp_s0 attributes from
> >     tgl_reg_map
> >   platform/x86: intel_pmc_core: Add an additional parameter to
> >     pmc_core_lpm_display()
> >   platform/x86: intel_pmc_core: Dump low power status registers on an
> >     S0ix.y failure
> >   platform/x86: intel_pmc_core: Add debugfs support to access live
> >     status registers
> >
> >  drivers/platform/x86/intel_pmc_core.c | 301
> > +++++++++++++++++++++++---  drivers/platform/x86/intel_pmc_core.h |
> > 28 +++
> >  2 files changed, 302 insertions(+), 27 deletions(-)
> >
> > Cc: Srinivas Pandruvada <[e-mail]>
> > Cc: Andy Shevchenko <[e-mail]>
> > Cc: David Box <[e-mail]>
> > --
> > 2.17.1
> >
> 
> 
> --
> With Best Regards,
> Andy Shevchenko

Andy Shevchenko Jan. 27, 2020, 6:59 p.m. UTC | #3

On Mon, Jan 27, 2020 at 8:03 PM Kammela, Gayatri
<[e-mail]> wrote:

> > It doesn't apply to our for-next branch.
> Sorry to hear that. I've rebased the series on mainline 5.5-rc7. Should I rebase it on for-next branch?

You should always base your branch on the for-next (whatever it's
being called) of the subsystem your series against of.

Kammela, Gayatri Feb. 4, 2020, 4 a.m. UTC | #4

> -----Original Message-----
> From: Andy Shevchenko <[e-mail]>
> Sent: Monday, January 27, 2020 11:00 AM
> To: Kammela, Gayatri <[e-mail]>
> Cc: Platform Driver <[e-mail]>; Linux Kernel
> Mailing List <[e-mail]>; Somayaji, Vishwanath
> <[e-mail]>; Darren Hart <[e-mail]>;
> Westerberg, Mika <[e-mail]>; Peter Zijlstra (Intel)
> <[e-mail]>; Prestopine, Charles D
> <[e-mail]>; Pandruvada, Srinivas
> <[e-mail]>; Andy Shevchenko
> <[e-mail]>; Box, David E
> <[e-mail]>
> Subject: Re: [PATCH v1 0/7] platform/x86: intel_pmc_core: Add debugfs
> entries
> 
> On Mon, Jan 27, 2020 at 8:03 PM Kammela, Gayatri
> <[e-mail]> wrote:
> 
> > > It doesn't apply to our for-next branch.
> > Sorry to hear that. I've rebased the series on mainline 5.5-rc7. Should I
> rebase it on for-next branch?
> 
> You should always base your branch on the for-next (whatever it's being
> called) of the subsystem your series against of.

Hi Andy,

The current series has a dependency on Tiger Lake and Elkhart Lake patche which is merged in to mainline. 

(554f269f0f38 platform/x86: intel_pmc_core: Add Intel Elkhart Lake support
49a437941c3f platform/x86: intel_pmc_core: Add Intel Tiger Lake support
6268c0b278b5 platform/x86: intel_pmc_core: Make debugfs entry for pch_ip_power_gating_status conditional
e39854781830 platform/x86: intel_pmc_core: Create platform dependent bitmap structs
b1cb33dae414 platform/x86: intel_pmc_core: Clean up: Remove comma after the termination line)

But they are not available in for-next branch. I am confused, how that could be the case. For me to base the current series on for-next branch, the dependency patch series should be available in for-next branch.

> 
> --
> With Best Regards,
> Andy Shevchenko

Andy Shevchenko Feb. 4, 2020, 11:34 a.m. UTC | #5

On Tue, Feb 04, 2020 at 04:00:43AM +0000, Kammela, Gayatri wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <[e-mail]>
> > Sent: Monday, January 27, 2020 11:00 AM
> > To: Kammela, Gayatri <[e-mail]>
> > Cc: Platform Driver <[e-mail]>; Linux Kernel
> > Mailing List <[e-mail]>; Somayaji, Vishwanath
> > <[e-mail]>; Darren Hart <[e-mail]>;
> > Westerberg, Mika <[e-mail]>; Peter Zijlstra (Intel)
> > <[e-mail]>; Prestopine, Charles D
> > <[e-mail]>; Pandruvada, Srinivas
> > <[e-mail]>; Andy Shevchenko
> > <[e-mail]>; Box, David E
> > <[e-mail]>
> > Subject: Re: [PATCH v1 0/7] platform/x86: intel_pmc_core: Add debugfs
> > entries
> > 
> > On Mon, Jan 27, 2020 at 8:03 PM Kammela, Gayatri
> > <[e-mail]> wrote:
> > 
> > > > It doesn't apply to our for-next branch.
> > > Sorry to hear that. I've rebased the series on mainline 5.5-rc7. Should I
> > rebase it on for-next branch?
> > 
> > You should always base your branch on the for-next (whatever it's being
> > called) of the subsystem your series against of.
> 
> Hi Andy,
> 
> The current series has a dependency on Tiger Lake and Elkhart Lake patche which is merged in to mainline. 
> 
> (554f269f0f38 platform/x86: intel_pmc_core: Add Intel Elkhart Lake support
> 49a437941c3f platform/x86: intel_pmc_core: Add Intel Tiger Lake support
> 6268c0b278b5 platform/x86: intel_pmc_core: Make debugfs entry for pch_ip_power_gating_status conditional
> e39854781830 platform/x86: intel_pmc_core: Create platform dependent bitmap structs
> b1cb33dae414 platform/x86: intel_pmc_core: Clean up: Remove comma after the termination line)
> 
> But they are not available in for-next branch. I am confused, how that could be the case. For me to base the current series on for-next branch, the dependency patch series should be available in for-next branch.

I'm wondering how did you check it?
The branch location is in this [1] tree.

[1]: http://git.infradead.org/linux-platform-drivers-x86.git

Kammela, Gayatri Feb. 4, 2020, 11:10 p.m. UTC | #6

> > > > > It doesn't apply to our for-next branch.
> > > > Sorry to hear that. I've rebased the series on mainline 5.5-rc7.
> > > > Should I
> > > rebase it on for-next branch?
> > >
> > > You should always base your branch on the for-next (whatever it's
> > > being
> > > called) of the subsystem your series against of.
> >
> > Hi Andy,
> >
> > The current series has a dependency on Tiger Lake and Elkhart Lake patche
> which is merged in to mainline.
> >
> > (554f269f0f38 platform/x86: intel_pmc_core: Add Intel Elkhart Lake
> > support 49a437941c3f platform/x86: intel_pmc_core: Add Intel Tiger
> > Lake support
> > 6268c0b278b5 platform/x86: intel_pmc_core: Make debugfs entry for
> > pch_ip_power_gating_status conditional
> > e39854781830 platform/x86: intel_pmc_core: Create platform dependent
> > bitmap structs
> > b1cb33dae414 platform/x86: intel_pmc_core: Clean up: Remove comma
> > after the termination line)
> >
> > But they are not available in for-next branch. I am confused, how that could
> be the case. For me to base the current series on for-next branch, the
> dependency patch series should be available in for-next branch.
> 
> I'm wondering how did you check it?
> The branch location is in this [1] tree.

Thank you for your patience Andy. I apologize for the mishap as I was checking in the wrong tree. I have rebased the series on for-next branch on right tree this time and sent v2.

> 
> [1]: http://git.infradead.org/linux-platform-drivers-x86.git
> 
> --
> With Best Regards,
> Andy Shevchenko
>

Andy Shevchenko Feb. 5, 2020, 9:08 a.m. UTC | #7

On Wed, Feb 5, 2020 at 1:11 AM Kammela, Gayatri
<[e-mail]> wrote:

...

> > I'm wondering how did you check it?
> > The branch location is in this [1] tree.
>
> Thank you for your patience Andy. I apologize for the mishap as I was checking in the wrong tree. I have rebased the series on for-next branch on right tree this time and sent v2.

No worries, thanks for the update!

> > [1]: http://git.infradead.org/linux-platform-drivers-x86.git