| Message ID | 20200123064525.6935-1-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/bt: Remove empty Kconfig file | expand |
Le 23/01/2020 à 07:45, Thomas Huth a écrit : > While removing the bluetooth code some weeks ago, I had to leave the > hw/bt/Kconfig file around. Otherwise some of the builds would have been > broken since the generated dependency files tried to include it before > they were rebuilt. Meanwhile, all those dependency files should have > been updated, so we can remove the empty Kconfig file now, too. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > hw/bt/Kconfig | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > delete mode 100644 hw/bt/Kconfig > > diff --git a/hw/bt/Kconfig b/hw/bt/Kconfig > deleted file mode 100644 > index e69de29bb2..0000000000 > Reviewed-by: Laurent Vivier <laurent@vivier.Eu> Applied to my trivial-patches branch. Thanks, Laurent
On Thu, 23 Jan 2020 at 06:46, Thomas Huth <thuth@redhat.com> wrote: > > While removing the bluetooth code some weeks ago, I had to leave the > hw/bt/Kconfig file around. Otherwise some of the builds would have been > broken since the generated dependency files tried to include it before > they were rebuilt. Meanwhile, all those dependency files should have > been updated, so we can remove the empty Kconfig file now, too. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- I ran this through my usual buildtests and they were all fine. Tested-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
On 06/02/2020 12.38, Peter Maydell wrote: > On Thu, 23 Jan 2020 at 06:46, Thomas Huth <thuth@redhat.com> wrote: >> >> While removing the bluetooth code some weeks ago, I had to leave the >> hw/bt/Kconfig file around. Otherwise some of the builds would have been >> broken since the generated dependency files tried to include it before >> they were rebuilt. Meanwhile, all those dependency files should have >> been updated, so we can remove the empty Kconfig file now, too. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> >> --- > > I ran this through my usual buildtests and they were all fine. Finally! :-) > Tested-by: Peter Maydell <peter.maydell@linaro.org> Great, thanks for testing it again, Peter! Thomas
diff --git a/hw/bt/Kconfig b/hw/bt/Kconfig deleted file mode 100644 index e69de29bb2..0000000000
While removing the bluetooth code some weeks ago, I had to leave the hw/bt/Kconfig file around. Otherwise some of the builds would have been broken since the generated dependency files tried to include it before they were rebuilt. Meanwhile, all those dependency files should have been updated, so we can remove the empty Kconfig file now, too. Signed-off-by: Thomas Huth <thuth@redhat.com> --- hw/bt/Kconfig | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 hw/bt/Kconfig