| Message ID | 1580997328-16365-2-git-send-email-kgunda@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V3,1/2] mfd: qcom-spmi-pmic: Convert bindings to .yaml format | expand |
Quoting Kiran Gunda (2020-02-06 05:55:27) > Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs > found on SC7180 based platforms > > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++ > drivers/mfd/qcom-spmi-pmic.c | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > index affc169..36f0795 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > @@ -46,6 +46,8 @@ properties: > - qcom,pm8998 > - qcom,pmi8998 > - qcom,pm8005 > + - qcom,pm6150 > + - qcom,pm6150l > - qcom,spmi-pmic Maybe the yaml binding needs to say this is sorted in subtype id in a comment. # Sorted based on subtype ID the device reports Or we should sort this list in the binding and sort the compatible string table in the driver with a comment that it's sorted based on subtype id. > > reg: > diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c > index 1df1a27..5bfeec8 100644 > --- a/drivers/mfd/qcom-spmi-pmic.c > +++ b/drivers/mfd/qcom-spmi-pmic.c > @@ -36,6 +36,8 @@ > #define PM8998_SUBTYPE 0x14 > #define PMI8998_SUBTYPE 0x15 > #define PM8005_SUBTYPE 0x18 > +#define PM6150L_SUBTYPE 0x1F > +#define PM6150_SUBTYPE 0x28 > > static const struct of_device_id pmic_spmi_id_table[] = { > { .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE }, > @@ -57,6 +59,8 @@ static const struct of_device_id pmic_spmi_id_table[] = { > { .compatible = "qcom,pm8998", .data = (void *)PM8998_SUBTYPE }, > { .compatible = "qcom,pmi8998", .data = (void *)PMI8998_SUBTYPE }, > { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE }, > + { .compatible = "qcom,pm6150l", .data = (void *)PM6150L_SUBTYPE }, > + { .compatible = "qcom,pm6150", .data = (void *)PM6150_SUBTYPE }, > { } > };
On 2020-02-07 00:38, Stephen Boyd wrote: > Quoting Kiran Gunda (2020-02-06 05:55:27) >> Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs >> found on SC7180 based platforms >> >> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> >> --- >> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++ >> drivers/mfd/qcom-spmi-pmic.c | 4 ++++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> index affc169..36f0795 100644 >> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> @@ -46,6 +46,8 @@ properties: >> - qcom,pm8998 >> - qcom,pmi8998 >> - qcom,pm8005 >> + - qcom,pm6150 >> + - qcom,pm6150l >> - qcom,spmi-pmic > > Maybe the yaml binding needs to say this is sorted in subtype id in a > comment. > > # Sorted based on subtype ID the device reports > Ok.. I will add it in next post. > Or we should sort this list in the binding and sort the compatible > string table in the driver with a comment that it's sorted based on > subtype id. > >> >> reg: >> diff --git a/drivers/mfd/qcom-spmi-pmic.c >> b/drivers/mfd/qcom-spmi-pmic.c >> index 1df1a27..5bfeec8 100644 >> --- a/drivers/mfd/qcom-spmi-pmic.c >> +++ b/drivers/mfd/qcom-spmi-pmic.c >> @@ -36,6 +36,8 @@ >> #define PM8998_SUBTYPE 0x14 >> #define PMI8998_SUBTYPE 0x15 >> #define PM8005_SUBTYPE 0x18 >> +#define PM6150L_SUBTYPE 0x1F >> +#define PM6150_SUBTYPE 0x28 >> >> static const struct of_device_id pmic_spmi_id_table[] = { >> { .compatible = "qcom,spmi-pmic", .data = (void >> *)COMMON_SUBTYPE }, >> @@ -57,6 +59,8 @@ static const struct of_device_id >> pmic_spmi_id_table[] = { >> { .compatible = "qcom,pm8998", .data = (void >> *)PM8998_SUBTYPE }, >> { .compatible = "qcom,pmi8998", .data = (void >> *)PMI8998_SUBTYPE }, >> { .compatible = "qcom,pm8005", .data = (void >> *)PM8005_SUBTYPE }, >> + { .compatible = "qcom,pm6150l", .data = (void >> *)PM6150L_SUBTYPE }, >> + { .compatible = "qcom,pm6150", .data = (void >> *)PM6150_SUBTYPE }, >> { } >> };
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index affc169..36f0795 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml @@ -46,6 +46,8 @@ properties: - qcom,pm8998 - qcom,pmi8998 - qcom,pm8005 + - qcom,pm6150 + - qcom,pm6150l - qcom,spmi-pmic reg: diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c index 1df1a27..5bfeec8 100644 --- a/drivers/mfd/qcom-spmi-pmic.c +++ b/drivers/mfd/qcom-spmi-pmic.c @@ -36,6 +36,8 @@ #define PM8998_SUBTYPE 0x14 #define PMI8998_SUBTYPE 0x15 #define PM8005_SUBTYPE 0x18 +#define PM6150L_SUBTYPE 0x1F +#define PM6150_SUBTYPE 0x28 static const struct of_device_id pmic_spmi_id_table[] = { { .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE }, @@ -57,6 +59,8 @@ static const struct of_device_id pmic_spmi_id_table[] = { { .compatible = "qcom,pm8998", .data = (void *)PM8998_SUBTYPE }, { .compatible = "qcom,pmi8998", .data = (void *)PMI8998_SUBTYPE }, { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE }, + { .compatible = "qcom,pm6150l", .data = (void *)PM6150L_SUBTYPE }, + { .compatible = "qcom,pm6150", .data = (void *)PM6150_SUBTYPE }, { } };
Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs found on SC7180 based platforms Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> --- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++ drivers/mfd/qcom-spmi-pmic.c | 4 ++++ 2 files changed, 6 insertions(+)