| Message ID | 20200112171521.22443-1-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fbdev: c2p: Use BUILD_BUG() instead of custom solution | expand |
On Sun, Jan 12, 2020 at 6:15 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Replace the call to the custom non-existing function by a standard > BUILD_BUG() invocation. > > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Thanks, applied and queued for v5.7. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Feb 10, 2020 at 12:16 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Sun, Jan 12, 2020 at 6:15 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Replace the call to the custom non-existing function by a standard > > BUILD_BUG() invocation. > > > > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Thanks, applied and queued for v5.7. Sorry, this is fbdev-material, not m68k-material. If you mind, I can drop it from the m68k for-v5.7 branch again. Gr{oetje,eeting}s, Geert
On 2/11/20 9:49 AM, Geert Uytterhoeven wrote: > On Mon, Feb 10, 2020 at 12:16 PM Geert Uytterhoeven > <geert@linux-m68k.org> wrote: >> On Sun, Jan 12, 2020 at 6:15 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: >>> Replace the call to the custom non-existing function by a standard >>> BUILD_BUG() invocation. >>> >>> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> >>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> >> >> Thanks, applied and queued for v5.7. > > Sorry, this is fbdev-material, not m68k-material. > If you mind, I can drop it from the m68k for-v5.7 branch again. I don't mind, lets keep it m68k tree (it should not cause any conflicts with other fbdev changes). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
diff --git a/drivers/video/fbdev/c2p_core.h b/drivers/video/fbdev/c2p_core.h index 45a6d895a7d7208e..cf5f1ebce65e6afd 100644 --- a/drivers/video/fbdev/c2p_core.h +++ b/drivers/video/fbdev/c2p_core.h @@ -12,6 +12,8 @@ * for more details. */ +#include <linux/build_bug.h> + /* * Basic transpose step @@ -27,8 +29,6 @@ static inline void _transp(u32 d[], unsigned int i1, unsigned int i2, } -extern void c2p_unsupported(void); - static __always_inline u32 get_mask(unsigned int n) { switch (n) { @@ -48,7 +48,7 @@ static __always_inline u32 get_mask(unsigned int n) return 0x0000ffff; } - c2p_unsupported(); + BUILD_BUG(); return 0; } @@ -91,7 +91,7 @@ static __always_inline void transp8(u32 d[], unsigned int n, unsigned int m) return; } - c2p_unsupported(); + BUILD_BUG(); } @@ -118,7 +118,7 @@ static __always_inline void transp4(u32 d[], unsigned int n, unsigned int m) return; } - c2p_unsupported(); + BUILD_BUG(); } @@ -138,7 +138,7 @@ static __always_inline void transp4x(u32 d[], unsigned int n, unsigned int m) return; } - c2p_unsupported(); + BUILD_BUG(); }
Replace the call to the custom non-existing function by a standard BUILD_BUG() invocation. Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/video/fbdev/c2p_core.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)