mbox series

[0/5,blktest] nvme: add cntlid and model testcases

Message ID 20200129232921.11771-1-chaitanya.kulkarni@wdc.com (mailing list archive)
Headers show
Series nvme: add cntlid and model testcases | expand

Message

Chaitanya Kulkarni Jan. 29, 2020, 11:29 p.m. UTC
This is a small patch-series which adds two new testcases for
setting up controller IDs and model from configfs.

Regards,
Chaitanya


Chaitanya Kulkarni (5):
  nvme: allow target subsys set cntlid min/max
  nvme: test target cntlid min cntlid max
  nvme: allow target subsys set model
  nvme: test target model attribute
  nvme: make new testcases backward compatible

 tests/nvme/033     | 61 ++++++++++++++++++++++++++++++++++++++++++++
 tests/nvme/033.out |  4 +++
 tests/nvme/034     | 63 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/nvme/034.out |  3 +++
 tests/nvme/rc      | 24 ++++++++++++++++++
 5 files changed, 155 insertions(+)
 create mode 100755 tests/nvme/033
 create mode 100644 tests/nvme/033.out
 create mode 100755 tests/nvme/034
 create mode 100644 tests/nvme/034.out

Test Log :-

Without cntlid_min/max and model patches :-

nvme/002 (create many subsystems and test discovery)         [passed]
    runtime  15.246s  ...  15.053s
nvme/003 (test if we're sending keep-alives to a discovery controller) [passed]
    runtime  10.057s  ...  10.063s
./check: no group or test named nvme/0004
nvme/005 (reset local loopback target)                       [not run]
    nvme_core module does not have parameter multipath
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
    runtime  0.057s  ...  0.065s
nvme/007 (create an NVMeOF target with a file-backed ns)     [passed]
    runtime  0.036s  ...  0.038s
nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
    runtime  1.233s  ...  1.240s
nvme/009 (create an NVMeOF host with a file-backed ns)       [passed]
    runtime  1.203s  ...  1.208s
nvme/014 (flush a NVMeOF block device-backed ns)             [passed]
    runtime  14.572s  ...  16.051s
nvme/015 (unit test for NVMe flush for file backed ns)       [passed]
    runtime  13.584s  ...  13.948s
nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [passed]
    runtime  9.877s  ...  10.750s
nvme/017 (create/delete many file-ns and test discovery)     [passed]
    runtime  18.902s  ...  15.584s
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
    runtime  1.217s  ...  1.237s
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
    runtime  1.204s  ...  1.193s
nvme/021 (test NVMe list command on NVMeOF file-backed ns)   [passed]
    runtime  1.204s  ...  1.195s
nvme/022 (test NVMe reset command on NVMeOF file-backed ns)  [passed]
    runtime    ...  1.334s
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
    runtime  1.218s  ...  1.231s
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
    runtime  1.207s  ...  1.196s
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
    runtime  1.191s  ...  1.195s
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
    runtime  1.192s  ...  1.196s
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
    runtime  1.211s  ...  1.191s
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
    runtime  1.204s  ...  1.211s
nvme/033 (Test NVMeOF target cntlid[min|max] attributes)     [not run]
    attr_cntlid_[min|max] not found
nvme/034 (Test NVMeOF target model attribute)                [not run]
    attr_cntlid_model not found

With cntlid_min/max and model patches :-

nvme/002 (create many subsystems and test discovery)         [passed]
    runtime  15.053s  ...  11.918s
nvme/003 (test if we're sending keep-alives to a discovery controller) [passed]
    runtime  10.063s  ...  10.058s
./check: no group or test named nvme/0004
nvme/005 (reset local loopback target)                       [not run]
    nvme_core module does not have parameter multipath
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
    runtime  0.065s  ...  0.065s
nvme/007 (create an NVMeOF target with a file-backed ns)     [passed]
    runtime  0.038s  ...  0.036s
nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
    runtime  1.240s  ...  1.239s
nvme/009 (create an NVMeOF host with a file-backed ns)       [passed]
    runtime  1.208s  ...  1.207s
nvme/014 (flush a NVMeOF block device-backed ns)             [passed]
    runtime  16.051s  ...  15.345s
nvme/015 (unit test for NVMe flush for file backed ns)       [passed]
    runtime  13.948s  ...  13.977s
nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [passed]
    runtime  10.750s  ...  9.698s
nvme/017 (create/delete many file-ns and test discovery)     [passed]
    runtime  15.584s  ...  15.514s
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
    runtime  1.237s  ...  1.232s
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
    runtime  1.193s  ...  1.192s
nvme/021 (test NVMe list command on NVMeOF file-backed ns)   [passed]
    runtime  1.195s  ...  1.195s
nvme/022 (test NVMe reset command on NVMeOF file-backed ns)  [passed]
    runtime  1.334s  ...  1.340s
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
    runtime  1.231s  ...  1.218s
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
    runtime  1.196s  ...  1.205s
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
    runtime  1.195s  ...  1.191s
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
    runtime  1.196s  ...  1.186s
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
    runtime  1.191s  ...  1.192s
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
    runtime  1.211s  ...  1.187s
nvme/033 (Test NVMeOF target cntlid[min|max] attributes)     [passed]
    runtime  1.213s  ...  1.200s
nvme/034 (Test NVMeOF target model attribute)                [passed]
    runtime  1.223s  ...  1.204s

Comments

Chaitanya Kulkarni Feb. 3, 2020, 10:48 p.m. UTC | #1
(+ Omar)

On 01/29/2020 03:29 PM, Chaitanya Kulkarni wrote:
> This is a small patch-series which adds two new testcases for
> setting up controller IDs and model from configfs.
>
> Regards,
> Chaitanya
>
>
> Chaitanya Kulkarni (5):
>    nvme: allow target subsys set cntlid min/max
>    nvme: test target cntlid min cntlid max
>    nvme: allow target subsys set model
>    nvme: test target model attribute
>    nvme: make new testcases backward compatible
>
>   tests/nvme/033     | 61 ++++++++++++++++++++++++++++++++++++++++++++
>   tests/nvme/033.out |  4 +++
>   tests/nvme/034     | 63 ++++++++++++++++++++++++++++++++++++++++++++++
>   tests/nvme/034.out |  3 +++
>   tests/nvme/rc      | 24 ++++++++++++++++++
>   5 files changed, 155 insertions(+)
>   create mode 100755 tests/nvme/033
>   create mode 100644 tests/nvme/033.out
>   create mode 100755 tests/nvme/034
>   create mode 100644 tests/nvme/034.out
>
> Test Log :-
>
> Without cntlid_min/max and model patches :-
>
> nvme/002 (create many subsystems and test discovery)         [passed]
>      runtime  15.246s  ...  15.053s
> nvme/003 (test if we're sending keep-alives to a discovery controller) [passed]
>      runtime  10.057s  ...  10.063s
> ./check: no group or test named nvme/0004
> nvme/005 (reset local loopback target)                       [not run]
>      nvme_core module does not have parameter multipath
> nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
>      runtime  0.057s  ...  0.065s
> nvme/007 (create an NVMeOF target with a file-backed ns)     [passed]
>      runtime  0.036s  ...  0.038s
> nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
>      runtime  1.233s  ...  1.240s
> nvme/009 (create an NVMeOF host with a file-backed ns)       [passed]
>      runtime  1.203s  ...  1.208s
> nvme/014 (flush a NVMeOF block device-backed ns)             [passed]
>      runtime  14.572s  ...  16.051s
> nvme/015 (unit test for NVMe flush for file backed ns)       [passed]
>      runtime  13.584s  ...  13.948s
> nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [passed]
>      runtime  9.877s  ...  10.750s
> nvme/017 (create/delete many file-ns and test discovery)     [passed]
>      runtime  18.902s  ...  15.584s
> nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
>      runtime  1.217s  ...  1.237s
> nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
>      runtime  1.204s  ...  1.193s
> nvme/021 (test NVMe list command on NVMeOF file-backed ns)   [passed]
>      runtime  1.204s  ...  1.195s
> nvme/022 (test NVMe reset command on NVMeOF file-backed ns)  [passed]
>      runtime    ...  1.334s
> nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
>      runtime  1.218s  ...  1.231s
> nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
>      runtime  1.207s  ...  1.196s
> nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
>      runtime  1.191s  ...  1.195s
> nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
>      runtime  1.192s  ...  1.196s
> nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
>      runtime  1.211s  ...  1.191s
> nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
>      runtime  1.204s  ...  1.211s
> nvme/033 (Test NVMeOF target cntlid[min|max] attributes)     [not run]
>      attr_cntlid_[min|max] not found
> nvme/034 (Test NVMeOF target model attribute)                [not run]
>      attr_cntlid_model not found
>
> With cntlid_min/max and model patches :-
>
> nvme/002 (create many subsystems and test discovery)         [passed]
>      runtime  15.053s  ...  11.918s
> nvme/003 (test if we're sending keep-alives to a discovery controller) [passed]
>      runtime  10.063s  ...  10.058s
> ./check: no group or test named nvme/0004
> nvme/005 (reset local loopback target)                       [not run]
>      nvme_core module does not have parameter multipath
> nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
>      runtime  0.065s  ...  0.065s
> nvme/007 (create an NVMeOF target with a file-backed ns)     [passed]
>      runtime  0.038s  ...  0.036s
> nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
>      runtime  1.240s  ...  1.239s
> nvme/009 (create an NVMeOF host with a file-backed ns)       [passed]
>      runtime  1.208s  ...  1.207s
> nvme/014 (flush a NVMeOF block device-backed ns)             [passed]
>      runtime  16.051s  ...  15.345s
> nvme/015 (unit test for NVMe flush for file backed ns)       [passed]
>      runtime  13.948s  ...  13.977s
> nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [passed]
>      runtime  10.750s  ...  9.698s
> nvme/017 (create/delete many file-ns and test discovery)     [passed]
>      runtime  15.584s  ...  15.514s
> nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
>      runtime  1.237s  ...  1.232s
> nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
>      runtime  1.193s  ...  1.192s
> nvme/021 (test NVMe list command on NVMeOF file-backed ns)   [passed]
>      runtime  1.195s  ...  1.195s
> nvme/022 (test NVMe reset command on NVMeOF file-backed ns)  [passed]
>      runtime  1.334s  ...  1.340s
> nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
>      runtime  1.231s  ...  1.218s
> nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
>      runtime  1.196s  ...  1.205s
> nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
>      runtime  1.195s  ...  1.191s
> nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
>      runtime  1.196s  ...  1.186s
> nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
>      runtime  1.191s  ...  1.192s
> nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
>      runtime  1.211s  ...  1.187s
> nvme/033 (Test NVMeOF target cntlid[min|max] attributes)     [passed]
>      runtime  1.213s  ...  1.200s
> nvme/034 (Test NVMeOF target model attribute)                [passed]
>      runtime  1.223s  ...  1.204s
>
>
Chaitanya Kulkarni Feb. 11, 2020, 4:46 p.m. UTC | #2
Ping ?

On 02/03/2020 02:48 PM, Chaitanya Kulkarni wrote:
> (+ Omar)
>
> On 01/29/2020 03:29 PM, Chaitanya Kulkarni wrote:
>> This is a small patch-series which adds two new testcases for
>> setting up controller IDs and model from configfs.
>>
>> Regards,
>> Chaitanya
>>
>>
>> Chaitanya Kulkarni (5):
>>     nvme: allow target subsys set cntlid min/max
>>     nvme: test target cntlid min cntlid max
>>     nvme: allow target subsys set model
>>     nvme: test target model attribute
>>     nvme: make new testcases backward compatible
>>
>>    tests/nvme/033     | 61 ++++++++++++++++++++++++++++++++++++++++++++
>>    tests/nvme/033.out |  4 +++
>>    tests/nvme/034     | 63 ++++++++++++++++++++++++++++++++++++++++++++++
>>    tests/nvme/034.out |  3 +++
>>    tests/nvme/rc      | 24 ++++++++++++++++++
>>    5 files changed, 155 insertions(+)
>>    create mode 100755 tests/nvme/033
>>    create mode 100644 tests/nvme/033.out
>>    create mode 100755 tests/nvme/034
>>    create mode 100644 tests/nvme/034.out
>>
>> Test Log :-
>>
>> Without cntlid_min/max and model patches :-
>>
>> nvme/002 (create many subsystems and test discovery)         [passed]
>>       runtime  15.246s  ...  15.053s
>> nvme/003 (test if we're sending keep-alives to a discovery controller) [passed]
>>       runtime  10.057s  ...  10.063s
>> ./check: no group or test named nvme/0004
>> nvme/005 (reset local loopback target)                       [not run]
>>       nvme_core module does not have parameter multipath
>> nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
>>       runtime  0.057s  ...  0.065s
>> nvme/007 (create an NVMeOF target with a file-backed ns)     [passed]
>>       runtime  0.036s  ...  0.038s
>> nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
>>       runtime  1.233s  ...  1.240s
>> nvme/009 (create an NVMeOF host with a file-backed ns)       [passed]
>>       runtime  1.203s  ...  1.208s
>> nvme/014 (flush a NVMeOF block device-backed ns)             [passed]
>>       runtime  14.572s  ...  16.051s
>> nvme/015 (unit test for NVMe flush for file backed ns)       [passed]
>>       runtime  13.584s  ...  13.948s
>> nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [passed]
>>       runtime  9.877s  ...  10.750s
>> nvme/017 (create/delete many file-ns and test discovery)     [passed]
>>       runtime  18.902s  ...  15.584s
>> nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
>>       runtime  1.217s  ...  1.237s
>> nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
>>       runtime  1.204s  ...  1.193s
>> nvme/021 (test NVMe list command on NVMeOF file-backed ns)   [passed]
>>       runtime  1.204s  ...  1.195s
>> nvme/022 (test NVMe reset command on NVMeOF file-backed ns)  [passed]
>>       runtime    ...  1.334s
>> nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
>>       runtime  1.218s  ...  1.231s
>> nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
>>       runtime  1.207s  ...  1.196s
>> nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
>>       runtime  1.191s  ...  1.195s
>> nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
>>       runtime  1.192s  ...  1.196s
>> nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
>>       runtime  1.211s  ...  1.191s
>> nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
>>       runtime  1.204s  ...  1.211s
>> nvme/033 (Test NVMeOF target cntlid[min|max] attributes)     [not run]
>>       attr_cntlid_[min|max] not found
>> nvme/034 (Test NVMeOF target model attribute)                [not run]
>>       attr_cntlid_model not found
>>
>> With cntlid_min/max and model patches :-
>>
>> nvme/002 (create many subsystems and test discovery)         [passed]
>>       runtime  15.053s  ...  11.918s
>> nvme/003 (test if we're sending keep-alives to a discovery controller) [passed]
>>       runtime  10.063s  ...  10.058s
>> ./check: no group or test named nvme/0004
>> nvme/005 (reset local loopback target)                       [not run]
>>       nvme_core module does not have parameter multipath
>> nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
>>       runtime  0.065s  ...  0.065s
>> nvme/007 (create an NVMeOF target with a file-backed ns)     [passed]
>>       runtime  0.038s  ...  0.036s
>> nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
>>       runtime  1.240s  ...  1.239s
>> nvme/009 (create an NVMeOF host with a file-backed ns)       [passed]
>>       runtime  1.208s  ...  1.207s
>> nvme/014 (flush a NVMeOF block device-backed ns)             [passed]
>>       runtime  16.051s  ...  15.345s
>> nvme/015 (unit test for NVMe flush for file backed ns)       [passed]
>>       runtime  13.948s  ...  13.977s
>> nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [passed]
>>       runtime  10.750s  ...  9.698s
>> nvme/017 (create/delete many file-ns and test discovery)     [passed]
>>       runtime  15.584s  ...  15.514s
>> nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
>>       runtime  1.237s  ...  1.232s
>> nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
>>       runtime  1.193s  ...  1.192s
>> nvme/021 (test NVMe list command on NVMeOF file-backed ns)   [passed]
>>       runtime  1.195s  ...  1.195s
>> nvme/022 (test NVMe reset command on NVMeOF file-backed ns)  [passed]
>>       runtime  1.334s  ...  1.340s
>> nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
>>       runtime  1.231s  ...  1.218s
>> nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
>>       runtime  1.196s  ...  1.205s
>> nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
>>       runtime  1.195s  ...  1.191s
>> nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
>>       runtime  1.196s  ...  1.186s
>> nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
>>       runtime  1.191s  ...  1.192s
>> nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
>>       runtime  1.211s  ...  1.187s
>> nvme/033 (Test NVMeOF target cntlid[min|max] attributes)     [passed]
>>       runtime  1.213s  ...  1.200s
>> nvme/034 (Test NVMeOF target model attribute)                [passed]
>>       runtime  1.223s  ...  1.204s
>>
>>
>
>
Omar Sandoval Feb. 11, 2020, 10:07 p.m. UTC | #3
On Tue, Feb 11, 2020 at 04:46:05PM +0000, Chaitanya Kulkarni wrote:
> Ping ?

Whoops sorry, these don't match my email filter that looks for "PATCH
blktests" so I missed them. (You can make git do that for you with git
format-patch --subject-prefix="PATCH blktests", by the way.)

Thanks!
Chaitanya Kulkarni Feb. 11, 2020, 10:17 p.m. UTC | #4
On 02/11/2020 02:07 PM, Omar Sandoval wrote:
> Whoops sorry, these don't match my email filter that looks for "PATCH
> blktests" so I missed them. (You can make git do that for you with git
> format-patch --subject-prefix="PATCH blktests", by the way.)

Okay, by bad, missed the PATCH before blktests.