| Message ID | 1581583253-26814-1-git-send-email-anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: fix devid attribute name | expand |
On Thu, Feb 13, 2020 at 04:40:53PM +0800, Anand Jain wrote: > It looks like one of the attribute was missed out while renaming the > devid attribute. So fix it here. > > Fixes: 668e48af7a94 (btrfs: sysfs, add devid/dev_state kobject and device > attributes) > Signed-off-by: Anand Jain <anand.jain@oracle.com> > --- > Hi David, There is one trivial item which also got messed up in this > series, its about function renaming. Can we merge this in misc-next. Yes, I noticed too, thanks for the patch.
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 91e2ec393a92..66cfefb03e1f 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -1272,7 +1272,7 @@ static ssize_t btrfs_devinfo_in_fs_metadata_show(struct kobject *kobj, } BTRFS_ATTR(devid, in_fs_metadata, btrfs_devinfo_in_fs_metadata_show); -static ssize_t btrfs_sysfs_missing_show(struct kobject *kobj, +static ssize_t btrfs_devinfo_missing_show(struct kobject *kobj, struct kobj_attribute *a, char *buf) { int val; @@ -1283,7 +1283,7 @@ static ssize_t btrfs_sysfs_missing_show(struct kobject *kobj, return snprintf(buf, PAGE_SIZE, "%d\n", val); } -BTRFS_ATTR(devid, missing, btrfs_sysfs_missing_show); +BTRFS_ATTR(devid, missing, btrfs_devinfo_missing_show); static ssize_t btrfs_devinfo_replace_target_show(struct kobject *kobj, struct kobj_attribute *a,
It looks like one of the attribute was missed out while renaming the devid attribute. So fix it here. Fixes: 668e48af7a94 (btrfs: sysfs, add devid/dev_state kobject and device attributes) Signed-off-by: Anand Jain <anand.jain@oracle.com> --- Hi David, There is one trivial item which also got messed up in this series, its about function renaming. Can we merge this in misc-next. fs/btrfs/sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)