| Message ID | db4db9e0b024aa3051a6f1f7be07323418d1d453.1581696624.git.hns@goldelico.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | MIPS: Fixes and improvements for CI20 board (JZ4780) | expand |
Hi Nikolaus, Patches 03-12 only touch the same two files - ci20.dts and ci20_defconfig. Unless someone strongly disagrees, I'd suggest to squash all patches that touch each file together (except the ones with a Fixes tag), I don't think we really need that much granularity here. -Paul Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller <hns@goldelico.com> a écrit : > Not all drivers need to be compiled into the kernel. > Support building and loading of kernel modules. > > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > arch/mips/configs/ci20_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/mips/configs/ci20_defconfig > b/arch/mips/configs/ci20_defconfig > index be41df2a81fb..e0d3c9d4c2ae 100644 > --- a/arch/mips/configs/ci20_defconfig > +++ b/arch/mips/configs/ci20_defconfig > @@ -1,4 +1,5 @@ > # CONFIG_LOCALVERSION_AUTO is not set > +CONFIG_MODULES=y > CONFIG_KERNEL_XZ=y > CONFIG_SYSVIPC=y > CONFIG_POSIX_MQUEUE=y > -- > 2.23.0 >
Hi Paul, > Am 14.02.2020 um 20:10 schrieb Paul Cercueil <paul@crapouillou.net>: > > Hi Nikolaus, > > Patches 03-12 only touch the same two files - ci20.dts and ci20_defconfig. > > Unless someone strongly disagrees, I'd suggest to squash all patches that touch each file together (except the ones with a Fixes tag), I don't think we really need that much granularity here. It comes more from having developed these things quite independently and only collected for submission... One patch I don't know how to handle: "MIPS: DTS: CI20: add DT node for IR sensor". It is from 2015 and has a different author (some Alex Smith but the mail address seems to be broken). This information and attribution will be lost if we squash them. But I can do for V3 and will also fix the fixes tags by adding cc: stable :) BR and thanks, Nikolaus > > -Paul > > > Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller <hns@goldelico.com> a écrit : >> Not all drivers need to be compiled into the kernel. >> Support building and loading of kernel modules. >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >> --- >> arch/mips/configs/ci20_defconfig | 1 + >> 1 file changed, 1 insertion(+) >> diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig >> index be41df2a81fb..e0d3c9d4c2ae 100644 >> --- a/arch/mips/configs/ci20_defconfig >> +++ b/arch/mips/configs/ci20_defconfig >> @@ -1,4 +1,5 @@ >> # CONFIG_LOCALVERSION_AUTO is not set >> +CONFIG_MODULES=y >> CONFIG_KERNEL_XZ=y >> CONFIG_SYSVIPC=y >> CONFIG_POSIX_MQUEUE=y >> -- >> 2.23.0 > >
Le ven., févr. 14, 2020 at 20:30, H. Nikolaus Schaller <hns@goldelico.com> a écrit : > Hi Paul, > >> Am 14.02.2020 um 20:10 schrieb Paul Cercueil <paul@crapouillou.net>: >> >> Hi Nikolaus, >> >> Patches 03-12 only touch the same two files - ci20.dts and >> ci20_defconfig. >> >> Unless someone strongly disagrees, I'd suggest to squash all >> patches that touch each file together (except the ones with a Fixes >> tag), I don't think we really need that much granularity here. > > It comes more from having developed these things quite independently > and only collected for submission... > > One patch I don't know how to handle: "MIPS: DTS: CI20: add DT node > for IR sensor". > It is from 2015 and has a different author (some Alex Smith but the > mail address seems to be broken). > This information and attribution will be lost if we squash them. Ah, alright. Then I guess keep this one separate. -Paul > > But I can do for V3 and will also fix the fixes tags by adding cc: > stable :) > > BR and thanks, > Nikolaus > > >> >> -Paul >> >> >> Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller >> <hns@goldelico.com> a écrit : >>> Not all drivers need to be compiled into the kernel. >>> Support building and loading of kernel modules. >>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >>> --- >>> arch/mips/configs/ci20_defconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> diff --git a/arch/mips/configs/ci20_defconfig >>> b/arch/mips/configs/ci20_defconfig >>> index be41df2a81fb..e0d3c9d4c2ae 100644 >>> --- a/arch/mips/configs/ci20_defconfig >>> +++ b/arch/mips/configs/ci20_defconfig >>> @@ -1,4 +1,5 @@ >>> # CONFIG_LOCALVERSION_AUTO is not set >>> +CONFIG_MODULES=y >>> CONFIG_KERNEL_XZ=y >>> CONFIG_SYSVIPC=y >>> CONFIG_POSIX_MQUEUE=y >>> -- >>> 2.23.0 >> >> >
diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index be41df2a81fb..e0d3c9d4c2ae 100644 --- a/arch/mips/configs/ci20_defconfig +++ b/arch/mips/configs/ci20_defconfig @@ -1,4 +1,5 @@ # CONFIG_LOCALVERSION_AUTO is not set +CONFIG_MODULES=y CONFIG_KERNEL_XZ=y CONFIG_SYSVIPC=y CONFIG_POSIX_MQUEUE=y
Not all drivers need to be compiled into the kernel. Support building and loading of kernel modules. Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- arch/mips/configs/ci20_defconfig | 1 + 1 file changed, 1 insertion(+)