diff mbox series

[v2,01/12] drm: ingenic-drm: add MODULE_DEVICE_TABLE

Message ID 1b5475c88032b3851c6d33443e688b432af42a9f.1581696624.git.hns@goldelico.com (mailing list archive)
State Superseded
Headers show
Series MIPS: Fixes and improvements for CI20 board (JZ4780) | expand

Commit Message

H. Nikolaus Schaller Feb. 14, 2020, 4:10 p.m. UTC
Add MODULE_DEVICE_TABLE so that the driver can load by
matching the device tree if compiled as module.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 drivers/gpu/drm/ingenic/ingenic-drm.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Paul Cercueil Feb. 14, 2020, 7:06 p.m. UTC | #1
Hi Nikolaus,

Please rebase this patch on top of drm-misc-next and send it apart - it 
should go through the DRM tree.


Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller 
<hns@goldelico.com> a écrit :
> Add MODULE_DEVICE_TABLE so that the driver can load by
> matching the device tree if compiled as module.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
>  drivers/gpu/drm/ingenic/ingenic-drm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c 
> b/drivers/gpu/drm/ingenic/ingenic-drm.c
> index 6d47ef7b148c..d8617096dd8e 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
> @@ -844,6 +844,8 @@ static const struct of_device_id 
> ingenic_drm_of_match[] = {
>  	{ /* sentinel */ },
>  };
> 
> +MODULE_DEVICE_TABLE(of, ingenic_drm_of_match);

Also please remove the blank line above MODULE_DEVICE_TABLE.

Cheers,
-Paul

> +
>  static struct platform_driver ingenic_drm_driver = {
>  	.driver = {
>  		.name = "ingenic-drm",
> --
> 2.23.0
>
H. Nikolaus Schaller Feb. 14, 2020, 7:24 p.m. UTC | #2
> Am 14.02.2020 um 20:06 schrieb Paul Cercueil <paul@crapouillou.net>:
> 
> Hi Nikolaus,
> 
> Please rebase this patch on top of drm-misc-next and send it apart - it should go through the DRM tree.
> 
> 
> Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller <hns@goldelico.com> a écrit :
>> Add MODULE_DEVICE_TABLE so that the driver can load by
>> matching the device tree if compiled as module.
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> drivers/gpu/drm/ingenic/ingenic-drm.c | 2 ++
>> 1 file changed, 2 insertions(+)
>> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c
>> index 6d47ef7b148c..d8617096dd8e 100644
>> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
>> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
>> @@ -844,6 +844,8 @@ static const struct of_device_id ingenic_drm_of_match[] = {
>> 	{ /* sentinel */ },
>> };
>> +MODULE_DEVICE_TABLE(of, ingenic_drm_of_match);
> 
> Also please remove the blank line above MODULE_DEVICE_TABLE.
> 
> Cheers,
> -Paul

Ok.

BR and thanks,
Nikolaus

> 
>> +
>> static struct platform_driver ingenic_drm_driver = {
>> 	.driver = {
>> 		.name = "ingenic-drm",
>> --
>> 2.23.0
> 
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c
index 6d47ef7b148c..d8617096dd8e 100644
--- a/drivers/gpu/drm/ingenic/ingenic-drm.c
+++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
@@ -844,6 +844,8 @@  static const struct of_device_id ingenic_drm_of_match[] = {
 	{ /* sentinel */ },
 };
 
+MODULE_DEVICE_TABLE(of, ingenic_drm_of_match);
+
 static struct platform_driver ingenic_drm_driver = {
 	.driver = {
 		.name = "ingenic-drm",