Message ID | 20200124084359.16817-1-christian.gmeiner@gmail.com (mailing list archive) |
---|---|
State | Mainlined |
Commit | 1910ee13a12ce7cab99d97a278ef6083a3cb922a |
Headers | show |
Series | ARM: multi_v7_defconfig: enable drm imx support | expand |
Am Fr., 24. Jan. 2020 um 09:44 Uhr schrieb Christian Gmeiner <christian.gmeiner@gmail.com>: > > Makes it possible to multi v7 defconfig for stm32 and imx based devices with > full drm support. > > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> > --- > arch/arm/configs/multi_v7_defconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index 3f1b96dc7faa..d213a35557ed 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -637,6 +637,7 @@ CONFIG_CEC_PLATFORM_DRIVERS=y > CONFIG_VIDEO_SAMSUNG_S5P_CEC=m > CONFIG_VIDEO_ADV7180=m > CONFIG_VIDEO_ML86V7667=m > +CONFIG_IMX_IPUV3_CORE=m > CONFIG_DRM=y > # CONFIG_DRM_I2C_CH7006 is not set > # CONFIG_DRM_I2C_SIL164 is not set > @@ -652,6 +653,11 @@ CONFIG_ROCKCHIP_ANALOGIX_DP=y > CONFIG_ROCKCHIP_DW_HDMI=y > CONFIG_ROCKCHIP_DW_MIPI_DSI=y > CONFIG_ROCKCHIP_INNO_HDMI=y > +CONFIG_DRM_IMX=m > +CONFIG_DRM_IMX_PARALLEL_DISPLAY=m > +CONFIG_DRM_IMX_TVE=m > +CONFIG_DRM_IMX_LDB=m > +CONFIG_DRM_IMX_HDMI=m > CONFIG_DRM_ATMEL_HLCDC=m > CONFIG_DRM_RCAR_DU=m > CONFIG_DRM_RCAR_LVDS=y > -- > 2.24.1 > ping
On Mon, 10 Feb 2020 at 11:54, Christian Gmeiner <christian.gmeiner@gmail.com> wrote: > > Am Fr., 24. Jan. 2020 um 09:44 Uhr schrieb Christian Gmeiner > <christian.gmeiner@gmail.com>: > > > > Makes it possible to multi v7 defconfig for stm32 and imx based devices with > > full drm support. > > > > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> > > --- > > arch/arm/configs/multi_v7_defconfig | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > > index 3f1b96dc7faa..d213a35557ed 100644 > > --- a/arch/arm/configs/multi_v7_defconfig > > +++ b/arch/arm/configs/multi_v7_defconfig > > @@ -637,6 +637,7 @@ CONFIG_CEC_PLATFORM_DRIVERS=y > > CONFIG_VIDEO_SAMSUNG_S5P_CEC=m > > CONFIG_VIDEO_ADV7180=m > > CONFIG_VIDEO_ML86V7667=m > > +CONFIG_IMX_IPUV3_CORE=m > > CONFIG_DRM=y > > # CONFIG_DRM_I2C_CH7006 is not set > > # CONFIG_DRM_I2C_SIL164 is not set > > @@ -652,6 +653,11 @@ CONFIG_ROCKCHIP_ANALOGIX_DP=y > > CONFIG_ROCKCHIP_DW_HDMI=y > > CONFIG_ROCKCHIP_DW_MIPI_DSI=y > > CONFIG_ROCKCHIP_INNO_HDMI=y > > +CONFIG_DRM_IMX=m > > +CONFIG_DRM_IMX_PARALLEL_DISPLAY=m > > +CONFIG_DRM_IMX_TVE=m > > +CONFIG_DRM_IMX_LDB=m > > +CONFIG_DRM_IMX_HDMI=m > > CONFIG_DRM_ATMEL_HLCDC=m > > CONFIG_DRM_RCAR_DU=m > > CONFIG_DRM_RCAR_LVDS=y > > -- > > 2.24.1 > > > > > ping Hi, It looks like you entirely skipped iMX maintainers in Cc/to list, so whom are you pinging? Best regards, Krzysztof
Am Mo., 10. Feb. 2020 um 11:58 Uhr schrieb Krzysztof Kozlowski <krzk@kernel.org>: > > On Mon, 10 Feb 2020 at 11:54, Christian Gmeiner > <christian.gmeiner@gmail.com> wrote: > > > > Am Fr., 24. Jan. 2020 um 09:44 Uhr schrieb Christian Gmeiner > > <christian.gmeiner@gmail.com>: > > > > > > Makes it possible to multi v7 defconfig for stm32 and imx based devices with > > > full drm support. > > > > > > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> > > > --- > > > arch/arm/configs/multi_v7_defconfig | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > > > index 3f1b96dc7faa..d213a35557ed 100644 > > > --- a/arch/arm/configs/multi_v7_defconfig > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > @@ -637,6 +637,7 @@ CONFIG_CEC_PLATFORM_DRIVERS=y > > > CONFIG_VIDEO_SAMSUNG_S5P_CEC=m > > > CONFIG_VIDEO_ADV7180=m > > > CONFIG_VIDEO_ML86V7667=m > > > +CONFIG_IMX_IPUV3_CORE=m > > > CONFIG_DRM=y > > > # CONFIG_DRM_I2C_CH7006 is not set > > > # CONFIG_DRM_I2C_SIL164 is not set > > > @@ -652,6 +653,11 @@ CONFIG_ROCKCHIP_ANALOGIX_DP=y > > > CONFIG_ROCKCHIP_DW_HDMI=y > > > CONFIG_ROCKCHIP_DW_MIPI_DSI=y > > > CONFIG_ROCKCHIP_INNO_HDMI=y > > > +CONFIG_DRM_IMX=m > > > +CONFIG_DRM_IMX_PARALLEL_DISPLAY=m > > > +CONFIG_DRM_IMX_TVE=m > > > +CONFIG_DRM_IMX_LDB=m > > > +CONFIG_DRM_IMX_HDMI=m > > > CONFIG_DRM_ATMEL_HLCDC=m > > > CONFIG_DRM_RCAR_DU=m > > > CONFIG_DRM_RCAR_LVDS=y > > > -- > > > 2.24.1 > > > > > > > > > ping > > Hi, > > It looks like you entirely skipped iMX maintainers in Cc/to list, so > whom are you pinging? > I did use git send-email --cc-cmd='./scripts/get_maintainer.pl .. to send out this patch so I am not the one to blame here. Adding some imx maintainers...
On Mon, Feb 10, 2020 at 02:30:12PM +0100, Christian Gmeiner wrote: > Am Mo., 10. Feb. 2020 um 11:58 Uhr schrieb Krzysztof Kozlowski > <krzk@kernel.org>: > > > > On Mon, 10 Feb 2020 at 11:54, Christian Gmeiner > > <christian.gmeiner@gmail.com> wrote: > > > > > > Am Fr., 24. Jan. 2020 um 09:44 Uhr schrieb Christian Gmeiner > > > <christian.gmeiner@gmail.com>: > > > > > > > > Makes it possible to multi v7 defconfig for stm32 and imx based devices with What do you mean by stm32 based devices here? Shawn > > > > full drm support. > > > > > > > > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> > > > > --- > > > > arch/arm/configs/multi_v7_defconfig | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > > > > index 3f1b96dc7faa..d213a35557ed 100644 > > > > --- a/arch/arm/configs/multi_v7_defconfig > > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > > @@ -637,6 +637,7 @@ CONFIG_CEC_PLATFORM_DRIVERS=y > > > > CONFIG_VIDEO_SAMSUNG_S5P_CEC=m > > > > CONFIG_VIDEO_ADV7180=m > > > > CONFIG_VIDEO_ML86V7667=m > > > > +CONFIG_IMX_IPUV3_CORE=m > > > > CONFIG_DRM=y > > > > # CONFIG_DRM_I2C_CH7006 is not set > > > > # CONFIG_DRM_I2C_SIL164 is not set > > > > @@ -652,6 +653,11 @@ CONFIG_ROCKCHIP_ANALOGIX_DP=y > > > > CONFIG_ROCKCHIP_DW_HDMI=y > > > > CONFIG_ROCKCHIP_DW_MIPI_DSI=y > > > > CONFIG_ROCKCHIP_INNO_HDMI=y > > > > +CONFIG_DRM_IMX=m > > > > +CONFIG_DRM_IMX_PARALLEL_DISPLAY=m > > > > +CONFIG_DRM_IMX_TVE=m > > > > +CONFIG_DRM_IMX_LDB=m > > > > +CONFIG_DRM_IMX_HDMI=m > > > > CONFIG_DRM_ATMEL_HLCDC=m > > > > CONFIG_DRM_RCAR_DU=m > > > > CONFIG_DRM_RCAR_LVDS=y > > > > -- > > > > 2.24.1 > > > > > > > > > > > > > ping > > > > Hi, > > > > It looks like you entirely skipped iMX maintainers in Cc/to list, so > > whom are you pinging? > > > > I did use git send-email --cc-cmd='./scripts/get_maintainer.pl .. to > send out this patch so I am not the one to blame here. > > Adding some imx maintainers... > > -- > Thanks > -- > Christian Gmeiner, MSc > > https://christian-gmeiner.info/privacypolicy
Am Mo., 17. Feb. 2020 um 05:19 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > On Mon, Feb 10, 2020 at 02:30:12PM +0100, Christian Gmeiner wrote: > > Am Mo., 10. Feb. 2020 um 11:58 Uhr schrieb Krzysztof Kozlowski > > <krzk@kernel.org>: > > > > > > On Mon, 10 Feb 2020 at 11:54, Christian Gmeiner > > > <christian.gmeiner@gmail.com> wrote: > > > > > > > > Am Fr., 24. Jan. 2020 um 09:44 Uhr schrieb Christian Gmeiner > > > > <christian.gmeiner@gmail.com>: > > > > > > > > > > Makes it possible to multi v7 defconfig for stm32 and imx based devices with > > What do you mean by stm32 based devices here? > CONFIG_ARCH_STM32 - I have a STM32MP157C-DK2 in my board farm and would love to use multi_v7 for imx6 and stm32.
On Mon, Feb 17, 2020 at 01:09:32PM +0100, Christian Gmeiner wrote: > Am Mo., 17. Feb. 2020 um 05:19 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > > > On Mon, Feb 10, 2020 at 02:30:12PM +0100, Christian Gmeiner wrote: > > > Am Mo., 10. Feb. 2020 um 11:58 Uhr schrieb Krzysztof Kozlowski > > > <krzk@kernel.org>: > > > > > > > > On Mon, 10 Feb 2020 at 11:54, Christian Gmeiner > > > > <christian.gmeiner@gmail.com> wrote: > > > > > > > > > > Am Fr., 24. Jan. 2020 um 09:44 Uhr schrieb Christian Gmeiner > > > > > <christian.gmeiner@gmail.com>: > > > > > > > > > > > > Makes it possible to multi v7 defconfig for stm32 and imx based devices with > > > > What do you mean by stm32 based devices here? > > > > CONFIG_ARCH_STM32 - I have a STM32MP157C-DK2 in my board farm and > would love to use > multi_v7 for imx6 and stm32. The patch is all about enabling drm-imx driver support. The commit log gives the impression that drm-imx driver also works on stm32 devices. Is that the case? Shawn
Am Di., 18. Feb. 2020 um 10:14 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > On Mon, Feb 17, 2020 at 01:09:32PM +0100, Christian Gmeiner wrote: > > Am Mo., 17. Feb. 2020 um 05:19 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > > > > > On Mon, Feb 10, 2020 at 02:30:12PM +0100, Christian Gmeiner wrote: > > > > Am Mo., 10. Feb. 2020 um 11:58 Uhr schrieb Krzysztof Kozlowski > > > > <krzk@kernel.org>: > > > > > > > > > > On Mon, 10 Feb 2020 at 11:54, Christian Gmeiner > > > > > <christian.gmeiner@gmail.com> wrote: > > > > > > > > > > > > Am Fr., 24. Jan. 2020 um 09:44 Uhr schrieb Christian Gmeiner > > > > > > <christian.gmeiner@gmail.com>: > > > > > > > > > > > > > > Makes it possible to multi v7 defconfig for stm32 and imx based devices with > > > > > > What do you mean by stm32 based devices here? > > > > > > > CONFIG_ARCH_STM32 - I have a STM32MP157C-DK2 in my board farm and > > would love to use > > multi_v7 for imx6 and stm32. > > The patch is all about enabling drm-imx driver support. The commit log > gives the impression that drm-imx driver also works on stm32 devices. > Is that the case? > No - the common thing both share is etnaviv. The patch subject "ARM: multi_v7_defconfig: enable drm imx support" is fine I think but in the commit message I missed the verb so this should be a better one: --->8--- ARM: multi_v7_defconfig: enable drm imx support Makes it possible to use multi v7 defconfig for stm32 and imx based devices with full drm support. --->8--- How shall I proceed to get this change in?
On Wed, Feb 19, 2020 at 09:48:23AM +0100, Christian Gmeiner wrote: > Am Di., 18. Feb. 2020 um 10:14 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > > > On Mon, Feb 17, 2020 at 01:09:32PM +0100, Christian Gmeiner wrote: > > > Am Mo., 17. Feb. 2020 um 05:19 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > > > > > > > On Mon, Feb 10, 2020 at 02:30:12PM +0100, Christian Gmeiner wrote: > > > > > Am Mo., 10. Feb. 2020 um 11:58 Uhr schrieb Krzysztof Kozlowski > > > > > <krzk@kernel.org>: > > > > > > > > > > > > On Mon, 10 Feb 2020 at 11:54, Christian Gmeiner > > > > > > <christian.gmeiner@gmail.com> wrote: > > > > > > > > > > > > > > Am Fr., 24. Jan. 2020 um 09:44 Uhr schrieb Christian Gmeiner > > > > > > > <christian.gmeiner@gmail.com>: > > > > > > > > > > > > > > > > Makes it possible to multi v7 defconfig for stm32 and imx based devices with > > > > > > > > What do you mean by stm32 based devices here? > > > > > > > > > > CONFIG_ARCH_STM32 - I have a STM32MP157C-DK2 in my board farm and > > > would love to use > > > multi_v7 for imx6 and stm32. > > > > The patch is all about enabling drm-imx driver support. The commit log > > gives the impression that drm-imx driver also works on stm32 devices. > > Is that the case? > > > > No - the common thing both share is etnaviv. I did not know that before, and thanks for the information. But looking at the code change, there is nothing about etnaviv driver, and it's all about drm-imx driver. So I'm still questioning why stm32 needs to be mentioned in the commit log at all. > The patch subject "ARM: > multi_v7_defconfig: enable drm imx support" is fine Agreed. It's perfect. > I think but in the commit message I missed the verb so this should be > a better one: > > --->8--- > ARM: multi_v7_defconfig: enable drm imx support > > Makes it possible to use multi v7 defconfig for stm32 and imx based devices with > full drm support. > --->8--- I don't think 'stm32' should be there, as the code change in this commit has nothing to do with stm32, if I understand it correctly. > How shall I proceed to get this change in? I can edit the commit log when applying. But we need to agree on what it should be first. Shawn
Hi Sorry for the delay.. totally forgot about the mail. Am Mi., 19. Feb. 2020 um 10:11 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > On Wed, Feb 19, 2020 at 09:48:23AM +0100, Christian Gmeiner wrote: > > Am Di., 18. Feb. 2020 um 10:14 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > > > > > On Mon, Feb 17, 2020 at 01:09:32PM +0100, Christian Gmeiner wrote: > > > > Am Mo., 17. Feb. 2020 um 05:19 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > > > > > > > > > On Mon, Feb 10, 2020 at 02:30:12PM +0100, Christian Gmeiner wrote: > > > > > > Am Mo., 10. Feb. 2020 um 11:58 Uhr schrieb Krzysztof Kozlowski > > > > > > <krzk@kernel.org>: > > > > > > > > > > > > > > On Mon, 10 Feb 2020 at 11:54, Christian Gmeiner > > > > > > > <christian.gmeiner@gmail.com> wrote: > > > > > > > > > > > > > > > > Am Fr., 24. Jan. 2020 um 09:44 Uhr schrieb Christian Gmeiner > > > > > > > > <christian.gmeiner@gmail.com>: > > > > > > > > > > > > > > > > > > Makes it possible to multi v7 defconfig for stm32 and imx based devices with > > > > > > > > > > What do you mean by stm32 based devices here? > > > > > > > > > > > > > CONFIG_ARCH_STM32 - I have a STM32MP157C-DK2 in my board farm and > > > > would love to use > > > > multi_v7 for imx6 and stm32. > > > > > > The patch is all about enabling drm-imx driver support. The commit log > > > gives the impression that drm-imx driver also works on stm32 devices. > > > Is that the case? > > > > > > > No - the common thing both share is etnaviv. > > I did not know that before, and thanks for the information. But looking > at the code change, there is nothing about etnaviv driver, and it's all > about drm-imx driver. So I'm still questioning why stm32 needs to be > mentioned in the commit log at all. > > > The patch subject "ARM: > > multi_v7_defconfig: enable drm imx support" is fine > > Agreed. It's perfect. > > > I think but in the commit message I missed the verb so this should be > > a better one: > > > > --->8--- > > ARM: multi_v7_defconfig: enable drm imx support > > > > Makes it possible to use multi v7 defconfig for stm32 and imx based devices with > > full drm support. > > --->8--- > > I don't think 'stm32' should be there, as the code change in this commit > has nothing to do with stm32, if I understand it correctly. > Okay.. what about: --->8--- ARM: multi_v7_defconfig: enable drm imx support It will be useful to have it enabled for KernelCI boot and runtime testing. --->8--- > > How shall I proceed to get this change in? > > I can edit the commit log when applying. But we need to agree on what > it should be first. > Great!
On Fri, Mar 06, 2020 at 02:58:30PM +0100, Christian Gmeiner wrote: > Hi > > Sorry for the delay.. totally forgot about the mail. > > Am Mi., 19. Feb. 2020 um 10:11 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > > > On Wed, Feb 19, 2020 at 09:48:23AM +0100, Christian Gmeiner wrote: > > > Am Di., 18. Feb. 2020 um 10:14 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > > > > > > > On Mon, Feb 17, 2020 at 01:09:32PM +0100, Christian Gmeiner wrote: > > > > > Am Mo., 17. Feb. 2020 um 05:19 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > > > > > > > > > > > On Mon, Feb 10, 2020 at 02:30:12PM +0100, Christian Gmeiner wrote: > > > > > > > Am Mo., 10. Feb. 2020 um 11:58 Uhr schrieb Krzysztof Kozlowski > > > > > > > <krzk@kernel.org>: > > > > > > > > > > > > > > > > On Mon, 10 Feb 2020 at 11:54, Christian Gmeiner > > > > > > > > <christian.gmeiner@gmail.com> wrote: > > > > > > > > > > > > > > > > > > Am Fr., 24. Jan. 2020 um 09:44 Uhr schrieb Christian Gmeiner > > > > > > > > > <christian.gmeiner@gmail.com>: > > > > > > > > > > > > > > > > > > > > Makes it possible to multi v7 defconfig for stm32 and imx based devices with > > > > > > > > > > > > What do you mean by stm32 based devices here? > > > > > > > > > > > > > > > > CONFIG_ARCH_STM32 - I have a STM32MP157C-DK2 in my board farm and > > > > > would love to use > > > > > multi_v7 for imx6 and stm32. > > > > > > > > The patch is all about enabling drm-imx driver support. The commit log > > > > gives the impression that drm-imx driver also works on stm32 devices. > > > > Is that the case? > > > > > > > > > > No - the common thing both share is etnaviv. > > > > I did not know that before, and thanks for the information. But looking > > at the code change, there is nothing about etnaviv driver, and it's all > > about drm-imx driver. So I'm still questioning why stm32 needs to be > > mentioned in the commit log at all. > > > > > The patch subject "ARM: > > > multi_v7_defconfig: enable drm imx support" is fine > > > > Agreed. It's perfect. > > > > > I think but in the commit message I missed the verb so this should be > > > a better one: > > > > > > --->8--- > > > ARM: multi_v7_defconfig: enable drm imx support > > > > > > Makes it possible to use multi v7 defconfig for stm32 and imx based devices with > > > full drm support. > > > --->8--- > > > > I don't think 'stm32' should be there, as the code change in this commit > > has nothing to do with stm32, if I understand it correctly. > > > > Okay.. what about: > --->8--- > ARM: multi_v7_defconfig: enable drm imx support > > It will be useful to have it enabled for KernelCI boot and runtime testing. > --->8--- Applied with above commit log. Shawn
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 3f1b96dc7faa..d213a35557ed 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -637,6 +637,7 @@ CONFIG_CEC_PLATFORM_DRIVERS=y CONFIG_VIDEO_SAMSUNG_S5P_CEC=m CONFIG_VIDEO_ADV7180=m CONFIG_VIDEO_ML86V7667=m +CONFIG_IMX_IPUV3_CORE=m CONFIG_DRM=y # CONFIG_DRM_I2C_CH7006 is not set # CONFIG_DRM_I2C_SIL164 is not set @@ -652,6 +653,11 @@ CONFIG_ROCKCHIP_ANALOGIX_DP=y CONFIG_ROCKCHIP_DW_HDMI=y CONFIG_ROCKCHIP_DW_MIPI_DSI=y CONFIG_ROCKCHIP_INNO_HDMI=y +CONFIG_DRM_IMX=m +CONFIG_DRM_IMX_PARALLEL_DISPLAY=m +CONFIG_DRM_IMX_TVE=m +CONFIG_DRM_IMX_LDB=m +CONFIG_DRM_IMX_HDMI=m CONFIG_DRM_ATMEL_HLCDC=m CONFIG_DRM_RCAR_DU=m CONFIG_DRM_RCAR_LVDS=y
Makes it possible to multi v7 defconfig for stm32 and imx based devices with full drm support. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> --- arch/arm/configs/multi_v7_defconfig | 6 ++++++ 1 file changed, 6 insertions(+)