mbox series

[v3,0/5] aspeed-g6: enable usb support

Message ID 20200218031315.562-1-rentao.bupt@gmail.com (mailing list archive)
Headers show
Series aspeed-g6: enable usb support | expand

Message

Tao Ren Feb. 18, 2020, 3:13 a.m. UTC
From: Tao Ren <rentao.bupt@gmail.com>

The patch series aims at enabling USB Host and Gadget support on AST2600
platforms.

Patch #1 replaces hardcoded vhub port/endpoint number with device tree
properties, so that it's more convenient to add support for ast2600-vhub
which provides more downstream ports and endpoints.

Patch #2 enables ast2600 support in aspeed-vhub usb gadget driver.

Patch #3 adds USB devices and according pin groups in aspeed-g6 dtsi.

Patch #4 and #5 add vhub port/endpoint properties into aspeed-g4 and
aspeed-g5 dtsi.

Tao Ren (5):
  usb: gadget: aspeed: read vhub properties from device tree
  usb: gadget: aspeed: add ast2600 vhub support
  ARM: dts: aspeed-g6: add usb functions
  ARM: dts: aspeed-g5: add vhub port and endpoint properties
  ARM: dts: aspeed-g4: add vhub port and endpoint properties

 arch/arm/boot/dts/aspeed-g4.dtsi           |  2 +
 arch/arm/boot/dts/aspeed-g5.dtsi           |  2 +
 arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi   | 25 +++++++
 arch/arm/boot/dts/aspeed-g6.dtsi           | 45 ++++++++++++
 drivers/usb/gadget/udc/aspeed-vhub/Kconfig |  4 +-
 drivers/usb/gadget/udc/aspeed-vhub/core.c  | 79 +++++++++++++++-------
 drivers/usb/gadget/udc/aspeed-vhub/dev.c   | 30 +++++---
 drivers/usb/gadget/udc/aspeed-vhub/epn.c   |  4 +-
 drivers/usb/gadget/udc/aspeed-vhub/hub.c   | 26 ++++---
 drivers/usb/gadget/udc/aspeed-vhub/vhub.h  | 23 +++----
 10 files changed, 178 insertions(+), 62 deletions(-)

Comments

Andrew Jeffery Feb. 20, 2020, 12:25 a.m. UTC | #1
On Tue, 18 Feb 2020, at 13:43, rentao.bupt@gmail.com wrote:
> From: Tao Ren <rentao.bupt@gmail.com>
> 
> The patch series aims at enabling USB Host and Gadget support on AST2600
> platforms.
> 
> Patch #1 replaces hardcoded vhub port/endpoint number with device tree
> properties, so that it's more convenient to add support for ast2600-vhub
> which provides more downstream ports and endpoints.

Ah, something I should have mentioned on the previous series is you'll need
to update the binding documentation with the new properties.

> 
> Patch #2 enables ast2600 support in aspeed-vhub usb gadget driver.

Also need to add the 2600 support to the dt binding document.

Looks good to me otherwise.

Andrew
Tao Ren Feb. 20, 2020, 1:31 a.m. UTC | #2
On Thu, Feb 20, 2020 at 10:55:10AM +1030, Andrew Jeffery wrote:
> 
> 
> On Tue, 18 Feb 2020, at 13:43, rentao.bupt@gmail.com wrote:
> > From: Tao Ren <rentao.bupt@gmail.com>
> > 
> > The patch series aims at enabling USB Host and Gadget support on AST2600
> > platforms.
> > 
> > Patch #1 replaces hardcoded vhub port/endpoint number with device tree
> > properties, so that it's more convenient to add support for ast2600-vhub
> > which provides more downstream ports and endpoints.
> 
> Ah, something I should have mentioned on the previous series is you'll need
> to update the binding documentation with the new properties.

Looks like we don't have dt binding documentation for this driver. I will add
the document in my 2nd patch set "allow to customize vhub device IDs/strings"
so all the new dt properties are included in the doc.

> > 
> > Patch #2 enables ast2600 support in aspeed-vhub usb gadget driver.
> 
> Also need to add the 2600 support to the dt binding document.
> 
> Looks good to me otherwise.
> 
> Andrew

Thanks again for the quick review, Andrew.


Cheers,

Tao
Tao Ren Feb. 21, 2020, 12:27 a.m. UTC | #3
Hi Ben,

Could you provide some comments on this patch series while I'm working on
the other patch set (for vhub descriptors and DT binding document)?


Cheers,

Tao

On Mon, Feb 17, 2020 at 07:13:10PM -0800, rentao.bupt@gmail.com wrote:
> From: Tao Ren <rentao.bupt@gmail.com>
> 
> The patch series aims at enabling USB Host and Gadget support on AST2600
> platforms.
> 
> Patch #1 replaces hardcoded vhub port/endpoint number with device tree
> properties, so that it's more convenient to add support for ast2600-vhub
> which provides more downstream ports and endpoints.
> 
> Patch #2 enables ast2600 support in aspeed-vhub usb gadget driver.
> 
> Patch #3 adds USB devices and according pin groups in aspeed-g6 dtsi.
> 
> Patch #4 and #5 add vhub port/endpoint properties into aspeed-g4 and
> aspeed-g5 dtsi.
> 
> Tao Ren (5):
>   usb: gadget: aspeed: read vhub properties from device tree
>   usb: gadget: aspeed: add ast2600 vhub support
>   ARM: dts: aspeed-g6: add usb functions
>   ARM: dts: aspeed-g5: add vhub port and endpoint properties
>   ARM: dts: aspeed-g4: add vhub port and endpoint properties
> 
>  arch/arm/boot/dts/aspeed-g4.dtsi           |  2 +
>  arch/arm/boot/dts/aspeed-g5.dtsi           |  2 +
>  arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi   | 25 +++++++
>  arch/arm/boot/dts/aspeed-g6.dtsi           | 45 ++++++++++++
>  drivers/usb/gadget/udc/aspeed-vhub/Kconfig |  4 +-
>  drivers/usb/gadget/udc/aspeed-vhub/core.c  | 79 +++++++++++++++-------
>  drivers/usb/gadget/udc/aspeed-vhub/dev.c   | 30 +++++---
>  drivers/usb/gadget/udc/aspeed-vhub/epn.c   |  4 +-
>  drivers/usb/gadget/udc/aspeed-vhub/hub.c   | 26 ++++---
>  drivers/usb/gadget/udc/aspeed-vhub/vhub.h  | 23 +++----
>  10 files changed, 178 insertions(+), 62 deletions(-)
> 
> -- 
> 2.17.1
>