| Message ID | 1582049733-17050-4-git-send-email-tdas@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add modem Clock controller (MSS CC) driver for SC7180 | expand |
On Tue, 18 Feb 2020 23:45:31 +0530, Taniya Das wrote: > The Modem Subsystem clock provider have a bunch of generic properties > that are needed in a device tree. Add a YAML schemas for those. > > Signed-off-by: Taniya Das <tdas@codeaurora.org> > --- > .../devicetree/bindings/clock/qcom,sc7180-mss.yaml | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml > My bot found errors running 'make dt_binding_check' on your patch: Error: Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dts:21.26-27 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dt.yaml' failed make[1]: *** [Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dt.yaml] Error 1 Makefile:1263: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1240251 Please check and re-submit.
Hi Rob, On 2/19/2020 4:30 AM, Rob Herring wrote: > On Tue, 18 Feb 2020 23:45:31 +0530, Taniya Das wrote: >> The Modem Subsystem clock provider have a bunch of generic properties >> that are needed in a device tree. Add a YAML schemas for those. >> >> Signed-off-by: Taniya Das <tdas@codeaurora.org> >> --- >> .../devicetree/bindings/clock/qcom,sc7180-mss.yaml | 62 ++++++++++++++++++++++ >> 1 file changed, 62 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: > > Error: Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dts:21.26-27 syntax error > FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dt.yaml' failed > make[1]: *** [Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dt.yaml] Error 1 > Makefile:1263: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1240251 > Please check and re-submit. > I did see the same issue and then when I re-ordered by patches dt-bindings: clock: Add support for Modem clocks in GCC (dependent) on this binding patch, I no longer encountered the issue. https://patchwork.kernel.org/patch/11389243/ Please let me know.
Hey Taniya, + <&gcc GCC_MSS_NAV_AXIS_CLK>, error is because of ^^ typo it should be GCC_MSS_NAV_AXI_CLK instead, with that dt_bindings check will go though. On 2020-02-19 09:35, Taniya Das wrote: > Hi Rob, > > On 2/19/2020 4:30 AM, Rob Herring wrote: >> On Tue, 18 Feb 2020 23:45:31 +0530, Taniya Das wrote: >>> The Modem Subsystem clock provider have a bunch of generic properties >>> that are needed in a device tree. Add a YAML schemas for those. >>> >>> Signed-off-by: Taniya Das <tdas@codeaurora.org> >>> --- >>> .../devicetree/bindings/clock/qcom,sc7180-mss.yaml | 62 >>> ++++++++++++++++++++++ >>> 1 file changed, 62 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> Error: >> Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dts:21.26-27 >> syntax error >> FATAL ERROR: Unable to parse input tree >> scripts/Makefile.lib:300: recipe for target >> 'Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dt.yaml' >> failed >> make[1]: *** >> [Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dt.yaml] >> Error 1 >> Makefile:1263: recipe for target 'dt_binding_check' failed >> make: *** [dt_binding_check] Error 2 >> >> See https://patchwork.ozlabs.org/patch/1240251 >> Please check and re-submit. >> > > I did see the same issue and then when I re-ordered by patches > dt-bindings: clock: Add support for Modem clocks in GCC (dependent) on > this binding patch, I no longer encountered the issue. > https://patchwork.kernel.org/patch/11389243/ > > Please let me know.
On 2/20/2020 4:48 PM, Sibi Sankar wrote: > Hey Taniya, > > + <&gcc GCC_MSS_NAV_AXIS_CLK>, > > error is because of ^^ typo > it should be GCC_MSS_NAV_AXI_CLK > instead, with that dt_bindings > check will go though. > > Thanks Sibi for pointing the typo.
diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml new file mode 100644 index 0000000..db0080e --- /dev/null +++ b/Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/bindings/clock/qcom,sc7180-mss.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Modem Clock Controller Binding + +maintainers: + - Taniya Das <tdas@codeaurora.org> + +description: | + Qualcomm modem clock control module which supports the clocks. + + See also dt-bindings/clock/qcom,mss-sc7180.h. + +properties: + compatible: + enum: + - qcom,sc7180-mss + + clocks: + items: + - description: gcc_mss_mfab_axi clock from GCC + - description: gcc_mss_nav_axi clock from GCC + - description: gcc_mss_cfg_ahb clock from GCC + + clock-names: + items: + - const: gcc_mss_mfab_axis + - const: gcc_mss_nav_axi + - const: cfg_ahb + + '#clock-cells': + const: 1 + + reg: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - '#clock-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,gcc-sc7180.h> + clock-controller@41a8000 { + compatible = "qcom,sc7180-mss"; + reg = <0 0x041a8000 0 0x8000>; + clocks = <&gcc GCC_MSS_MFAB_AXIS_CLK>, + <&gcc GCC_MSS_NAV_AXIS_CLK>, + <&gcc GCC_MSS_CFG_AHB_CLK>; + clock-names = "gcc_mss_mfab_axis", + "gcc_mss_nav_axi", + "cfg_ahb"; + #clock-cells = <1>; + }; +...
The Modem Subsystem clock provider have a bunch of generic properties that are needed in a device tree. Add a YAML schemas for those. Signed-off-by: Taniya Das <tdas@codeaurora.org> --- .../devicetree/bindings/clock/qcom,sc7180-mss.yaml | 62 ++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml -- Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.