| Message ID | 20200220083508.792071-2-anarsoul@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add LCD support for Pine64 Pinebook 1080p | expand |
Hi Vasily, Thank you for the patch. On Thu, Feb 20, 2020 at 12:35:03AM -0800, Vasily Khoruzhick wrote: > From: Samuel Holland <samuel@sholland.org> > > We don't need to pass '-supply' suffix to devm_get_regulator() > > Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support") > Signed-off-by: Samuel Holland <samuel@sholland.org> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > index 56f55c53abfd..0d8d083b0207 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > @@ -712,14 +712,14 @@ static int anx6345_i2c_probe(struct i2c_client *client, > DRM_DEBUG("No panel found\n"); > > /* 1.2V digital core power regulator */ > - anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply"); > + anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12"); > if (IS_ERR(anx6345->dvdd12)) { > DRM_ERROR("dvdd12-supply not found\n"); > return PTR_ERR(anx6345->dvdd12); > } > > /* 2.5V digital core power regulator */ > - anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply"); > + anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25"); > if (IS_ERR(anx6345->dvdd25)) { > DRM_ERROR("dvdd25-supply not found\n"); > return PTR_ERR(anx6345->dvdd25);
On 20/02/2020 09:35, Vasily Khoruzhick wrote: > From: Samuel Holland <samuel@sholland.org> > > We don't need to pass '-supply' suffix to devm_get_regulator() > > Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support") > Signed-off-by: Samuel Holland <samuel@sholland.org> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> > --- > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > index 56f55c53abfd..0d8d083b0207 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > @@ -712,14 +712,14 @@ static int anx6345_i2c_probe(struct i2c_client *client, > DRM_DEBUG("No panel found\n"); > > /* 1.2V digital core power regulator */ > - anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply"); > + anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12"); > if (IS_ERR(anx6345->dvdd12)) { > DRM_ERROR("dvdd12-supply not found\n"); > return PTR_ERR(anx6345->dvdd12); > } > > /* 2.5V digital core power regulator */ > - anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply"); > + anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25"); > if (IS_ERR(anx6345->dvdd25)) { > DRM_ERROR("dvdd25-supply not found\n"); > return PTR_ERR(anx6345->dvdd25); > This is a duplicate of "drm/bridge: analogix-anx6345: Avoid duplicate -supply suffix" (20200218155440.BEFB968C65@verein.lst.de) But this one has fixes and review from laurent, so I'll push this one when the serie is ready Neil
On Fri, Feb 21, 2020 at 09:32:01AM +0100, Neil Armstrong wrote: > On 20/02/2020 09:35, Vasily Khoruzhick wrote: > > From: Samuel Holland <samuel@sholland.org> > > > > We don't need to pass '-supply' suffix to devm_get_regulator() > > > > Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support") > > Signed-off-by: Samuel Holland <samuel@sholland.org> > > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> > > --- > > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > > index 56f55c53abfd..0d8d083b0207 100644 > > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > > @@ -712,14 +712,14 @@ static int anx6345_i2c_probe(struct i2c_client *client, > > DRM_DEBUG("No panel found\n"); > > > > /* 1.2V digital core power regulator */ > > - anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply"); > > + anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12"); > > if (IS_ERR(anx6345->dvdd12)) { > > DRM_ERROR("dvdd12-supply not found\n"); > > return PTR_ERR(anx6345->dvdd12); > > } > > > > /* 2.5V digital core power regulator */ > > - anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply"); > > + anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25"); > > if (IS_ERR(anx6345->dvdd25)) { > > DRM_ERROR("dvdd25-supply not found\n"); > > return PTR_ERR(anx6345->dvdd25); > > > > This is a duplicate of "drm/bridge: analogix-anx6345: Avoid duplicate -supply suffix" (20200218155440.BEFB968C65@verein.lst.de) > > But this one has fixes and review from laurent, so I'll push this one when the serie is ready I really don't mind, as long as it gets fixed. The change is pretty obvious when you look at commit 69511a452e6dc. Signed-off-by: Torsten Duwe <duwe@suse.de> Reviewed-by: Mark Brown <broonie@kernel.org> (broonie had replied to my submission back in November) There's one other fix required for the anx6345 and, while at it, I had also fixed the code I copied in that hurry as well. What about these? All 3 fixes can go in independently, so I wouldn't tie them to this series. Torsten
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c index 56f55c53abfd..0d8d083b0207 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c @@ -712,14 +712,14 @@ static int anx6345_i2c_probe(struct i2c_client *client, DRM_DEBUG("No panel found\n"); /* 1.2V digital core power regulator */ - anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply"); + anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12"); if (IS_ERR(anx6345->dvdd12)) { DRM_ERROR("dvdd12-supply not found\n"); return PTR_ERR(anx6345->dvdd12); } /* 2.5V digital core power regulator */ - anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply"); + anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25"); if (IS_ERR(anx6345->dvdd25)) { DRM_ERROR("dvdd25-supply not found\n"); return PTR_ERR(anx6345->dvdd25);