| Message ID | 20200214120934.107924-1-maxime@cerno.tech (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/sun4i: tcon: Support LVDS on the A33 | expand |
On Fri, Feb 14, 2020 at 8:09 PM Maxime Ripard <maxime@cerno.tech> wrote: > > The A33 TCON supports LVDS, so we can toggle the support switch. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Chen-Yu Tsai <wens@csie.org> The user manual doesn't list the bits for LVDS signal polarity though. I assume this was verified with the BSP or actual testing? (or rather, will be in the LVDS signal polarity patches.)
Hi On Fri, Feb 21, 2020 at 11:10:47AM +0800, Chen-Yu Tsai wrote: > On Fri, Feb 14, 2020 at 8:09 PM Maxime Ripard <maxime@cerno.tech> wrote: > > > > The A33 TCON supports LVDS, so we can toggle the support switch. > > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > > Acked-by: Chen-Yu Tsai <wens@csie.org> > > The user manual doesn't list the bits for LVDS signal polarity though. > I assume this was verified with the BSP or actual testing? (or rather, > will be in the LVDS signal polarity patches.) The polarity stuff is a separate series :) But yeah, both were tested on hardware. I've applied it, thanks! Maxime
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index fdf143042f83..14026b4fa7c7 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -1475,6 +1475,7 @@ static const struct sun4i_tcon_quirks sun8i_a33_quirks = { .has_channel_0 = true, .has_lvds_alt = true, .dclk_min_div = 1, + .supports_lvds = true, }; static const struct sun4i_tcon_quirks sun8i_a83t_lcd_quirks = {
The A33 TCON supports LVDS, so we can toggle the support switch. Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 1 + 1 file changed, 1 insertion(+)