| Message ID | 20200221171030.39326-1-tony@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | clk: ti: am43xx: Fix clock parent for RTC clock | expand |
Quoting Tony Lindgren (2020-02-21 09:10:30) > Currently enabling clkctrl clock on am4 can fail for RTC as the clock > parent is wrong for RTC. > > Fixes: 76a1049b84dd ("clk: ti: am43xx: add new clkctrl data for am43xx") > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > > It is unclear if we can end up with RTC hung with the current mainline > kernel in some cases. Probing RTC with device tree data only seems to > trigger this every time. It's small enough and if it's annoying enough we can probably put it into clk-fixes to get it fixed for this release instead of waiting. Can Tero ack it?
On 21/02/2020 20:49, Stephen Boyd wrote: > Quoting Tony Lindgren (2020-02-21 09:10:30) >> Currently enabling clkctrl clock on am4 can fail for RTC as the clock >> parent is wrong for RTC. >> >> Fixes: 76a1049b84dd ("clk: ti: am43xx: add new clkctrl data for am43xx") >> Signed-off-by: Tony Lindgren <tony@atomide.com> >> --- >> >> It is unclear if we can end up with RTC hung with the current mainline >> kernel in some cases. Probing RTC with device tree data only seems to >> trigger this every time. > > It's small enough and if it's annoying enough we can probably put it > into clk-fixes to get it fixed for this release instead of waiting. Can > Tero ack it? > Sure, Acked-by: Tero Kristo <t-kristo@ti.com> -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Quoting Tero Kristo (2020-03-16 07:48:30) > On 21/02/2020 20:49, Stephen Boyd wrote: > > Quoting Tony Lindgren (2020-02-21 09:10:30) > >> Currently enabling clkctrl clock on am4 can fail for RTC as the clock > >> parent is wrong for RTC. > >> > >> Fixes: 76a1049b84dd ("clk: ti: am43xx: add new clkctrl data for am43xx") > >> Signed-off-by: Tony Lindgren <tony@atomide.com> > >> --- > >> > >> It is unclear if we can end up with RTC hung with the current mainline > >> kernel in some cases. Probing RTC with device tree data only seems to > >> trigger this every time. > > > > It's small enough and if it's annoying enough we can probably put it > > into clk-fixes to get it fixed for this release instead of waiting. Can > > Tero ack it? > > > > Sure, > > Acked-by: Tero Kristo <t-kristo@ti.com> > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Quoting Tero Kristo (2020-03-16 07:48:30) > On 21/02/2020 20:49, Stephen Boyd wrote: > > Quoting Tony Lindgren (2020-02-21 09:10:30) > >> Currently enabling clkctrl clock on am4 can fail for RTC as the clock > >> parent is wrong for RTC. > >> > >> Fixes: 76a1049b84dd ("clk: ti: am43xx: add new clkctrl data for am43xx") > >> Signed-off-by: Tony Lindgren <tony@atomide.com> > >> --- > >> > >> It is unclear if we can end up with RTC hung with the current mainline > >> kernel in some cases. Probing RTC with device tree data only seems to > >> trigger this every time. > > > > It's small enough and if it's annoying enough we can probably put it > > into clk-fixes to get it fixed for this release instead of waiting. Can > > Tero ack it? > > > > Sure, > > Acked-by: Tero Kristo <t-kristo@ti.com> Woops, hit send too fast. Thanks! Picked it into clk-fixes.
diff --git a/drivers/clk/ti/clk-43xx.c b/drivers/clk/ti/clk-43xx.c --- a/drivers/clk/ti/clk-43xx.c +++ b/drivers/clk/ti/clk-43xx.c @@ -78,7 +78,7 @@ static const struct omap_clkctrl_reg_data am4_gfx_l3_clkctrl_regs[] __initconst }; static const struct omap_clkctrl_reg_data am4_l4_rtc_clkctrl_regs[] __initconst = { - { AM4_L4_RTC_RTC_CLKCTRL, NULL, CLKF_SW_SUP, "clk_32768_ck" }, + { AM4_L4_RTC_RTC_CLKCTRL, NULL, CLKF_SW_SUP, "clkdiv32k_ick" }, { 0 }, };
Currently enabling clkctrl clock on am4 can fail for RTC as the clock parent is wrong for RTC. Fixes: 76a1049b84dd ("clk: ti: am43xx: add new clkctrl data for am43xx") Signed-off-by: Tony Lindgren <tony@atomide.com> --- It is unclear if we can end up with RTC hung with the current mainline kernel in some cases. Probing RTC with device tree data only seems to trigger this every time. --- drivers/clk/ti/clk-43xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)