| Message ID | 1582517363-11536-2-git-send-email-cang@codeaurora.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | e91ed9e0e4fa4ff913edb6e29c53f6a365e95609 |
| Headers | show |
| Series | Enable HOST_PA_TACTIVATE quirk for WDC UFS devices | expand |
Hi Can, On Sun, 2020-02-23 at 20:09 -0800, Can Guo wrote: > Currently ufshcd_vops_apply_dev_quirks() comes after all UniPro parameters > have been tuned. Move it up so that vendors have a chance to apply device > quirks in advance. > > Signed-off-by: Can Guo <cang@codeaurora.org> As discussed, ufs-mediatek needs to do corresponding patch and I will submit it once this commit is merged. Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Hi Stanley, On 2020-02-24 12:39, Stanley Chu wrote: > Hi Can, > > On Sun, 2020-02-23 at 20:09 -0800, Can Guo wrote: >> Currently ufshcd_vops_apply_dev_quirks() comes after all UniPro >> parameters >> have been tuned. Move it up so that vendors have a chance to apply >> device >> quirks in advance. >> >> Signed-off-by: Can Guo <cang@codeaurora.org> > > As discussed, ufs-mediatek needs to do corresponding patch and I will > submit it once this commit is merged. > > Reviewed-by: Stanley Chu <stanley.chu@mediatek.com> Yes, sure, thanks for your cooperation. :) Best Regards, Can Guo.
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index abd0e6b..03af432 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -6804,14 +6804,14 @@ static void ufshcd_tune_unipro_params(struct ufs_hba *hba) ufshcd_tune_pa_hibern8time(hba); } + ufshcd_vops_apply_dev_quirks(hba); + if (hba->dev_quirks & UFS_DEVICE_QUIRK_PA_TACTIVATE) /* set 1ms timeout for PA_TACTIVATE */ ufshcd_dme_set(hba, UIC_ARG_MIB(PA_TACTIVATE), 10); if (hba->dev_quirks & UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE) ufshcd_quirk_tune_host_pa_tactivate(hba); - - ufshcd_vops_apply_dev_quirks(hba); } static void ufshcd_clear_dbg_ufs_stats(struct ufs_hba *hba)
Currently ufshcd_vops_apply_dev_quirks() comes after all UniPro parameters have been tuned. Move it up so that vendors have a chance to apply device quirks in advance. Signed-off-by: Can Guo <cang@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)