| Message ID | 20200224183911.22403-1-dongli.zhang@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/1] null_blk: remove unused fields in 'nullb_cmd' | expand |
On 2020-02-24 10:39, Dongli Zhang wrote: > 'list', 'll_list' and 'csd' are no longer used. > > The 'list' is not used since it was introduced by commit f2298c0403b0 > ("null_blk: multi queue aware block test driver"). > > The 'll_list' is no longer used since commit 3c395a969acc ("null_blk: set a > separate timer for each command"). > > The 'csd' is no longer used since commit ce2c350b2cfe ("null_blk: use > blk_complete_request and blk_mq_complete_request"). Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On 2/24/20 11:39 AM, Dongli Zhang wrote: > 'list', 'll_list' and 'csd' are no longer used. > > The 'list' is not used since it was introduced by commit f2298c0403b0 > ("null_blk: multi queue aware block test driver"). > > The 'll_list' is no longer used since commit 3c395a969acc ("null_blk: set a > separate timer for each command"). > > The 'csd' is no longer used since commit ce2c350b2cfe ("null_blk: use > blk_complete_request and blk_mq_complete_request"). Applied, thanks.
diff --git a/drivers/block/null_blk.h b/drivers/block/null_blk.h index bc837862b767..62b660821dbc 100644 --- a/drivers/block/null_blk.h +++ b/drivers/block/null_blk.h @@ -14,9 +14,6 @@ #include <linux/fault-inject.h> struct nullb_cmd { - struct list_head list; - struct llist_node ll_list; - struct __call_single_data csd; struct request *rq; struct bio *bio; unsigned int tag; diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c index 16510795e377..133060431dbd 100644 --- a/drivers/block/null_blk_main.c +++ b/drivers/block/null_blk_main.c @@ -1518,8 +1518,6 @@ static int setup_commands(struct nullb_queue *nq) for (i = 0; i < nq->queue_depth; i++) { cmd = &nq->cmds[i]; - INIT_LIST_HEAD(&cmd->list); - cmd->ll_list.next = NULL; cmd->tag = -1U; }
'list', 'll_list' and 'csd' are no longer used. The 'list' is not used since it was introduced by commit f2298c0403b0 ("null_blk: multi queue aware block test driver"). The 'll_list' is no longer used since commit 3c395a969acc ("null_blk: set a separate timer for each command"). The 'csd' is no longer used since commit ce2c350b2cfe ("null_blk: use blk_complete_request and blk_mq_complete_request"). Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com> --- Changes since v1: - Remove 'list' and 'csd' as well. drivers/block/null_blk.h | 3 --- drivers/block/null_blk_main.c | 2 -- 2 files changed, 5 deletions(-)