| Message ID | 0f506cfdd8eb9d50b5eb43c9dca510284ac8ded1.1582615616.git.amit.kucheria@linaro.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Cleanup dtbs_check warnings for tsens | expand |
On 25-02-20, 13:01, Amit Kucheria wrote: > Fixes the following warnings: > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c263000: compatible: ['qcom,sc7180-tsens', > 'qcom,tsens-v2'] is not valid under any of the given schemas (Possible > causes of the failure): > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of > ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c263000: compatible:1: 'qcom,tsens-v0_1' was expected > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c263000: compatible:1: 'qcom,tsens-v1' was expected I think the patch title should be "add qcom,sc7180-tsens to qcom-tsens.yaml" and it would be great to see explanation on how adding it fixes these warns. Relooking at series I think this applies to rest of the series too :) Thanks > > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c265000: compatible: ['qcom,sc7180-tsens', > 'qcom,tsens-v2'] is not valid under any of the given schemas (Possible > causes of the failure): > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of > ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c265000: compatible:1: 'qcom,tsens-v0_1' was expected > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > thermal-sensor@c265000: compatible:1: 'qcom,tsens-v1' was expected > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > index eef13b9446a8..13e294328932 100644 > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > @@ -39,6 +39,7 @@ properties: > - qcom,msm8996-tsens > - qcom,msm8998-tsens > - qcom,sdm845-tsens > + - qcom,sc7180-tsens > - const: qcom,tsens-v2 > > reg: > -- > 2.20.1
On Tue, Feb 25, 2020 at 3:46 PM Vinod Koul <vkoul@kernel.org> wrote: > > On 25-02-20, 13:01, Amit Kucheria wrote: > > Fixes the following warnings: > > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > > thermal-sensor@c263000: compatible: ['qcom,sc7180-tsens', > > 'qcom,tsens-v2'] is not valid under any of the given schemas (Possible > > causes of the failure): > > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > > thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of > > ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] > > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > > thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of > > ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] > > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > > thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of > > ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] > > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > > thermal-sensor@c263000: compatible:1: 'qcom,tsens-v0_1' was expected > > builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: > > thermal-sensor@c263000: compatible:1: 'qcom,tsens-v1' was expected > > I think the patch title should be "add qcom,sc7180-tsens to qcom-tsens.yaml" > > and it would be great to see explanation on how adding it fixes these > warns. Agreed. I'll send out a new version with the commit messages fixed. > Relooking at series I think this applies to rest of the series too :) > Thanks for the review.
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index eef13b9446a8..13e294328932 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml @@ -39,6 +39,7 @@ properties: - qcom,msm8996-tsens - qcom,msm8998-tsens - qcom,sdm845-tsens + - qcom,sc7180-tsens - const: qcom,tsens-v2 reg:
Fixes the following warnings: builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c263000: compatible: ['qcom,sc7180-tsens', 'qcom,tsens-v2'] is not valid under any of the given schemas (Possible causes of the failure): builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c263000: compatible:0: 'qcom,sc7180-tsens' is not one of ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c263000: compatible:1: 'qcom,tsens-v0_1' was expected builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c263000: compatible:1: 'qcom,tsens-v1' was expected builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c265000: compatible: ['qcom,sc7180-tsens', 'qcom,tsens-v2'] is not valid under any of the given schemas (Possible causes of the failure): builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of ['qcom,msm8916-tsens', 'qcom,msm8974-tsens'] builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of ['qcom,msm8976-tsens', 'qcom,qcs404-tsens'] builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c265000: compatible:0: 'qcom,sc7180-tsens' is not one of ['qcom,msm8996-tsens', 'qcom,msm8998-tsens', 'qcom,sdm845-tsens'] builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c265000: compatible:1: 'qcom,tsens-v0_1' was expected builds/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: thermal-sensor@c265000: compatible:1: 'qcom,tsens-v1' was expected Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> --- Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 + 1 file changed, 1 insertion(+)