| Message ID | 20200228101120.28819-1-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1a1b3743487317514f7d5d66dd9d6c9233321eba |
| Headers | show |
| Series | [v2] ASoC: samsung: Silence warnings during deferred probe | expand |
On Fri, Feb 28, 2020 at 11:11:20AM +0100, Marek Szyprowski wrote: > Don't confuse user with meaningless warning about the failure in getting > resources and registering card in case of deferred probe. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > sound/soc/samsung/arndale.c | 4 +++- > sound/soc/samsung/littlemill.c | 2 +- > sound/soc/samsung/lowland.c | 2 +- > sound/soc/samsung/odroid.c | 4 +++- > sound/soc/samsung/smdk_wm8994.c | 2 +- > sound/soc/samsung/smdk_wm8994pcm.c | 2 +- > sound/soc/samsung/snow.c | 4 +++- > sound/soc/samsung/speyside.c | 2 +- > sound/soc/samsung/tm2_wm5110.c | 3 ++- > sound/soc/samsung/tobermory.c | 2 +- > 10 files changed, 17 insertions(+), 10 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Fri, Feb 28, 2020 at 11:11:20AM +0100, Marek Szyprowski wrote: > Don't confuse user with meaningless warning about the failure in getting > resources and registering card in case of deferred probe. > if (ret) { > - dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, > + "snd_soc_register_card() failed: %d\n", ret); This is completely removing the diagnostics so if things do get stuck the user will generally not have any hint as to what's going wrong - it's better with this sort of change to lower to dev_dbg() for deferral rather than completely removing the error message so the user has some ability to figure out what was missing. However in this case it's also the case that snd_soc_register_card() is fairly noisy.
On Fri, 28 Feb 2020 at 17:12, Mark Brown <broonie@kernel.org> wrote: > > On Fri, Feb 28, 2020 at 11:11:20AM +0100, Marek Szyprowski wrote: > > > Don't confuse user with meaningless warning about the failure in getting > > resources and registering card in case of deferred probe. > > > if (ret) { > > - dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); > > + if (ret != -EPROBE_DEFER) > > + dev_err(&pdev->dev, > > + "snd_soc_register_card() failed: %d\n", ret); > > This is completely removing the diagnostics so if things do get stuck > the user will generally not have any hint as to what's going wrong - > it's better with this sort of change to lower to dev_dbg() for deferral > rather than completely removing the error message so the user has some > ability to figure out what was missing. However in this case it's also > the case that snd_soc_register_card() is fairly noisy. This dev_dbg could be achieved with ftrace for probe() as well. I think it is quite common to skip all messages for deferred probes. Best regards, Krzysztof
On Fri, Feb 28, 2020 at 06:45:33PM +0100, Krzysztof Kozlowski wrote: > On Fri, 28 Feb 2020 at 17:12, Mark Brown <broonie@kernel.org> wrote: > > This is completely removing the diagnostics so if things do get stuck > > the user will generally not have any hint as to what's going wrong - > > it's better with this sort of change to lower to dev_dbg() for deferral > > rather than completely removing the error message so the user has some > > ability to figure out what was missing. However in this case it's also > > the case that snd_soc_register_card() is fairly noisy. > This dev_dbg could be achieved with ftrace for probe() as well. I > think it is quite common to skip all messages for deferred probes. Yes... and having had the pleasure of debugging problems with things not instantiating I'm not a fan of this trend.
diff --git a/sound/soc/samsung/arndale.c b/sound/soc/samsung/arndale.c index d64602950cbd..6e6d67d6e0ab 100644 --- a/sound/soc/samsung/arndale.c +++ b/sound/soc/samsung/arndale.c @@ -174,7 +174,9 @@ static int arndale_audio_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(card->dev, card); if (ret) { - dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, + "snd_soc_register_card() failed: %d\n", ret); goto err_put_of_nodes; } return 0; diff --git a/sound/soc/samsung/littlemill.c b/sound/soc/samsung/littlemill.c index 59904f44118b..2f2f83a8c23a 100644 --- a/sound/soc/samsung/littlemill.c +++ b/sound/soc/samsung/littlemill.c @@ -325,7 +325,7 @@ static int littlemill_probe(struct platform_device *pdev) card->dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); diff --git a/sound/soc/samsung/lowland.c b/sound/soc/samsung/lowland.c index 098eefc764db..fcc7897ee7d0 100644 --- a/sound/soc/samsung/lowland.c +++ b/sound/soc/samsung/lowland.c @@ -183,7 +183,7 @@ static int lowland_probe(struct platform_device *pdev) card->dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); diff --git a/sound/soc/samsung/odroid.c b/sound/soc/samsung/odroid.c index f0f5fa9c27d3..30c7e1bc2a30 100644 --- a/sound/soc/samsung/odroid.c +++ b/sound/soc/samsung/odroid.c @@ -311,7 +311,9 @@ static int odroid_audio_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(dev, card); if (ret < 0) { - dev_err(dev, "snd_soc_register_card() failed: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(dev, "snd_soc_register_card() failed: %d\n", + ret); goto err_put_clk_i2s; } diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c index 28f8be000aa1..8fa5f6b387ad 100644 --- a/sound/soc/samsung/smdk_wm8994.c +++ b/sound/soc/samsung/smdk_wm8994.c @@ -178,7 +178,7 @@ static int smdk_audio_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed:%d\n", ret); return ret; diff --git a/sound/soc/samsung/smdk_wm8994pcm.c b/sound/soc/samsung/smdk_wm8994pcm.c index 2e3dc7320c62..6e44f7927852 100644 --- a/sound/soc/samsung/smdk_wm8994pcm.c +++ b/sound/soc/samsung/smdk_wm8994pcm.c @@ -118,7 +118,7 @@ static int snd_smdk_probe(struct platform_device *pdev) smdk_pcm.dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, &smdk_pcm); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card failed %d\n", ret); return ret; diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c index f075aae9561a..bebcf0a4d608 100644 --- a/sound/soc/samsung/snow.c +++ b/sound/soc/samsung/snow.c @@ -216,7 +216,9 @@ static int snow_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(dev, card); if (ret) { - dev_err(&pdev->dev, "snd_soc_register_card failed (%d)\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, + "snd_soc_register_card failed (%d)\n", ret); return ret; } diff --git a/sound/soc/samsung/speyside.c b/sound/soc/samsung/speyside.c index ea0d1ec67f01..8f175f204eb7 100644 --- a/sound/soc/samsung/speyside.c +++ b/sound/soc/samsung/speyside.c @@ -330,7 +330,7 @@ static int speyside_probe(struct platform_device *pdev) card->dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c index 10ff14b856f2..043a287728b3 100644 --- a/sound/soc/samsung/tm2_wm5110.c +++ b/sound/soc/samsung/tm2_wm5110.c @@ -611,7 +611,8 @@ static int tm2_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(dev, card); if (ret < 0) { - dev_err(dev, "Failed to register card: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to register card: %d\n", ret); goto dai_node_put; } diff --git a/sound/soc/samsung/tobermory.c b/sound/soc/samsung/tobermory.c index fdce28cc26c4..1aa3fdb4b152 100644 --- a/sound/soc/samsung/tobermory.c +++ b/sound/soc/samsung/tobermory.c @@ -229,7 +229,7 @@ static int tobermory_probe(struct platform_device *pdev) card->dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret);