| Message ID | 20200229163043.158262-4-jernej.skrabec@siol.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: dw-hdmi: Various updates | expand |
On 29/02/2020 17:30, Jernej Skrabec wrote: > From: Jonas Karlman <jonas@kwiboo.se> > > Setting scan mode to "none" confuses some TVs like LG B8, which randomly > change overscan procentage over time. Digital outputs like HDMI and DVI, > handled by this controller, don't really need overscan, so we can always > set scan mode to underscan. Actually, this is exactly what > drm_hdmi_avi_infoframe_from_display_mode() already does, so we can just > remove offending line. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> > [updated commit message] > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 9d7bfb1cb213..3d6021119942 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -1655,8 +1655,6 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode) > HDMI_EXTENDED_COLORIMETRY_XV_YCC_601; > } > > - frame.scan_mode = HDMI_SCAN_MODE_NONE; > - > /* > * The Designware IP uses a different byte format from standard > * AVI info frames, though generally the bits are in the correct > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Hi Jernej and Jonas, Thank you for the patch. On Sat, Feb 29, 2020 at 05:30:42PM +0100, Jernej Skrabec wrote: > From: Jonas Karlman <jonas@kwiboo.se> > > Setting scan mode to "none" confuses some TVs like LG B8, which randomly > change overscan procentage over time. Digital outputs like HDMI and DVI, s/procentage/percentage/ ? > handled by this controller, don't really need overscan, so we can always > set scan mode to underscan. Actually, this is exactly what > drm_hdmi_avi_infoframe_from_display_mode() already does, so we can just > remove offending line. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> > [updated commit message] > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 9d7bfb1cb213..3d6021119942 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -1655,8 +1655,6 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode) > HDMI_EXTENDED_COLORIMETRY_XV_YCC_601; > } > > - frame.scan_mode = HDMI_SCAN_MODE_NONE; > - > /* > * The Designware IP uses a different byte format from standard > * AVI info frames, though generally the bits are in the correct
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 9d7bfb1cb213..3d6021119942 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -1655,8 +1655,6 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode) HDMI_EXTENDED_COLORIMETRY_XV_YCC_601; } - frame.scan_mode = HDMI_SCAN_MODE_NONE; - /* * The Designware IP uses a different byte format from standard * AVI info frames, though generally the bits are in the correct