| Message ID | 20200119121730.10701-3-yukuai3@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cleanup patches for unused variables | expand |
On 1/19/20 1:17 PM, yu kuai wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/aty/radeon_base.c: In function > ‘radeonfb_set_par’: > drivers/video/fbdev/aty/radeon_base.c:1653:38: warning: variable > ‘vSyncPol’ set but not used [-Wunused-but-set-variable] > > It is never used, and so can be removed. > > Signed-off-by: yu kuai <yukuai3@huawei.com> Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/aty/radeon_base.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c > index d2e68ec580c2..0666f848bf70 100644 > --- a/drivers/video/fbdev/aty/radeon_base.c > +++ b/drivers/video/fbdev/aty/radeon_base.c > @@ -1650,7 +1650,7 @@ static int radeonfb_set_par(struct fb_info *info) > struct fb_var_screeninfo *mode = &info->var; > struct radeon_regs *newmode; > int hTotal, vTotal, hSyncStart, hSyncEnd, > - vSyncStart, vSyncEnd, vSyncPol, cSync; > + vSyncStart, vSyncEnd, cSync; > u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5}; > u8 hsync_fudge_fp[] = {2, 2, 0, 0, 5, 5}; > u32 sync, h_sync_pol, v_sync_pol, dotClock, pixClock; > @@ -1730,8 +1730,6 @@ static int radeonfb_set_par(struct fb_info *info) > else if (vsync_wid > 0x1f) /* max */ > vsync_wid = 0x1f; > > - vSyncPol = mode->sync & FB_SYNC_VERT_HIGH_ACT ? 0 : 1; > - > cSync = mode->sync & FB_SYNC_COMP_HIGH_ACT ? (1 << 4) : 0; > > format = radeon_get_dstbpp(depth); >
diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c index d2e68ec580c2..0666f848bf70 100644 --- a/drivers/video/fbdev/aty/radeon_base.c +++ b/drivers/video/fbdev/aty/radeon_base.c @@ -1650,7 +1650,7 @@ static int radeonfb_set_par(struct fb_info *info) struct fb_var_screeninfo *mode = &info->var; struct radeon_regs *newmode; int hTotal, vTotal, hSyncStart, hSyncEnd, - vSyncStart, vSyncEnd, vSyncPol, cSync; + vSyncStart, vSyncEnd, cSync; u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5}; u8 hsync_fudge_fp[] = {2, 2, 0, 0, 5, 5}; u32 sync, h_sync_pol, v_sync_pol, dotClock, pixClock; @@ -1730,8 +1730,6 @@ static int radeonfb_set_par(struct fb_info *info) else if (vsync_wid > 0x1f) /* max */ vsync_wid = 0x1f; - vSyncPol = mode->sync & FB_SYNC_VERT_HIGH_ACT ? 0 : 1; - cSync = mode->sync & FB_SYNC_COMP_HIGH_ACT ? (1 << 4) : 0; format = radeon_get_dstbpp(depth);
Fixes gcc '-Wunused-but-set-variable' warning: drivers/video/fbdev/aty/radeon_base.c: In function ‘radeonfb_set_par’: drivers/video/fbdev/aty/radeon_base.c:1653:38: warning: variable ‘vSyncPol’ set but not used [-Wunused-but-set-variable] It is never used, and so can be removed. Signed-off-by: yu kuai <yukuai3@huawei.com> --- drivers/video/fbdev/aty/radeon_base.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)