| Message ID | 1583222684-10229-2-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | [1/2] thermal: Fix build warning of !defined(CONFIG_THERMAL_OF) | expand |
On Tue, Mar 3, 2020 at 1:40 PM Anson Huang <Anson.Huang@nxp.com> wrote: > > i.MX SCU thermal driver depends on IMX_SCU which does NOT have > COMPILE_TEST enabled, so need to remove COMPILE_TEST for i.MX > SCU thermal as well. Wouldn't a better solution be to add COMPILE_TEST to IMX_SCU to improve compile coverage? > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > drivers/thermal/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 165b7d6..4fb87df 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -253,7 +253,7 @@ config IMX_THERMAL > > config IMX_SC_THERMAL > tristate "Temperature sensor driver for NXP i.MX SoCs with System Controller" > - depends on IMX_SCU || COMPILE_TEST > + depends on IMX_SCU > depends on OF > help > Support for Temperature Monitor (TEMPMON) found on NXP i.MX SoCs with > -- > 2.7.4 >
Hi, Amit > Subject: Re: [PATCH 2/2] thermal: Remove COMPILE_TEST for > IMX_SC_THERMAL > > On Tue, Mar 3, 2020 at 1:40 PM Anson Huang <Anson.Huang@nxp.com> > wrote: > > > > i.MX SCU thermal driver depends on IMX_SCU which does NOT have > > COMPILE_TEST enabled, so need to remove COMPILE_TEST for i.MX SCU > > thermal as well. > > Wouldn't a better solution be to add COMPILE_TEST to IMX_SCU to improve > compile coverage? It is a good idea, but I think since there are many i.MX8 modules driver also depend on IMX_SCU, It would be better to cut another patch set to enable COMPILE_TEST for IMX_SCU as well as all those modules that depend on it, then the compile coverage will cover all i.MX8 modules depend on IMX_SCU. Thanks, Anson
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 165b7d6..4fb87df 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -253,7 +253,7 @@ config IMX_THERMAL config IMX_SC_THERMAL tristate "Temperature sensor driver for NXP i.MX SoCs with System Controller" - depends on IMX_SCU || COMPILE_TEST + depends on IMX_SCU depends on OF help Support for Temperature Monitor (TEMPMON) found on NXP i.MX SoCs with
i.MX SCU thermal driver depends on IMX_SCU which does NOT have COMPILE_TEST enabled, so need to remove COMPILE_TEST for i.MX SCU thermal as well. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- drivers/thermal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)