| Message ID | 20200301212019.2248-2-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for suspend clk for Exynos5422 SoC | expand |
On Sun, Mar 01, 2020 at 09:20:16PM +0000, Anand Moon wrote: > This patch adds the new compatible string for Exynos5422 DWC3 > to support enable/disable of core and suspend clk by DWC3 driver. > Also updated the clock names for compatible samsung,exynos5420-dwusb3. Some time ago I mentioned this... so once more: Do not use "This patch adds" but simple "Add". https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151 Best regards, Krzysztof > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > Previous changes: > Added the missing clock name for Exynos5420 complatible > --- > Documentation/devicetree/bindings/usb/exynos-usb.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt > index 6aae1544f240..220f729ac8eb 100644 > --- a/Documentation/devicetree/bindings/usb/exynos-usb.txt > +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt > @@ -69,7 +69,9 @@ DWC3 > Required properties: > - compatible: should be one of the following - > "samsung,exynos5250-dwusb3": for USB 3.0 DWC3 controller on > - Exynos5250/5420. > + Exynos5250. > + "samsung,exynos5420-dwusb3": for USB 3.0 DWC3 controller on > + Exynos5420. > "samsung,exynos5433-dwusb3": for USB 3.0 DWC3 controller on > Exynos5433. > "samsung,exynos7-dwusb3": for USB 3.0 DWC3 controller on Exynos7. > @@ -82,6 +84,7 @@ Required properties: > Following clock names shall be provided for different > compatibles: > - samsung,exynos5250-dwusb3: "usbdrd30", > + - samsung,exynos5420-dwusb3: "usbdrd30", "usbdrd30_susp_clk", > - samsung,exynos5433-dwusb3: "aclk", "susp_clk", "pipe_pclk", > "phyclk", > - samsung,exynos7-dwusb3: "usbdrd30", "usbdrd30_susp_clk", > -- > 2.25.1 >
On Sun, 1 Mar 2020 21:20:16 +0000, Anand Moon wrote: > This patch adds the new compatible string for Exynos5422 DWC3 > to support enable/disable of core and suspend clk by DWC3 driver. > Also updated the clock names for compatible samsung,exynos5420-dwusb3. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > Previous changes: > Added the missing clock name for Exynos5420 complatible > --- > Documentation/devicetree/bindings/usb/exynos-usb.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
Hi Krzysztof, On Tue, 3 Mar 2020 at 15:16, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Sun, Mar 01, 2020 at 09:20:16PM +0000, Anand Moon wrote: > > This patch adds the new compatible string for Exynos5422 DWC3 > > to support enable/disable of core and suspend clk by DWC3 driver. > > Also updated the clock names for compatible samsung,exynos5420-dwusb3. > > Some time ago I mentioned this... so once more: > Do not use "This patch adds" but simple "Add". > https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151 > Ok I will keep this in my mind next time I update my patchs. > Best regards, > Krzysztof > -Anand
Anand Moon <linux.amoon@gmail.com> writes: > This patch adds the new compatible string for Exynos5422 DWC3 > to support enable/disable of core and suspend clk by DWC3 driver. > Also updated the clock names for compatible samsung,exynos5420-dwusb3. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> doesn't apply: checking file Documentation/devicetree/bindings/usb/exynos-usb.txt Hunk #2 FAILED at 84. 1 out of 2 hunks FAILED
diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt index 6aae1544f240..220f729ac8eb 100644 --- a/Documentation/devicetree/bindings/usb/exynos-usb.txt +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt @@ -69,7 +69,9 @@ DWC3 Required properties: - compatible: should be one of the following - "samsung,exynos5250-dwusb3": for USB 3.0 DWC3 controller on - Exynos5250/5420. + Exynos5250. + "samsung,exynos5420-dwusb3": for USB 3.0 DWC3 controller on + Exynos5420. "samsung,exynos5433-dwusb3": for USB 3.0 DWC3 controller on Exynos5433. "samsung,exynos7-dwusb3": for USB 3.0 DWC3 controller on Exynos7. @@ -82,6 +84,7 @@ Required properties: Following clock names shall be provided for different compatibles: - samsung,exynos5250-dwusb3: "usbdrd30", + - samsung,exynos5420-dwusb3: "usbdrd30", "usbdrd30_susp_clk", - samsung,exynos5433-dwusb3: "aclk", "susp_clk", "pipe_pclk", "phyclk", - samsung,exynos7-dwusb3: "usbdrd30", "usbdrd30_susp_clk",
This patch adds the new compatible string for Exynos5422 DWC3 to support enable/disable of core and suspend clk by DWC3 driver. Also updated the clock names for compatible samsung,exynos5420-dwusb3. Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- Previous changes: Added the missing clock name for Exynos5420 complatible --- Documentation/devicetree/bindings/usb/exynos-usb.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)